Re: refs/notes/amlog problems, was Re: [PATCH v3 01/20] linear-assignment: a function to solve least-cost assignment problems

2018-07-22 Thread Jeff King
On Sat, Jul 21, 2018 at 11:56:06PM +0200, Johannes Schindelin wrote: > > The script that I feed a message from gmane or public-inbox when I need > > to learn the set of commits that resulted from the message instead uses > > "git grep $message-id notes/amlog". And that is fast enough for my > >

t7406-submodule-update shaky ?

2018-07-22 Thread Torsten Bögershausen
It seems that t7406 is sometimes shaky - when checking stderr in test case 4. The order of the submodules may vary, sorting the stderr output makes it more reliable (and somewhat funny to read). Does anybody have a better idea ? [] cat

Re: Hash algorithm analysis

2018-07-22 Thread Adam Langley
Somewhere upthread, Brian refers to me as a cryptographer. That's flattering (thank you), but probably not really true even on a good day. And certainly not true next to Joan Daemen. I do have experience with crypto at scale and in ecosystems, though. Joan's count of cryptanalysis papers is a

Hello Beautiful

2018-07-22 Thread Jack
Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think

Re: Hash algorithm analysis

2018-07-22 Thread Joan Daemen
Dear all, I wanted to react to some statements I read in this discussion. But first let me introduce myself. I'm Joan Daemen and I'm working in symmetric cryptography since 1988. Vincent Rijmen and I designed Rijndael that was selected to become AES and Guido Bertoni, Michael Peeters and Gilles

Re: Hash algorithm analysis

2018-07-22 Thread Eric Deplagne
On Sun, 22 Jul 2018 14:21:48 +, brian m. carlson wrote: > On Sun, Jul 22, 2018 at 11:34:42AM +0200, Eric Deplagne wrote: > > On Sat, 21 Jul 2018 23:59:41 +, brian m. carlson wrote: > > > I don't know your colleagues, and they haven't commented here. One > > > person that has commented

Re: Hash algorithm analysis

2018-07-22 Thread brian m. carlson
On Sun, Jul 22, 2018 at 11:34:42AM +0200, Eric Deplagne wrote: > On Sat, 21 Jul 2018 23:59:41 +, brian m. carlson wrote: > > I don't know your colleagues, and they haven't commented here. One > > person that has commented here is Adam Langley. It is my impression > > (and anyone is free to

Re: [RFC PATCH 2/5] Add delta-islands.{c,h}

2018-07-22 Thread Christian Couder
On Sun, Jul 22, 2018 at 10:50 AM, Duy Nguyen wrote: > On Sun, Jul 22, 2018 at 7:51 AM Christian Couder > wrote: >> +pack.island:: >> + A regular expression configuring a set of delta islands. See >> + "DELTA ISLANDS" in linkgit:git-pack-objects[1] for details. >> + > > That section

Re: [PATCH 02/14] format-patch: add --interdiff option to embed diff in cover letter

2018-07-22 Thread Eric Sunshine
On Sun, Jul 22, 2018 at 5:57 AM Eric Sunshine wrote: > Add an --interdiff option to automate this process. The argument to > --interdiff specifies the tip of the previous attempt against which to > generate the interdiff. > > Signed-off-by: Eric Sunshine > --- > diff --git a/interdiff.c

Re: Hash algorithm analysis

2018-07-22 Thread Eric Deplagne
On Sat, 21 Jul 2018 23:59:41 +, brian m. carlson wrote: > On Sun, Jul 22, 2018 at 12:38:41AM +0200, Johannes Schindelin wrote: > > Do you really want to value contributors' opinion more than > > cryptographers'? I mean, that's exactly what got us into this hard-coded > > SHA-1 mess in the

[PATCH 14/14] format-patch: allow --range-diff to apply to a lone-patch

2018-07-22 Thread Eric Sunshine
When submitting a revised version of a patch or series, it can be helpful (to reviewers) to include a summary of changes since the previous attempt in the form of a range-diff, typically in the cover letter. However, it is occasionally useful, despite making for a noisy read, to insert a

[PATCH 00/14] format-patch: add --interdiff and --range-diff options

2018-07-22 Thread Eric Sunshine
When re-submitting a patch series, it is often helpful (for reviewers) to include an interdiff or range-diff against the previous version. Doing so requires manually running git-diff or git-range-diff and copy/pasting the result into the cover letter of the new version. This series automates the

[PATCH 09/14] range-diff: relieve callers of low-level configuration burden

2018-07-22 Thread Eric Sunshine
There are a number of very low-level configuration details which need to be managed precisely to generate a proper range-diff. In particular, 'diff_options' output format, header suppression, indentation, and dual-color mode must all be set appropriately to ensure proper behavior. Handle these

[PATCH 06/14] format-patch: allow --interdiff to apply to a lone-patch

2018-07-22 Thread Eric Sunshine
When submitting a revised version of a patch or series, it can be helpful (to reviewers) to include a summary of changes since the previous attempt in the form of an interdiff, typically in the cover letter. However, it is occasionally useful, despite making for a noisy read, to insert an

[PATCH 05/14] log-tree: show_log: make commentary block delimiting reusable

2018-07-22 Thread Eric Sunshine
In patches generated by git-format-patch, the area below the "---" line following the commit message and before the actual 'diff' can be used for commentary which the patch author wants to convey to readers of the patch itself but not include in the commit message proper. By default, the

[PATCH 08/14] range-diff: publish default creation factor

2018-07-22 Thread Eric Sunshine
The range-diff back-end allows its heuristic to be tweaked via the "creation factor". git-range-diff, the only client of the back-end, defaults the factor to 60% (hard-coded in builtin/range-diff.c), but allows the user to override it with the --creation-factor option. Publish the default range

[PATCH 04/14] interdiff: teach show_interdiff() to indent interdiff

2018-07-22 Thread Eric Sunshine
A future change will allow "git format-patch --interdiff= -1" to insert an interdiff into the commentary section of the lone patch of a 1-patch series. However, to prevent the inserted interdiff from confusing git-am, as well as human readers, it needs to be indented. Therefore, teach

[PATCH 13/14] format-patch: add --creation-factor tweak for --range-diff

2018-07-22 Thread Eric Sunshine
When generating a range-diff, matching up commits between two version of a patch series involves heuristics, thus may give unexpected results. git-range-diff allows tweaking the heuristic via --creation-factor. Follow suit by accepting --creation-factor in combination with --range-diff when

[PATCH 03/14] format-patch: teach --interdiff to respect -v/--reroll-count

2018-07-22 Thread Eric Sunshine
The --interdiff option introduces the embedded interdiff generically as "Interdiff:", however, we can do better when --reroll-count is specified by emitting "Interdiff against v{n}:" instead. Signed-off-by: Eric Sunshine --- builtin/log.c | 17 - revision.h

[PATCH 01/14] format-patch: allow additional generated content in make_cover_letter()

2018-07-22 Thread Eric Sunshine
make_cover_letter() returns early when it lacks sufficient state to emit a diffstat, which makes it difficult to extend the function to reliably emit additional generated content. Work around this shortcoming by factoring diffstat-printing logic out to its own function and calling it as needed

[PATCH 12/14] format-patch: teach --range-diff to respect -v/--reroll-count

2018-07-22 Thread Eric Sunshine
The --range-diff option announces the embedded range-diff generically as "Range-diff:", however, we can do better when --reroll-count is specified by emitting "Range-diff against v{n}:" instead. Signed-off-by: Eric Sunshine --- builtin/log.c | 7 ++- revision.h| 1 + 2 files changed, 7

[PATCH 07/14] range-diff: respect diff_option.file rather than assuming 'stdout'

2018-07-22 Thread Eric Sunshine
The actual diffs output by range-diff respect diff_option.file, which range-diff passes down the call-chain, thus are destination-agnostic. However, output_pair_header() is hard-coded to emit to 'stdout'. Fix this by making output_pair_header() respect diff_option.file, as well. Signed-off-by:

[PATCH 02/14] format-patch: add --interdiff option to embed diff in cover letter

2018-07-22 Thread Eric Sunshine
When submitting a revised version of a patch series, it can be helpful (to reviewers) to include a summary of changes since the previous attempt in the form of an interdiff, however, doing so involves manually copy/pasting the diff into the cover letter. Add an --interdiff option to automate this

[PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-22 Thread Eric Sunshine
When submitting a revised version of a patch series, it can be helpful (to reviewers) to include a summary of changes since the previous attempt in the form of a range-diff, however, doing so involves manually copy/pasting the diff into the cover letter. Add a --range-diff option to automate this

[PATCH 11/14] format-patch: extend --range-diff to accept revision range

2018-07-22 Thread Eric Sunshine
When submitting a revised a patch series, the --range-diff option embeds a range-diff in the cover letter showing changes since the previous version of the patch series. The argument to --range-diff is a simple revision naming the tip of the previous series, which works fine if the previous and

Re: [PATCH v6 3/8] block alloc: add lifecycle APIs for cache_entry structs

2018-07-22 Thread Duy Nguyen
On Mon, Jul 2, 2018 at 9:49 PM Jameson Miller wrote: > +struct cache_entry *make_transient_cache_entry(unsigned int mode, const > struct object_id *oid, > + const char *path, int stage) > +{ > + struct cache_entry *ce; > + int len; > + > +

Re: [PATCH v6 8/8] fetch-pack: implement ref-in-want

2018-07-22 Thread Duy Nguyen
On Thu, Jun 28, 2018 at 12:33 AM Brandon Williams wrote: > +static void receive_wanted_refs(struct packet_reader *reader, struct ref > *refs) > +{ > + process_section_header(reader, "wanted-refs", 0); > + while (packet_reader_read(reader) == PACKET_READ_NORMAL) { > +

Re: [PATCH v4 1/4] rebase: start implementing it as a builtin

2018-07-22 Thread Duy Nguyen
On Sun, Jul 8, 2018 at 8:03 PM Pratik Karki wrote: > +int cmd_rebase(int argc, const char **argv, const char *prefix) > +{ > + /* > +* NEEDSWORK: Once the builtin rebase has been tested enough > +* and git-legacy-rebase.sh is retired to contrib/, this preamble > +*

Re: [PATCH v4] fetch-pack: support negotiation tip whitelist

2018-07-22 Thread Duy Nguyen
On Tue, Jul 3, 2018 at 12:41 AM Jonathan Tan wrote: > +static void add_negotiation_tips(struct git_transport_options *smart_options) > +{ > + struct oid_array *oids = xcalloc(1, sizeof(*oids)); > + int i; > + > + for (i = 0; i < negotiation_tip.nr; i++) { > + const

Re: [PATCH v3 6/9] Use remote_odb_get_direct() and has_remote_odb()

2018-07-22 Thread Duy Nguyen
On Fri, Jul 13, 2018 at 7:50 PM Christian Couder wrote: > @@ -477,8 +478,8 @@ static int batch_objects(struct batch_options *opt) > > for_each_loose_object(batch_loose_object, , 0); > for_each_packed_object(batch_packed_object, , 0); > - if

Re: Receiving console output from GIT 10mins after abort/termination?

2018-07-22 Thread Philip Oakley
From: "Frank Wolf" Sent: Wednesday, July 18, 2018 7:38 AM Hi @ll, I hope I'm posting to the right group (not sure if it's Windows related) but I've got a weird problem using GIT: By accident I've tried to push a repository (containing an already commited but not yet pushed submodule

Re: [RFC PATCH 3/5] pack-objects: add delta-islands support

2018-07-22 Thread Duy Nguyen
On Sun, Jul 22, 2018 at 7:52 AM Christian Couder wrote: > @@ -700,51 +705,58 @@ static struct object_entry **compute_write_order(void) > */ > for_each_tag_ref(mark_tagged, NULL); > > - /* > -* Give the objects in the original recency order until > -* we see

Re: [RFC PATCH 2/5] Add delta-islands.{c,h}

2018-07-22 Thread Duy Nguyen
On Sun, Jul 22, 2018 at 7:51 AM Christian Couder wrote: > diff --git a/Documentation/config.txt b/Documentation/config.txt > index a32172a43c..f682e92a1a 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -2542,6 +2542,10 @@ Note that changing the compression level will

[PATCH v2] pack-objects: fix performance issues on packing large deltas

2018-07-22 Thread Nguyễn Thái Ngọc Duy
Let's start with some background about oe_delta_size() and oe_set_delta_size(). If you already know, skip the next paragraph. These two are added in 0aca34e826 (pack-objects: shrink delta_size field in struct object_entry - 2018-04-14) to help reduce 'struct object_entry' size. The delta size

Re: [PATCH] pack-objects: fix performance issues on packing large deltas

2018-07-22 Thread Duy Nguyen
On Sun, Jul 22, 2018 at 8:22 AM Elijah Newren wrote: > > On Fri, Jul 20, 2018 at 9:47 PM, Duy Nguyen wrote: > > On Fri, Jul 20, 2018 at 10:43:25AM -0700, Elijah Newren wrote: > >> Out of curiosity, would it be possible to use the delta_size_ field > >> for deltas that are small enough, and only

Re: [PATCH] pack-objects: fix performance issues on packing large deltas

2018-07-22 Thread Elijah Newren
On Fri, Jul 20, 2018 at 9:47 PM, Duy Nguyen wrote: > On Fri, Jul 20, 2018 at 10:43:25AM -0700, Elijah Newren wrote: >> Out of curiosity, would it be possible to use the delta_size_ field >> for deltas that are small enough, and only use an external data >> structure (perhaps a hash rather than an