On Thu, Apr 2, 2015 at 12:15 PM, Shawn Landden sh...@churchofgit.com wrote:
[RFC 2] systemd socket activation support
Rephrase this as:
[PATCH/RFC v2] daemon: add systemd support
systemd support git-daemon's --inetd mode as well.
Unable to make sense of this sentence (fragment). A better
On Wed, Apr 8, 2015 at 3:14 PM, Shawn Landden sh...@churchofgit.com wrote:
[v7 PATCH] daemon: add systemd support
git-daemon's --systemd mode allows git-daemon to be connect-activated
on one or more addresses or ports. Unlike --inetd[1], git-daemon is
not spawned for every connection.
On Wed, Apr 8, 2015 at 1:42 PM, karthik nayak karthik@gmail.com wrote:
On 04/08/2015 02:19 AM, Eric Sunshine wrote:
On Sat, Apr 4, 2015 at 1:44 AM, Karthik Nayak karthik@gmail.com
wrote:
Signed-off-by: Karthik Nayak karthik@gmail.com
---
diff --git a/t/t1006-cat-file.sh b/t
On Wed, May 20, 2015 at 3:27 PM, Sébastien Guimmara
sebastien.guimm...@gmail.com wrote:
On 05/20/2015 09:22 PM, Sébastien Guimmara wrote:
From: Eric Sunshine sunsh...@sunshineco.com
It looks like 'git send-email' got confused with the CC field.
I'm sorry for that.
Confused in what way
On Wed, May 20, 2015 at 3:22 PM, Sébastien Guimmara
sebastien.guimm...@gmail.com wrote:
The ultimate goal is for git help to display common commands in
groups rather than alphabetically. As a first step, define the
groups in a new block, and then assign a group to each
common command.
Add a
On Wed, May 20, 2015 at 9:18 AM, Karthik Nayak karthik@gmail.com wrote:
add a ref-filter API to provide functions to filter refs for listing.
This will act as a common library for commands like 'tag -l',
'branch -l' and 'for-each-ref'. ref-filter will enable each of these
commands to
On Wed, May 20, 2015 at 3:22 PM, Sébastien Guimmara
sebastien.guimm...@gmail.com wrote:
The major modification of this reroll [1] is the use of the perl version
of generate-cmdlist instead of the awk one.
help.c:
1. change the introductory message from:
The typical Git workflow
On Wednesday, June 3, 2015, Galan Rémi
remi.galan-alfo...@ensimag.grenoble-inp.fr wrote:
Check if commits were removed (i.e. a line was deleted) and print
warnings or abort git rebase depending on the value of the
configuration variable rebase.missingCommits.
A few comments below in addition
On Thu, Jun 4, 2015 at 5:11 PM, Stefan Beller sbel...@google.com wrote:
On Thu, Jun 4, 2015 at 1:17 PM, Remi LESPINET
remi.lespi...@ensimag.grenoble-inp.fr wrote:
Working on git-send-email, I've seen that there's no aliases support
when manually adding a recipient in a 'To' or 'Cc' field in a
. When called like
this:
int n;
char *s = reencode_string_len(..., n);
if (s)
do_something(s, n);
some compilers complain that 'n' is used uninitialized within the
conditional.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
utf8.h | 4 +++-
1 file changed, 3
On Fri, Jun 5, 2015 at 5:32 AM, Ed Avis e...@waniasset.com wrote:
Torsten Bögershausen tboegi at web.de writes:
Do you think you can write a patch to improve the documentation ?
Here is my attempt, but it is only a starting point.
diff --git a/Documentation/git-checkout.txt
On Fri, Jun 5, 2015 at 1:44 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Fri, Jun 5, 2015 at 5:32 AM, Ed Avis e...@waniasset.com wrote:
Torsten Bögershausen tboegi at web.de writes:
Do you think you can write a patch to improve the documentation ?
Here is my attempt, but it is only
On Fri, Jun 5, 2015 at 3:35 PM, Junio C Hamano gits...@pobox.com wrote:
Mike Rappazzo rappa...@gmail.com writes:
I find that If I am doing a rebase with the intention to squash or
re-order commits, it is helpful to know the commit author.
There is not a fundamental reason why the remainder of
On Fri, Jun 5, 2015 at 12:34 PM, Louis Stuber
stub...@ensimag.grenoble-inp.fr wrote:
git-bisect.sh : create a file if the bisection is in old/new mode,
named BISECT_OLDNEWMODE, so it can easily be seen outside the
program without having to read BISECT_TERMS. This will have to be
changed in
On Fri, Jun 5, 2015 at 12:34 PM, Louis Stuber
stub...@ensimag.grenoble-inp.fr wrote:
Fix git rev-list --bisect and git bisect visualize when the bisection
is done in old/new mode.
See my review of patch 1/2 regarding writing a good commit message. In
particular, explain what is broken about git
On Wed, Jun 3, 2015 at 2:39 AM, Jeff King p...@peff.net wrote:
From: Eric Sunshine sunsh...@sunshineco.com
On PowerPC Mac OS X (10.5.8 Leopard with Xcode 3.1),
system header /usr/include/ppc/param.h[1] pollutes the
preprocessor namespace with a macro generically named MASK.
This conflicts
p...@peff.net
Yeah, splitting the patches this way makes sense and feels a bit cleaner.
It's such a simple patch that it doesn't need a reviewed-by, but for
what it's worth...
Reviewed-by: Eric Sunshine sunsh...@sunshineco.com
--
To unsubscribe from this list: send the line unsubscribe git
: s/\[1\]//
pollutes the preprocessor namespace with a macro generically
named MASK. We can give these macros more specific names, as
well, to avoid this conflict.
Reported-and-analyzed-by: Eric Sunshine sunsh...@sunshineco.com
Signed-off-by: Jeff King p...@peff.net
---
I'm also happy
On Fri, May 8, 2015 at 9:09 PM, Jeff King p...@peff.net wrote:
On Fri, May 08, 2015 at 07:56:28PM -0400, Eric Sunshine wrote:
I spent some time downloading old Xcode releases and poking through
the packages. Xcode 3.2.x seems to be the last in the Xcode 3 series,
and none of the Xcode 3.2.x
available for download, or not available to non-paying developers,
so testing is not possible.
[2]: http://en.wikipedia.org/wiki/Xcode
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
Tested on OS X 10.10.3 Yosemite with Xcode 6.3.2 and OS X 10.5.8
Leopard with Xcode 3.1.
The use
As an optimization, strbuf will take advantage of getdelim() if
available, so add a configure check which defines HAVE_GETDELIM if
found.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
Tested on:
* OS X 10.10.3 Yosemite with Xcode 6.3.2
* OS X 10.5.8 Leopard with Xcode 3.1
* Linux
a configure script check.
Eric Sunshine (2):
config.mak.uname: Darwin: define HAVE_GETDELIM for modern OS X
releases
configure: add getdelim() check
config.mak.uname | 3 +++
configure.ac | 6 ++
2 files changed, 9 insertions(+)
--
2.4.2.598.gb4379f4
--
To unsubscribe from
On Tue, Jun 2, 2015 at 3:04 PM, Jeff King p...@peff.net wrote:
On Tue, Jun 02, 2015 at 02:44:13PM -0400, Jeff King wrote:
+ ifeq ($(shell expr $(shell expr $(uname_R) : '\([0-9][0-9]*\)\.')
'=' 11),1)
Do you need to spawn two shells? It seems like:
$(shell expr `expr $(uname_R) :
On Tue, Jun 2, 2015 at 4:01 PM, Jeff King p...@peff.net wrote:
On Tue, Jun 02, 2015 at 03:57:44PM -0400, Eric Sunshine wrote:
Oops, I missed the trailing '.' in the regex there, and it probably
needs double-quotes in case the inner expr fails to match anything.
Which is messy considering
On Mon, Jun 1, 2015 at 8:02 PM, Stefan Beller sbel...@google.com wrote:
Signed-off-by: Stefan Beller sbel...@google.com
---
diff --git a/t/t5544-fetch-2.sh b/t/t5544-fetch-2.sh
new file mode 100755
index 000..beee46c
--- /dev/null
+++ b/t/t5544-fetch-2.sh
@@ -0,0 +1,40 @@
+#!/bin/sh
As an optimization, strbuf will take advantage of getdelim() if
available, so add a configure check which defines HAVE_GETDELIM if
found.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
configure.ac | 6 ++
1 file changed, 6 insertions(+)
diff --git a/configure.ac b/configure.ac
available for download, or not available to non-paying developers,
so testing is not possible.
[2]: http://en.wikipedia.org/wiki/Xcode
Helped-by: Jeff King p...@peff.net
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
config.mak.uname | 3 +++
1 file changed, 3 insertions(+)
diff
-- unchanged
[1]: http://thread.gmane.org/gmane.comp.version-control.git/270576
Eric Sunshine (2):
config.mak.uname: Darwin: define HAVE_GETDELIM for modern OS X
releases
configure: add getdelim() check
config.mak.uname | 3 +++
configure.ac | 6 ++
2 files changed, 9 insertions
/sysctl.h -
sys/ucred.h -
sys/param.h -
machine/param.h -
ppc/param.h
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
The alternative is to rename MASK in ewah/bitmap.c to something less
generic, resulting in a slightly more noisy patch. I chose the #undef
approach since it's
On Tue, Jun 23, 2015 at 8:54 AM, Matthieu Moy matthieu@imag.fr wrote:
diff --git a/revision.c b/revision.c
index 3ff8723..f22923f 100644
--- a/revision.c
+++ b/revision.c
@@ -2076,14 +2079,32 @@ void parse_revision_opt(struct rev_info *revs, struct
parse_opt_ctx_t *ctx,
On Mon, Jun 22, 2015 at 5:42 PM, Galan Rémi
remi.galan-alfo...@ensimag.grenoble-inp.fr wrote:
Instead of removing a line to remove the commit, you can use the
command drop (just like pick or edit). It has the same effect as
deleting the line (removing the commit) except that you keep a visual
On Tue, Jun 23, 2015 at 3:01 PM, Remi Galan Alfonso
remi.galan-alfo...@ensimag.grenoble-inp.fr wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
+test_rebase_end () {
+ test_when_finished git checkout master
+ git branch -D $1
+ test_might_fail git rebase --abort
On Sun, Jun 21, 2015 at 4:48 PM, Karthik Nayak karthik@gmail.com wrote:
In 'tag -l' we have '--points-at' option which lets users
list only tags which point to a particular commit. Implement
this option in 'ref-filter.{c,h}' so that other commands can
benefit from this.
This is
On Sun, Jun 21, 2015 at 4:48 PM, Karthik Nayak karthik@gmail.com wrote:
Add the '--merged' and '--no-merged' options provided by 'ref-filter'.
The '--merged' option lets the user to only list refs merged into the
named commit. The '--no-merged' option lets the user to only list refs
not
On Sun, Jun 21, 2015 at 4:48 PM, Karthik Nayak karthik@gmail.com wrote:
Add the '--points-at' option provided by 'ref-filter'. The
option lets the user to pick only refs which point to a particular
commit.
Add documentation and tests for the same.
Based-on-patch-by: Jeff King
On Mon, Jun 22, 2015 at 9:53 AM, Charles Bailey char...@hashpling.org wrote:
contrib/subtree: Use tabs consitently for indentation in tests
s/consitently/consistently/
Although subtrees tests uses more spaces for indentation than tabs,
there are still quite a lot of lines indented with tabs.
On Sat, Jun 20, 2015 at 5:47 AM, Heiko Voigt hvo...@hvoigt.net wrote:
I am currently experiencing sporadic test failures on Mac OS X 10.10.3:
Test Summary Report
---
t7503-pre-commit-hook.sh (Wstat: 256 Tests: 11
Failed: 1)
Failed test: 9
On Mon, Jun 22, 2015 at 6:45 AM, Jeff King p...@peff.net wrote:
[...] This patch adds an option to
cat-file --batch-check to operate on all available
objects (rather than reading names from stdin).
Signed-off-by: Jeff King p...@peff.net
---
diff --git a/t/t1006-cat-file.sh
On Tue, Jun 9, 2015 at 2:24 PM, Erik Elfström erik.elfst...@gmail.com wrote:
read_gitfile_gently will allocate a buffer to fit the entire file that
should be read. Add a sanity check of the file size before opening to
avoid allocating a potentially huge amount of memory if we come across
a
On Tue, Jun 16, 2015 at 11:32 PM, Jeff King p...@peff.net wrote:
On Tue, Jun 16, 2015 at 06:21:56PM -0500, Tad Hardesty wrote:
~/test (master #)$ git status -z | hexdump -C
41 20 20 61 41 20 20 62 |A aA b|
0008
That's really weird. I don't have a
On Fri, Jun 12, 2015 at 4:53 AM, Panagiotis Astithas past...@gmail.com wrote:
On Fri, Jun 12, 2015 at 6:46 AM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Thu, Jun 11, 2015 at 10:37 AM, Panagiotis Astithas past...@gmail.com
wrote:
The output of pmset -g batt changed at some point from
On Thu, Jun 11, 2015 at 10:37 AM, Panagiotis Astithas past...@gmail.com wrote:
The output of pmset -g batt changed at some point from
Currently drawing from 'AC Power' to the slightly different
Now drawing from 'AC Power'. Starting the match from drawing
makes the check work in both old and
On Sun, Jun 14, 2015 at 1:21 PM, erik elfström erik.elfst...@gmail.com wrote:
On Sun, Jun 14, 2015 at 5:42 AM, Eric Sunshine sunsh...@sunshineco.com
wrote:
This variable name doesn't convey much about its purpose, and
introduces a bit of maintenance burden if the limit is some day
changed
On Wed, May 27, 2015 at 9:33 AM, Paul Tan pyoka...@gmail.com wrote:
git-am.sh supports mbox, stgit and mercurial patches. Re-implement
support for splitting out mbox/maildirs using git-mailsplit, while also
implementing the framework required to support other patch formats in
the future.
On Tue, May 26, 2015 at 5:32 PM, Remi Lespinet
remi.lespi...@ensimag.grenoble-inp.fr wrote:
Add new functions to keep the setup cleaner:
- setup_temporary_branch: creates a new branch, check it out
and automatically delete it after the test is over
- setup_fixed_branch: creates a fixed
On Thu, May 28, 2015 at 3:09 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Tue, May 26, 2015 at 5:32 PM, Remi Lespinet
remi.lespi...@ensimag.grenoble-inp.fr wrote:
+setup_temporary_branch () {
+ tmp_name=${2-temporary}
I forgot to mention the broken -chain here. Although
On Thu, May 28, 2015 at 11:26 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Thu, May 28, 2015 at 6:42 AM, Remi Lespinet
remi.lespi...@ensimag.grenoble-inp.fr wrote:
+ The format supported for email list is the following:
+ Foo f...@example.com, b...@example.com
On Thu, May 28, 2015 at 2:22 PM, Junio C Hamano gits...@pobox.com wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
Moreover, it lacks justification and explanation of why you consider
the cleanup unnecessary. History [1] indicates that its application to
-F but not -t was intentional
On Thu, May 28, 2015 at 9:10 AM, Paul Tan pyoka...@gmail.com wrote:
Take these comments/suggestions with a pinch of salt because I'm not
that experienced with the code base as well ;-).
I agree with pretty much all of your review comments. See below for a
minor addenda.
On Wed, May 27, 2015
On Wed, May 27, 2015 at 9:33 AM, Paul Tan pyoka...@gmail.com wrote:
Since 15ced75 (git-am foreign patch support: autodetect some patch
formats, 2009-05-27), git-am.sh is able to autodetect mbox, stgit and
mercurial patches through heuristics.
Re-implement support for autodetecting
Sendmail aliases[1] supports expansion to a file (/path/name) or
pipe (|command), as well as file inclusion (:include: /path/name),
however, our implementation does not support such functionality.
[1]: https://www.freebsd.org/cgi/man.cgi?query=aliasessektion=5
Signed-off-by: Eric Sunshine sunsh
Although emitted to stderr, warnings from the sendmail aliases parser
are not visually distinguished as such, and thus can easily be
overlooked in the normal noisy send-email output.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
This prepends lowercase warning: rather than uppercase
Logical lines in sendmail aliases files can be spread over multiple
physical lines[1]. A line beginning with whitespace is folded into the
preceding line. A line ending with '\' consumes the following line.
[1]: https://www.freebsd.org/cgi/man.cgi?query=aliasessektion=5
Signed-off-by: Eric
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
git-send-email.perl | 5 -
1 file changed, 5 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 819f87e..0b18682 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -517,26 +517,21 @@ my %parse_alias
This series adds line continuation support for sendmail aliases.
It extends basic sendmail aliases functionality implemented by
ah/send-email-sendmail-alias (currently d1205b07 in 'pu')
Eric Sunshine (9):
send-email: further document missing sendmail aliases functionality
send-email: visually
Replace unnecessarily complex regular expression for recognizing comment
and blanks lines in sendmail aliases with idiomatic expressions which
can be easily understood at a glance.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
git-send-email.perl | 2 +-
1 file changed, 1 insertion
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
git-send-email.perl | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 0b18682..1380e6e 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
The sendmail aliases parser inlined into %parse_alias is already
uncomfortably large and is expected to grow as additional functionality
is implemented, so extract it to improve manageability.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
git-send-email.perl | 38
A line beginning with whitespace is folded into the preceding line.
A line ending with '\' consumes the following line.
While here, also test an empty sendmail aliases file.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
t/t9001-send-email.sh | 34 ++
1
Several new tests of sendmail aliases parsing will be added in a
subsequent patch, so factor out functionality common to all of them
into a new helper function.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
t/t9001-send-email.sh | 47 +--
1
On Sun, May 31, 2015 at 6:29 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
Replace unnecessarily complex regular expression for recognizing comment
and blanks lines in sendmail aliases with idiomatic expressions which
s/blanks/blank/
can be easily understood at a glance.
Signed-off
On Mon, Jun 01, 2015 at 07:43:08AM -0400, Allen Hubbe wrote:
On May 31, 2015 at 6:29 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
Sendmail aliases[1] supports expansion to a file (/path/name) or
pipe (|command), as well as file inclusion (:include: /path/name),
however, our
On Mon, Jun 1, 2015 at 2:58 PM, Junio C Hamano gits...@pobox.com wrote:
Subject: apply: reject a hunk that does not do anything
A hunk like this in a hand-edited patch without correctly adjusting
the line counts:
@@ -660,2 +660,2 @@ inline struct sk_buff *ieee80211_authentic...
On Mon, Jun 1, 2015 at 7:52 AM, Galan Rémi
remi.galan-alfo...@ensimag.grenoble-inp.fr wrote:
Check if commits were removed (i.e. a line was deleted) and print
warnings or abort git rebase according to the value of the
configuration variable rebase.checkLevel.
Add the configuration variable
On Mon, Jun 1, 2015 at 7:16 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Mon, Jun 1, 2015 at 7:52 AM, Galan Rémi
remi.galan-alfo...@ensimag.grenoble-inp.fr wrote:
test_expect_success 'drop' '
- git checkout master
test_when_finished git checkout master
git
On Wed, May 27, 2015 at 2:35 AM, Jeff King p...@peff.net wrote:
On Tue, May 26, 2015 at 03:01:08PM -0700, Stefan Beller wrote:
+static void send_capabilities(void)
+{
+ char buf[100];
+
+ while (next_capability(buf))
+ packet_write(1, capability:%s\n, buf);
Like Eric,
On Wed, May 27, 2015 at 2:50 AM, Jeff King p...@peff.net wrote:
On Tue, May 26, 2015 at 11:25:05PM -0400, Eric Sunshine wrote:
+ len = packet_read(in, src_buf, src_len,
+ packet_buffer, sizeof(packet_buffer
On Wed, May 27, 2015 at 9:19 AM, Remi Galan Alfonso
remi.galan-alfo...@ensimag.grenoble-inp.fr wrote:
Eric Sunshinesunsh...@sunshineco.com writes:
+ # To uppercase
+ checkLevel=$(echo $checkLevel | tr '[:lower:]' '[:upper:]')
Is there precedence elsewhere for recognizing
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller sbel...@google.com wrote:
In upload-pack-2 we send each capability in its own packet.
By reusing the advertise_capabilities and eventually setting it to
NULL we will be able to reuse the methods for refs advertisement.
Signed-off-by: Stefan
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller sbel...@google.com wrote:
Instead of calling get_remote_heads as a first command during the
protocol exchange, we need to have fine grained control over the
capability negotiation in version 2 of the protocol.
Introduce get_remote_capabilities,
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller sbel...@google.com wrote:
Signed-off-by: Stefan Beller sbel...@google.com
---
diff --git a/transport.c b/transport.c
index 3ef15f6..33644a6 100644
--- a/transport.c
+++ b/transport.c
@@ -496,15 +496,29 @@ static int set_git_option(struct
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller sbel...@google.com wrote:
transport: get_refs_via_connect exchanges capabilities before refs.
s/exchanges/exchange/
s/\.$//
Signed-off-by: Stefan Beller sbel...@google.com
---
transport.c | 29 +
1 file changed, 25
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller sbel...@google.com wrote:
Signed-off-by: Stefan Beller sbel...@google.com
---
diff --git a/t/t5544-fetch-2.sh b/t/t5544-fetch-2.sh
new file mode 100755
index 000..beee46c
--- /dev/null
+++ b/t/t5544-fetch-2.sh
@@ -0,0 +1,40 @@
+#!/bin/sh
On Fri, May 29, 2015 at 4:17 PM, Junio C Hamano gits...@pobox.com wrote:
By default, we should run clean-up after the editor we spawned gives
us the edited result. Not adding one more LF after the template
when it already ends with LF would not hurt, but an extra blank
after the template
On Sat, May 30, 2015 at 7:29 AM, Patryk Obara patryk.ob...@gmail.com wrote:
On Thu, May 28, 2015 at 4:29 PM, Eric Sunshine sunsh...@sunshineco.com
wrote:
Did you consider the alternate approach of handling newline processing
immediately upon loading 'logfile' and 'template_file', rather than
On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote:
Create 'ref-filter.h', also add ref-filter to the Makefile.
This completes movement of creation of 'ref-filter' from
'for-each-ref'.
It's important that the project can be built successfully and function
correctly at
On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote:
Intoduce 'ref_filter_cbdata' which will hold 'ref_filter'
s/Intoduce/Introduce/
(Conditions to filter the refs on) and 'ref_array' (The array
s/Conditions/conditions/
s/The/the/
of ref_array_items). Modify the code
On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote:
Extract two helper functions out of grab_single_ref(). Firstly,
new_refinfo() which is used to allocate memory for a new refinfo
structure and copy the objectname, refname and flag to it.
Secondly, match_name_as_path()
On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote:
Rename some of the functions and make them publically available.
s/publically/publicly/
This is a preparatory step for moving code from 'for-each-ref'
to 'ref-filter' to make meaningful, targeted services available to
On Sun, May 31, 2015 at 4:19 AM, Karthik Nayak karthik@gmail.com wrote:
On 05/31/2015 09:13 AM, Eric Sunshine wrote:
On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com
wrote:
Create 'ref-filter.h', also add ref-filter to the Makefile.
This completes movement of creation
On Tue, May 26, 2015 at 2:15 AM, Patryk Obara patryk.ob...@gmail.com wrote:
Currently messages are compared with --pretty=format:%s%b which does
not retain raw format of commit message. In result it's not clear what
part of expected commit msg is subject and what part is body. Also, it's
On Tue, May 26, 2015 at 2:15 AM, Patryk Obara patryk.ob...@gmail.com wrote:
git-commit with -t or -F -e uses content of user-supplied file as
initial value for commit msg in editor. There is no guarantee, that this
file ends with newline - it depends on file content and editor used to
create
On Thu, May 28, 2015 at 6:42 AM, Remi Lespinet
remi.lespi...@ensimag.grenoble-inp.fr wrote:
Add the possibility to use a list of emails separated by commas
in flags --cc --to and --bcc instead of having to use one flag
s/--cc --to/--cc, --to/
Ditto in subject.
per email address.
The
On Tue, Jun 2, 2015 at 9:52 AM, Remi LESPINET
remi.lespi...@ensimag.grenoble-inp.fr wrote:
Matthieu Moy matthieu@grenoble-inp.fr writes:
Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes:
+if test $(git config --bool --get am.threeWay) = true
+then
+threeway=t
+fi
I
On Tue, Jun 2, 2015 at 3:42 AM, Remi Galan Alfonso
remi.galan-alfo...@ensimag.grenoble-inp.fr wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
+test_expect_success 'rebase -i respects rebase.checkLevel' '
+ test_config rebase.checkLevel error
+ test_when_finished git
On Tue, Jun 2, 2015 at 5:42 AM, Duy Nguyen pclo...@gmail.com wrote:
On Tue, Jun 2, 2015 at 7:02 AM, Stefan Beller sbel...@google.com wrote:
diff --git a/string-list.h b/string-list.h
index d3809a1..88c18e9 100644
--- a/string-list.h
+++ b/string-list.h
@@ -19,6 +19,7 @@ struct string_list {
On Wed, Jul 1, 2015 at 12:36 PM, Junio C Hamano gits...@pobox.com wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
I was about to mention the same shortcoming, but you beat me to it.
Perhaps be more strict and do this instead (without
leading strbuf_trim):
if (!get_sha1_hex
On Wed, Jul 1, 2015 at 1:13 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Wed, Jul 1, 2015 at 12:53 PM, Junio C Hamano gits...@pobox.com wrote:
* Duy seems to think worktree add is coming, too, so here is a
trivial tweak of your patch from the last month, with test
adjustments
On Mon, Jun 29, 2015 at 4:17 PM, David Turner dtur...@twopensource.com wrote:
These are necessary because alternate ref backends might store reflogs
somewhere other than .git/logs. Code that now directly manipulates
.git/logs should instead go through git-reflog.
In a moment, we will use
On Wed, Jul 1, 2015 at 12:18 PM, Junio C Hamano gits...@pobox.com wrote:
Matthieu Moy matthieu@imag.fr writes:
+/*
+ * Turn
+ * pick d6a2f0303e897ec257dd0e0a39a5ccb709bc2047 some message
+ * into
+ * pick d6a2f03 some message
+ */
+static void abbrev_sha1_in_line(struct strbuf *line)
On Fri, Jul 3, 2015 at 8:17 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
+EXAMPLES
+
+You are middle of a refactoring session and your boss comes in and demands
s/middle/in the /
+that you fix something immediately. You
On Fri, Jul 3, 2015 at 8:17 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
In order to allow linked worktree creation via git checkout -b from a
s/-b/--to/
bare repository, 3473ad0 (checkout: don't require a work tree when
checking out into a new one, 2014-11-30) dropped git-checkout's
functionality
(checkout.c:prepare_linked_checkout() and its helpers) to worktree.c.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
Documentation/git-worktree.txt | 21 +++--
builtin/worktree.c | 32
2 files changed, 43 insertions
The only references to 'new' were folded out by the last two patches.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
builtin/checkout.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index 0cb81ee..0dcdde2 100644
to mind. Therefore, overload it to also suppress the
check for a branch already checked out elsewhere.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
I plopped this patch at the end of the series so that it can be dropped
easily if desired since Junio indicated[1] that he would moderately
A subsequent patch will also need to compute the basename of the new
worktree, so factor out this logic into a new function.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
builtin/worktree.c | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
diff
GIT_CHECKOUT_NEW_WORKTREE environment variable).
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
builtin/checkout.c | 156 +
builtin/worktree.c | 138 ---
2 files changed, 133 insertions(+), 161
One of git-worktree's roles is to populate the new worktree, much like
git-checkout, and thus, for convenience, ought to support several of the
same shortcuts. Toward this goal, add a --detach option to detach HEAD
in the new worktree.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
../hotfix.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
Documentation/git-worktree.txt | 8 ++--
builtin/worktree.c | 8 ++--
t/t2025-worktree-add.sh| 7 +++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-worktree.txt b
By default, git worktree add refuses to create a new worktree when
the requested branch is already checked out elsewhere. Add a --force
option to override this safeguard.
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
Documentation/git-worktree.txt | 8 +++-
builtin/worktree.c
1101 - 1200 of 3596 matches
Mail list logo
