Re: [PATCH v1 1/1] dir: teach status to show ignored directories

2017-08-11 Thread Jameson Miller
On 08/11/2017 01:39 PM, Brandon Williams wrote: On 08/10, Jameson Miller wrote: Teach Git to optionally show ignored directories when showing all untracked files. The git status command exposes the options to report ignored and/or untracked files. However, when reporting all untracked files

Re: [PATCH v1 1/1] dir: teach status to show ignored directories

2017-08-11 Thread Jameson Miller
On 08/10/2017 04:03 PM, Stefan Beller wrote: On Thu, Aug 10, 2017 at 11:49 AM, Jameson Miller <jameson.mille...@gmail.com> wrote: Welcome to the Git mailing list. :) Thank you for the welcome and the review! I will include the suggested code changes in the next patch version. Tea

[PATCH v1 1/1] dir: teach status to show ignored directories

2017-08-10 Thread Jameson Miller
. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Documentation/git-status.txt | 5 + Documentation/technical/api-directory-listing.txt | 6 + builtin/commit.c | 4 + dir.c

[PATCH v1 0/1] Teach status to show ignored directories

2017-08-10 Thread Jameson Miller
improvement in work directories with a large number of files contained in ignored directories. For example, this setup is present when bin and obj directories are contained in the repository work dir. Jameson Miller (1): dir: teach status to show ignored directories Documentation/git-status.txt

[PATCH v2] Improve performance of git status --ignored

2017-09-18 Thread Jameson Miller
ignored directories: | Command| Time (s) | | -- | - | | git status | 1.2 | | git status --ignored (old) | 3.9 | | git status --ignored (new) | 1.4 | Signed-off-by: Jameson Miller <jam...@microsoft.

[PATCH v2] Improve performance of git status --ignored

2017-09-18 Thread Jameson Miller
of a repository with ~190,000 files in ~400 ignored directories: | Command| Time (s) | | -- | | | git status |1.2 | | git status --ignored (old) |3.9 | | git status --ignored (new) |1.4 | Jameson Miller (1): Improve

[PATCH v2 0/5] Teach Status options around showing ignored files

2017-10-11 Thread Jameson Miller
Changes in v2: Addressed review comments from the original series: * Made fixes / simplifications suggested for documentation * Removed test_tick from test scripts * Merged 2 commits (as suggested) Jameson Miller (5): Teach status options around showing ignored files Update documentation

[PATCH v2 2/5] Update documentation for new directory and status logic

2017-10-11 Thread Jameson Miller
Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Documentation/git-status.txt | 21 +- Documentation/technical/api-directory-listing.txt | 27 +++ 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/Documentati

[PATCH v2 4/5] Expand support for ignored arguments on status

2017-10-11 Thread Jameson Miller
Teach status command to handle matching ignored mode when showing untracked files with the normal option. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- dir.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/dir.c b/dir.c index b9af

[PATCH v2 5/5] Add tests around status handling of ignored arguments

2017-10-11 Thread Jameson Miller
Add tests for status handling of '--ignored=matching` and `--untracked-files=normal`. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- t/t7519-ignored-mode.sh | 60 - 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/t

[PATCH v2 3/5] Add tests for git status `--ignored=matching`

2017-10-11 Thread Jameson Miller
Add tests for new ignored mode (matching) when showing all untracked files. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- t/t7519-ignored-mode.sh | 125 1 file changed, 125 insertions(+) create mode 100755 t/t7519-ignored-mode.sh

[PATCH v2 1/5] Teach status options around showing ignored files

2017-10-11 Thread Jameson Miller
re ignored, then we can ignore any files changes we notice underneath these paths, as we know they do not affect the output of stats. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- builtin/commit.c | 31 +-- dir.c| 24 di

Re: [PATCH v2 1/5] Teach status options around showing ignored files

2017-10-12 Thread Jameson Miller
On 10/11/2017 10:49 PM, Junio C Hamano wrote: Jameson Miller <jameson.mille...@gmail.com> writes: This change teaches the status command more options to control which ignored files are reported independently of the which untracked files are reported by allowing the `--ignored` option t

Re: [PATCH v2 5/5] Add tests around status handling of ignored arguments

2017-10-12 Thread Jameson Miller
On 10/12/2017 12:06 AM, Junio C Hamano wrote: Jameson Miller <jameson.mille...@gmail.com> writes: Add tests for status handling of '--ignored=matching` and `--untracked-files=normal`. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Hmph, having some tests in 3/5, ch

Re: [PATCH v2 0/5] Teach Status options around showing ignored files

2017-10-12 Thread Jameson Miller
On 10/11/2017 10:33 PM, Junio C Hamano wrote: Jameson Miller <jameson.mille...@gmail.com> writes: Changes in v2: Addressed review comments from the original series: * Made fixes / simplifications suggested for documentation * Removed test_tick from test scripts * Merged 2 c

Re: [PATCH v2 2/5] Update documentation for new directory and status logic

2017-10-12 Thread Jameson Miller
On 10/11/2017 10:55 PM, Junio C Hamano wrote: Jameson Miller <jameson.mille...@gmail.com> writes: Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Documentation/git-status.txt | 21 +- Documentation/technical/api-directory-list

Re: [PATCH 0/6] Teach Status options around showing ignored files

2017-10-05 Thread Jameson Miller
On 10/05/2017 05:16 PM, Jonathan Nieder wrote: Hi, jameson.mille...@gmail.com wrote: This patch series is the second part of [1], which was split into 2 parts. The first part, added an optimization in the directory listing logic to not scan the contents of ignored directories and was merged

[PATCH v3 2/7] block alloc: add lifecycle APIs for cache_entry structs

2018-05-23 Thread Jameson Miller
memory. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- apply.c| 26 ++--- blame.c| 5 +-- builtin/checkout.c | 8 ++-- builtin/difftool.c | 8 ++-- builtin/reset.c| 6 +-- builtin/update-index.c | 26 ++--- c

[PATCH v3 1/7] read-cache: teach refresh_cache_entry() to take istate

2018-05-23 Thread Jameson Miller
Refactor refresh_cache_entry() to work on a specific index, instead of implicitly using the_index. This is in preparation for making the make_cache_entry function work on a specific index. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- cache.h | 2 +- merge-recursive

[PATCH v3 0/7] allocate cache entries from memory pool

2018-05-23 Thread Jameson Miller
nto single function. This should make code easier to maintain - Small tweaks based on V1 feedback Base Ref: master Web-Diff: g...@github.com:jamill/git.git/commit/d608515f9e Checkout: git fetch g...@github.com:jamill/git.git users/jamill/block_allocation-v3 && git checkout d608515f9e

[PATCH v3 3/7] mem-pool: only search head block for available space

2018-05-23 Thread Jameson Miller
it will never be able to fulfill a future request. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- mem-pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mem-pool.c b/mem-pool.c index 389d7af447..c80124f1fe 100644 --- a/mem-pool.c +++ b/mem-pool.c @@ -21,16

[PATCH v3 6/7] block alloc: allocate cache entries from mem_pool

2018-05-23 Thread Jameson Miller
t be freed while they are still being referenced. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- cache.h| 21 ++ read-cache.c | 119 - split-index.c | 50 unpack-trees.c | 13 +--

[PATCH v3 4/7] mem-pool: add lifecycle management functions

2018-05-23 Thread Jameson Miller
ing memory pool. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- fast-import.c | 2 +- mem-pool.c| 63 +++ mem-pool.h| 12 +++- 3 files changed, 71 insertions(+), 6 deletions(-) diff --git a/fast-import.c b/fas

[PATCH v3 5/7] mem-pool: fill out functionality

2018-05-23 Thread Jameson Miller
Add functions for: - combining two memory pools - determining if a memory address is within the range managed by a memory pool These functions will be used by future commits. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- mem-pool.

[PATCH v3 7/7] block alloc: add validations around cache_entry lifecyle

2018-05-23 Thread Jameson Miller
mem_pool. 3) When discarding mem_pools, invalidate mem_pool memory. This should provide extra checks that mem_pools and their allocated cache_entries are being used as expected. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- cache.h | 6 ++ git.c| 3 +++ mem-

RE: [PATCH v3 0/7] allocate cache entries from memory pool

2018-05-24 Thread Jameson Miller
> -Original Message- > From: Junio C Hamano <jch2...@gmail.com> On Behalf Of Junio C Hamano > Sent: Thursday, May 24, 2018 12:55 AM > To: Jameson Miller <jam...@microsoft.com> > Cc: git@vger.kernel.org; pclo...@gmail.com; jonathanta...@google.com; > sbel...@

RE: [PATCH v3 2/7] block alloc: add lifecycle APIs for cache_entry structs

2018-05-24 Thread Jameson Miller
> -Original Message- > From: Junio C Hamano <jch2...@gmail.com> On Behalf Of Junio C Hamano > Sent: Thursday, May 24, 2018 12:52 AM > To: Jameson Miller <jam...@microsoft.com> > Cc: git@vger.kernel.org; pclo...@gmail.com; jonathanta...@google.com; > sbel...@

[PATCH v4 4/8] mem-pool: tweak math on mp_block allocation size

2018-06-20 Thread Jameson Miller
The amount of memory to allocate for mp_blocks was off by a sizeof(uintmax_t) on platforms that do not support flexible arrays. To account for this, use the offset of the space field when calculating the total amount of memory to allocate for a mp_block. Signed-off-by: Jameson Miller --- mem

[PATCH v4 6/8] mem-pool: fill out functionality

2018-06-20 Thread Jameson Miller
Add functions for: - combining two memory pools - determining if a memory address is within the range managed by a memory pool These functions will be used by future commits. Signed-off-by: Jameson Miller --- mem-pool.c | 42 ++ mem

[PATCH v4 7/8] block alloc: allocate cache entries from mem_pool

2018-06-20 Thread Jameson Miller
t be freed while they are still being referenced. Signed-off-by: Jameson Miller --- cache.h| 21 ++ mem-pool.c | 3 +- read-cache.c | 119 - split-index.c | 50 unpack-trees.c | 13 +-

[PATCH v4 2/8] block alloc: add lifecycle APIs for cache_entry structs

2018-06-20 Thread Jameson Miller
the corresponding memory. Signed-off-by: Jameson Miller --- apply.c| 24 ++--- blame.c| 5 ++- builtin/checkout.c | 8 ++--- builtin/difftool.c | 6 ++-- builtin/reset.c| 2 +- builtin/update-index.c | 26 ++ cache.h| 24

[PATCH v4 1/8] read-cache: teach refresh_cache_entry() to take istate

2018-06-20 Thread Jameson Miller
Refactor refresh_cache_entry() to work on a specific index, instead of implicitly using the_index. This is in preparation for making the make_cache_entry function apply to a specific index. Signed-off-by: Jameson Miller --- cache.h | 2 +- merge-recursive.c | 2 +- read-cache.c

[PATCH v4 0/8] Allocate cache entries from mem_pool

2018-06-20 Thread Jameson Miller
b.com/jamill/git/compare/242ba98e44...667b8de06c Jameson Miller (8): read-cache: teach refresh_cache_entry() to take istate block alloc: add lifecycle APIs for cache_entry structs mem-pool: only search head block for available space mem-pool: tweak math on mp_block allocation size mem-poo

[PATCH v4 3/8] mem-pool: only search head block for available space

2018-06-20 Thread Jameson Miller
it will never be able to fulfill a future request. Signed-off-by: Jameson Miller --- mem-pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mem-pool.c b/mem-pool.c index 389d7af447..c80124f1fe 100644 --- a/mem-pool.c +++ b/mem-pool.c @@ -21,16 +21,16 @@ static struct

[PATCH v4 5/8] mem-pool: add lifecycle management functions

2018-06-20 Thread Jameson Miller
that will utilize creating and discarding memory pool. Signed-off-by: Jameson Miller --- mem-pool.c | 63 ++ mem-pool.h | 10 ++ 2 files changed, 61 insertions(+), 12 deletions(-) diff --git a/mem-pool.c b/mem-pool.c index

[PATCH v4 8/8] block alloc: add validations around cache_entry lifecyle

2018-06-20 Thread Jameson Miller
mem_pool. 3) When discarding mem_pools, invalidate mem_pool memory. This should provide extra checks that mem_pools and their allocated cache_entries are being used as expected. Signed-off-by: Jameson Miller --- cache.h | 6 ++ git.c| 3 +++ mem-pool.c | 6 +- mem

RE: [PATCH v3 0/7] allocate cache entries from memory pool

2018-06-20 Thread Jameson Miller
> > > We debated several approaches for what to do here > > it would be awesome if the list could participate in the discussion even if > only > read-only. A bit of delay in my response here, but I like the suggestion. here is a summary of some approaches I considered: 1) Do not include any

[PATCH v6 3/8] block alloc: add lifecycle APIs for cache_entry structs

2018-07-02 Thread Jameson Miller
ache entry with empty fields. discard_cache_entry: A single function that knows how to discard a cache entry regardless of how it was allocated. Signed-off-by: Jameson Miller --- apply.c| 24 +-- blame.c| 5 +-- builtin/checkout.

[PATCH v6 6/8] mem-pool: fill out functionality

2018-07-02 Thread Jameson Miller
Add functions for: - combining two memory pools - determining if a memory address is within the range managed by a memory pool These functions will be used by future commits. Signed-off-by: Jameson Miller --- mem-pool.c | 42 ++ mem

[PATCH v6 7/8] block alloc: allocate cache entries from mem_pool

2018-07-02 Thread Jameson Miller
he entries We decided tracking and iterating over known memory pool regions was less desirable than adding an extra field to track this stae. Signed-off-by: Jameson Miller --- cache.h| 21 + mem-pool.c | 3 +- read-cache

[PATCH v6 5/8] mem-pool: add life cycle management functions

2018-07-02 Thread Jameson Miller
and discarding memory pool. Signed-off-by: Jameson Miller --- mem-pool.c | 59 ++ mem-pool.h | 10 + 2 files changed, 61 insertions(+), 8 deletions(-) diff --git a/mem-pool.c b/mem-pool.c index c80124f1fe..1769400d2d 100644 --- a/mem-pool.c

[PATCH v6 2/8] read-cache: teach make_cache_entry to take object_id

2018-07-02 Thread Jameson Miller
Teach make_cache_entry function to take object_id instead of a SHA-1. --- apply.c| 2 +- builtin/checkout.c | 2 +- builtin/difftool.c | 4 ++-- builtin/reset.c| 2 +- cache.h| 7 ++- merge-recursive.c | 2 +- read-cache.c | 8 +--- resolve-undo.c |

[PATCH v6 8/8] block alloc: add validations around cache_entry lifecyle

2018-07-02 Thread Jameson Miller
mem_pool. 3) When discarding mem_pools, invalidate mem_pool memory. This should provide extra checks that mem_pools and their allocated cache_entries are being used as expected. Signed-off-by: Jameson Miller --- cache.h | 6 ++ git.c| 3 +++ mem-pool.c | 6 +- mem

[PATCH v6 1/8] read-cache: teach refresh_cache_entry to take istate

2018-07-02 Thread Jameson Miller
Refactor refresh_cache_entry() to work on a specific index, instead of implicitly using the_index. This is in preparation for making the make_cache_entry function apply to a specific index. Signed-off-by: Jameson Miller --- cache.h | 2 +- merge-recursive.c | 2 +- read-cache.c

[PATCH v6 4/8] mem-pool: only search head block for available space

2018-07-02 Thread Jameson Miller
it will never be able to fulfill a future request. Signed-off-by: Jameson Miller --- mem-pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mem-pool.c b/mem-pool.c index 389d7af447..c80124f1fe 100644 --- a/mem-pool.c +++ b/mem-pool.c @@ -21,16 +21,16 @@ static struct

[PATCH v6 0/8] Allocate cache entries from mem_pool

2018-07-02 Thread Jameson Miller
(path); ce = make_empty_transient_cache_entry(len); - hashcpy(ce->oid.hash, oid->hash); + oidcpy(>oid, oid); memcpy(ce->name, path, len); ce->ce_flags = create_ce_flags(stage); ce->ce_namelen = len; ### Patches Jameson Miller (8): read-cache: teach refre

RE: [PATCH v5 6/8] mem-pool: fill out functionality

2018-07-02 Thread Jameson Miller
> > +void mem_pool_combine(struct mem_pool *dst, struct mem_pool *src) { > > + struct mp_block *p; > > + > > + /* Append the blocks from src to dst */ > > + if (dst->mp_block && src->mp_block) { > > + /* > > +* src and dst have blocks, append > > +* blocks

RE: [PATCH 00/13] object store: alloc

2018-05-02 Thread Jameson Miller
> -Original Message- > From: Duy Nguyen <pclo...@gmail.com> > Sent: Wednesday, May 2, 2018 1:02 PM > To: Stefan Beller <sbel...@google.com> > Cc: Git Mailing List <git@vger.kernel.org>; Jameson Miller > <jam...@microsoft.com> > Subject: Re:

RE: [PATCH 00/13] object store: alloc

2018-05-02 Thread Jameson Miller
> -Original Message- > From: Duy Nguyen <pclo...@gmail.com> > Sent: Wednesday, May 2, 2018 2:23 PM > To: Jameson Miller <jam...@microsoft.com> > Cc: Stefan Beller <sbel...@google.com>; Git Mailing List <git@vger.kernel.org> > Subject: Re: [PA

RE: [PATCH v2 3/5] mem-pool: fill out functionality

2018-05-01 Thread Jameson Miller
Thank you for taking a look - I think these are good questions. Please let me know if you have further questions. > -Original Message- > From: Stefan Beller <sbel...@google.com> > Sent: Monday, April 30, 2018 5:42 PM > To: Jameson Miller <jam...@microsoft.com> &

[PATCH v2 4/5] block alloc: allocate cache entries from mem_pool

2018-04-30 Thread Jameson Miller
e downside of this approach is that the cache_entry type would need to grow to incorporate this information. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- cache.h | 2 ++ read-cache.c | 95 +-- split-index.c | 23 +--

[PATCH v2 2/5] block alloc: add lifecycle APIs for cache_entry structs

2018-04-30 Thread Jameson Miller
memory. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- apply.c| 26 ++-- blame.c| 5 +-- builtin/checkout.c | 8 ++-- builtin/difftool.c | 8 ++-- builtin/reset.c| 6 +-- builtin/update-index.c | 26 ++-- c

[PATCH v2 3/5] mem-pool: fill out functionality

2018-04-30 Thread Jameson Miller
will be used in a future commit in this commit series. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- mem-pool.c | 114 ++--- mem-pool.h | 32 + 2 files changed, 142 insertions(+), 4 deletions(-) diff --git a/mem-po

[PATCH v2 5/5] block alloc: add validations around cache_entry lifecyle

2018-04-30 Thread Jameson Miller
mem_pool. 3) When discarding mem_pools, invalidate mem_pool memory. This should provide extra checks that mem_pools and their allocated cache_entries are being used as expected. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- cache.h | 7 +++ git.c| 3 ++

[PATCH v2 1/5] read-cache: teach refresh_cache_entry() to take istate

2018-04-30 Thread Jameson Miller
Refactor refresh_cache_entry() to work on a specific index, instead of implicitly using the_index. This is in preparation for making the make_cache_entry function work on a specific index. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- cache.h | 2 +- merge-recursive

[PATCH v2 0/5] Allocate cache entries from memory pool

2018-04-30 Thread Jameson Miller
ers/jamill/block_allocation-v2 && git checkout 2152d28016 Jameson Miller (5): read-cache: teach refresh_cache_entry() to take istate block alloc: add lifecycle APIs for cache_entry structs mem-pool: fill out functionality block alloc: allocate cache entries from mem_pool block

RE: [PATCH v2 0/5] Allocate cache entries from memory pool

2018-05-03 Thread Jameson Miller
> -Original Message- > From: git-ow...@vger.kernel.org <git-ow...@vger.kernel.org> On Behalf Of > Stefan Beller > Sent: Thursday, May 3, 2018 4:59 PM > To: Duy Nguyen <pclo...@gmail.com> > Cc: Jameson Miller <jam...@microsoft.com>; git@vger.kernel.

[PATCH v3 0/4] status: add option to show ignored files differently

2017-10-19 Thread Jameson Miller
The previous iteration can be found here: https://public-inbox.org/git/20171011133504.15049-1-jam...@microsoft.com/ The main difference is to address feedback around commit organization and wording. Jameson Miller (4): status: add option to show ignored files differently status: report

[PATCH v3 3/4] status: document options to show matching ignored files

2017-10-19 Thread Jameson Miller
Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Documentation/git-status.txt | 21 +- Documentation/technical/api-directory-listing.txt | 27 +++ 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/Documentati

[PATCH v3 1/4] status: add option to show ignored files differently

2017-10-19 Thread Jameson Miller
ed directory matches an exclude pattern, then the path of the directory is returned. If a directory does not match an exclude pattern, but all of its contents are ignored, then the contained files are reported instead of the directory. Signed-off-by: Jameson Miller <jam...@microsoft.com>

[PATCH v3 2/4] status: report matching ignored and normal untracked

2017-10-19 Thread Jameson Miller
Teach status command to handle `--ignored=matching` with `--untracked-files=normal` Signed-off-by: Jameson Miller <jam...@microsoft.com> --- dir.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/dir.c b/dir.c index b9af87eca9..20457724c0

[PATCH v3 4/4] status: test --ignored=matching

2017-10-19 Thread Jameson Miller
Add tests around status reporting ignord files that match an exclude pattern for both --untracked-files=normal and --untracked-files=all. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- t/t7519-ignored-mode.sh | 183 1 file change

[PATCH v4 1/4] status: add option to show ignored files differently

2017-10-23 Thread Jameson Miller
ed directory matches an exclude pattern, then the path of the directory is returned. If a directory does not match an exclude pattern, but all of its contents are ignored, then the contained files are reported instead of the directory. Signed-off-by: Jameson Miller <jam...@microsoft.com>

[PATCH v4 3/4] status: document options to show matching ignored files

2017-10-23 Thread Jameson Miller
Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Documentation/git-status.txt | 21 +- Documentation/technical/api-directory-listing.txt | 27 +++ 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/Documentati

[PATCH v4 2/4] status: report matching ignored and normal untracked

2017-10-23 Thread Jameson Miller
Teach status command to handle `--ignored=matching` with `--untracked-files=normal` Signed-off-by: Jameson Miller <jam...@microsoft.com> --- dir.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/dir.c b/dir.c index b9af87eca9..20457724c0

[PATCH v4 4/4] status: test ignored modes

2017-10-23 Thread Jameson Miller
Add tests around status reporting ignord files that match an exclude pattern for both --untracked-files=normal and --untracked-files=all. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- t/t7521-ignored-mode.sh | 233 1 file change

[PATCH v4 0/4] status: add option to show ignored files differently

2017-10-23 Thread Jameson Miller
est to a name not taken in by topics in flight Jameson Miller (4): status: add option to show ignored files differently status: report matching ignored and normal untracked status: document options to show matching ignored files status: test ignored modes Documentation/git-status.txt

RE: [PATCH v6 2/8] read-cache: teach make_cache_entry to take object_id

2018-07-05 Thread Jameson Miller
> > > > Teach make_cache_entry function to take object_id instead of a SHA-1. > > This repeats the subject line? > > Sign off missing. Thank you Stefan for pointing this out. This does not add much information to the subject line. I could clean it up if I re-roll to fix up the missing sign

[PATCH v4 2/3] fast-import: introduce mem_pool type

2018-04-11 Thread Jameson Miller
to reflect their more scoped usage. These changes allow for the multiple instances of a memory pool to exist and be reused outside of fast-import. In a future commit the mem_pool type will be moved to its own file. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- fast-import.

[PATCH v4 0/3] Extract memory pool logic into reusable component

2018-04-11 Thread Jameson Miller
. - Updated variable names in 2/3 to reflect updated usage of variable. Jameson Miller (3): fast-import: rename mem_pool type to mp_block fast-import: introduce mem_pool type Move reusable parts of memory pool into its own file Makefile | 1 + fast-import.c | 77

[PATCH v4 3/3] Move reusable parts of memory pool into its own file

2018-04-11 Thread Jameson Miller
This moves the reusable parts of the memory pool logic used by fast-import.c into its own file for use by other components. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Makefile | 1 + fast-import.c | 70 +-- mem-

[PATCH v4 1/3] fast-import: rename mem_pool type to mp_block

2018-04-11 Thread Jameson Miller
in future patches. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- fast-import.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/fast-import.c b/fast-import.c index 99f8f56e8c..38af0a294b 100644 --- a/fast-import.c +++ b/fast-import.c

RE: [PATCH v4 0/3] Extract memory pool logic into reusable component

2018-04-17 Thread Jameson Miller
/20180417163400.3875-2-jam...@microsoft.com/ -Original Message- From: Jameson Miller Sent: Wednesday, April 11, 2018 2:38 PM To: git@vger.kernel.org Cc: gits...@pobox.com; p...@peff.net; sunsh...@sunshineco.com; ram...@ramsayjones.plus.com; Jameson Miller <jam...@microsoft.com> Subject:

[PATCH v1 3/5] mem-pool: fill out functionality

2018-04-17 Thread Jameson Miller
will be used in a future commit in this commit series. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- mem-pool.c | 103 ++--- mem-pool.h | 32 +++ 2 files changed, 131 insertions(+), 4 deletions(-) diff --git a/mem-

[PATCH v1 2/5] Add an API creating / discarding cache_entry structs

2018-04-17 Thread Jameson Miller
Add an API around managing the lifetime of cache_entry structs. Abstracting memory management details behind an API will allow for alternative memory management strategies without affecting all the call sites. This commit does not change how memory is allocated / freed. A later commit in this

[PATCH v1 5/5] Add optional memory validations around cache_entry lifecyle

2018-04-17 Thread Jameson Miller
Add an option (controlled by an environment variable) perform extra validations on mem_pool allocated cache entries. When set: 1) Invalidate cache_entry memory when discarding cache_entry. 2) When discarding index_state struct, verify that all cache_entries were allocated from expected

[PATCH v1 1/5] read-cache: teach refresh_cache_entry to take istate

2018-04-17 Thread Jameson Miller
Refactoring dependencies of make_cache_entry to work on a specific index, instead of implicitly using the_index. This is in preparation for making the make_cache_entry function work on a specific index. --- cache.h | 2 +- merge-recursive.c | 2 +- read-cache.c | 7 --- 3 files

[PATCH v1 4/5] Allocate cache entries from memory pools

2018-04-17 Thread Jameson Miller
Improve performance of reading a large index by reducing the number of malloc() calls. When reading an index with a large number of entries, a portion of the time is dominated in malloc() calls. This can be mitigated by allocating a single large block of memory up front into a memory pool and have

[PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-17 Thread Jameson Miller
ine commit: 8b026eda Revert "Merge branch 'en/rename-directory-detection'" Jameson Miller (5): read-cache: teach refresh_cache_entry to take istate Add an API creating / discarding cache_entry structs mem-pool: fill out functionality Allocate cache entries from memory pools Add op

[PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-17 Thread Jameson Miller
ine commit: 8b026eda Revert "Merge branch 'en/rename-directory-detection'" Jameson Miller (5): read-cache: teach refresh_cache_entry to take istate Add an API creating / discarding cache_entry structs mem-pool: fill out functionality Allocate cache entries from memory pools Add op

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/17/2018 02:39 PM, Ben Peart wrote: On 4/17/2018 12:34 PM, Jameson Miller wrote: 100K Test   baseline [4] block_allocation 0002.1: read_cache/discard_cache 1 times

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/18/2018 12:49 AM, Junio C Hamano wrote: Jameson Miller <jam...@microsoft.com> writes: This patch series improves the performance of loading indexes by reducing the number of malloc() calls. ... Jameson Miller (5): read-cache: teach refresh_cache_entry to take istate Add

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/20/2018 01:49 PM, Stefan Beller wrote: base-commit: cafaccae98f749ebf33495aec42ea25060de8682 I couldn't quite figure out what these five patches were based on, even with this line. Basing on and referring to a commit that is not part of our published history with "base-commit" is not

Re: [PATCH v1 3/5] mem-pool: fill out functionality

2018-04-23 Thread Jameson Miller
On 04/23/2018 01:49 PM, Jonathan Tan wrote: On Mon, 23 Apr 2018 13:27:09 -0400 Jameson Miller <jameson.mille...@gmail.com> wrote: This seems overly complicated - the struct mem_pool already has a linked list of pages, so couldn't you create a custom page and insert it behind the c

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/20/2018 07:34 PM, Jonathan Tan wrote: On Tue, 17 Apr 2018 16:34:39 + Jameson Miller <jam...@microsoft.com> wrote: Jameson Miller (5): read-cache: teach refresh_cache_entry to take istate Add an API creating / discarding cache_entry structs mem-pool: fill out functio

Re: [PATCH v1 3/5] mem-pool: fill out functionality

2018-04-23 Thread Jameson Miller
On 04/20/2018 07:21 PM, Jonathan Tan wrote: On Tue, 17 Apr 2018 16:34:42 + Jameson Miller <jam...@microsoft.com> wrote: @@ -19,8 +19,27 @@ struct mem_pool { /* The total amount of memory allocated by the pool. */ size_t pool_alloc; + + /* +* Array of po

[PATCH v3 0/3] Extract memory pool logic into reusable component

2018-03-26 Thread Jameson Miller
] https://github.com/jamill/git/compare/block_allocation_base...jamill:block_allocation Jameson Miller (3): fast-import: rename mem_pool type to mp_block fast-import: introduce mem_pool type Move reusable parts of memory pool into its own file Makefile | 1 + fast-import.c | 74

[PATCH v3 3/3] Move reusable parts of memory pool into its own file

2018-03-26 Thread Jameson Miller
This moves the reusable parts of the memory pool logic used by fast-import.c into its own file for use by other components. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Makefile | 1 + fast-import.c | 70 +-- mem-

[PATCH v3 1/3] fast-import: rename mem_pool type to mp_block

2018-03-26 Thread Jameson Miller
in future patches. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- fast-import.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/fast-import.c b/fast-import.c index 58ef360da4..6c3215d7c3 100644 --- a/fast-import.c +++ b/fast-import.c

[PATCH v3 2/3] fast-import: introduce mem_pool type

2018-03-26 Thread Jameson Miller
and be reused outside of fast-import. In a future commit the mem_pool type will be moved to its own file. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- fast-import.c | 80 +-- 1 file changed, 51 insertions(+), 29 deletions(-)

Re: [PATCH v3 3/3] Move reusable parts of memory pool into its own file

2018-03-29 Thread Jameson Miller
f this week and next week, but will update this patch series when I get back (Week of April 9th). Thank you Jameson From: Junio C Hamano <jch2...@gmail.com> on behalf of Junio C Hamano <gits...@pobox.com> Sent: Tuesday, March 27, 201

[PATCH v2 0/3] Extract memory pool logic into reusable component

2018-03-23 Thread Jameson Miller
out the mem_pool type into a more complete implementation. These functions are not used in this change, but we will be used in an upcoming patch series. I can remove this commit if it is desired. [1] https://github.com/jamill/git/compare/block_allocation_base...jamill:block_allocation Jameson

[PATCH v2 2/5] fast-import: introduce mem_pool type

2018-03-23 Thread Jameson Miller
Introduce the mem_pool type and wrap the existing mp_block in this new type. The new mem_pool type will allow for the memory pool logic to be reused outside of fast-import. This type will be moved into its own file in a future commit. Signed-off-by: Jameson Miller <jam...@microsoft.com> ---

[PATCH v2 5/5] Expand implementation of mem-pool type

2018-03-23 Thread Jameson Miller
This commit adds functionality to the mem-pool type that can be generally useful. This functionality will be used in a future commit. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- mem-pool.c | 58 ++ mem-pool.

[PATCH v2 4/5] Move the reusable parts of memory pool into its own file

2018-03-23 Thread Jameson Miller
This moves the reusable parts of the memory pool logic used by fast-import.c into its own file for use by other components. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- Makefile | 1 + fast-import.c | 118 +- mem-

[PATCH v2 3/5] fast-import: update pool_* functions to work on local pool

2018-03-23 Thread Jameson Miller
Update memory pool functions to work on a passed in mem_pool instead of the global mem_pool type. This is in preparation for making the memory pool logic reusable. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- fast-import.c | 52 ++---

[PATCH v2 1/5] fast-import: rename mem_pool type to mp_block

2018-03-23 Thread Jameson Miller
in future patches. Signed-off-by: Jameson Miller <jam...@microsoft.com> --- fast-import.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/fast-import.c b/fast-import.c index 58ef360da4..6c3215d7c3 100644 --- a/fast-import.c +++ b/fast-import.c

[PATCH v5 3/8] block alloc: add lifecycle APIs for cache_entry structs

2018-06-28 Thread Jameson Miller
the corresponding memory. Signed-off-by: Jameson Miller --- apply.c| 24 +-- blame.c| 5 +-- builtin/checkout.c | 8 ++-- builtin/difftool.c | 6 +-- builtin/reset.c| 2 +- builtin/update-index.c | 26 +--- cache.h| 40

[PATCH v5 7/8] block alloc: allocate cache entries from mem-pool

2018-06-28 Thread Jameson Miller
he entries We decided tracking and iterating over known memory pool regions was less desirable than adding an extra field to track this stae. Signed-off-by: Jameson Miller --- cache.h| 21 + mem-pool.c | 3 +- read-cache

[PATCH v5 1/8] read-cache: teach refresh_cache_entry() to take istate

2018-06-28 Thread Jameson Miller
Refactor refresh_cache_entry() to work on a specific index, instead of implicitly using the_index. This is in preparation for making the make_cache_entry function apply to a specific index. Signed-off-by: Jameson Miller --- cache.h | 2 +- merge-recursive.c | 2 +- read-cache.c

  1   2   >