Re: [PATCH 04/12] Makefile: introduce CROSS_COMPILE variable

2014-04-28 Thread Marat Radchenko
On Mon, Apr 28, 2014 at 01:45:04PM -0700, Jonathan Nieder wrote: I'm not really sure what in particular you're pointing to in that page. If you have a more specific question about what '?=' means, could you say it? Woops. I guess I need some sleep. Confused '?=' with ':='. -- To unsubscribe

[NOT_A_PATCH] A naive attempt to cross-build Linux-mingw64 Git

2014-04-21 Thread Marat Radchenko
config.mak.uname: provide a way to explicitely request MinGW build. This is required to perform Linux-MinGW crosscompilation. --- Personally I don't see why ideally I shouldn't be able to build upstream Git for Windows with mingw without leaving my Linux system. One day you might be able, but

Re: [ANNOUNCE] WinGit - native x86/x64 Git for Windows

2014-04-19 Thread Marat Radchenko
So the reason for this new package is that you need 64bit binaries? That's the most important bit. Plus, weird ssh transfer speeds [1] caused by ansient openssh bundled in msysgit. I can see the need for a pure Windows solution (no msys tools at least for runtime). Several Git scripts are

Re: [msysGit] Re: [ANNOUNCE] WinGit - native x86/x64 Git for Windows

2014-04-19 Thread Marat Radchenko
On Sat, Apr 19, 2014 at 05:24:33PM +0200, Johannes Schindelin wrote: Marat, please do not add to the confusion. msysGit is the name of the *development environment* for developing Git for Windows. This confusion comes from the fact that major part of msysGit is packaged with Git for Windows to

[PATCH] MSVC: allow using ExtUtils::MakeMaker

2014-04-03 Thread Marat Radchenko
Drop NO_PERL_MAKEMAKER from config.mak.uname for the MSVC platform. MakeMaker is available on Windows Perl implementations and installs modules to correct location, unlike NO_PERL_MAKEMAKER Makefile. Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- config.mak.uname | 1 - 1 file

Re: [ANNOUNCE] WinGit - native x86/x64 Git for Windows

2014-04-03 Thread Marat Radchenko
On Thursday 03 April 2014 at 17:48:08 Konstantin Khomoutov wrote: What is the state of Unicode support in WinGit? I haven't seen any Unicode-related issues when using through TortoiseGit. Command-line usage is currently broken: no UTF-8 -cmd.exe encoding conversion is performed. Fixing this

[PATCH v4 0/3] Take four on fixing OPT_SET_PTR issues

2014-03-30 Thread Marat Radchenko
by reverting №3, it will be returned in a sane state. Decision of (not) merging №3 is left as an exercise to the reader due to my insufficient knowledge of accepted practices in Git project. Marat Radchenko (3): MSVC: fix t0040-parse-options crash parse-options: add cast to correct pointer

[PATCH v4 1/3] MSVC: fix t0040-parse-options crash

2014-03-30 Thread Marat Radchenko
with correct one. Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- test-parse-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-parse-options.c b/test-parse-options.c index 434e8b8..6f6c656 100644 --- a/test-parse-options.c +++ b/test-parse-options.c @@ -60,7

[PATCH v4 3/3] parse-options: remove unused OPT_SET_PTR

2014-03-30 Thread Marat Radchenko
OPT_SET_PTR was never used since its creation in 2007 (commit db7244bd5be12e389badb9cec621dbbcfa11f59a). --- Documentation/technical/api-parse-options.txt | 4 parse-options.c | 5 - parse-options.h | 5 +

[BUG] 'pread' : macro redefinition

2014-03-30 Thread Marat Radchenko
Stefan Zager szager at chromium.org writes: This adds a Windows implementation of pread. diff --git a/compat/mingw.h b/compat/mingw.h index 08b83fe..377ba50 100644 --- a/compat/mingw.h +++ b/compat/mingw.h +ssize_t mingw_pread(int fd, void *buf, size_t count, off64_t offset); +#define

[PATCH v2] MSVC: fix t0040-parse-options crash

2014-03-29 Thread Marat Radchenko
. Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write

[PATCH v3] MSVC: fix t0040-parse-options crash

2014-03-29 Thread Marat Radchenko
with correct one. Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- Aargh! Didn't notice that V2 introduced compilation warning. Take three. test-parse-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-parse-options.c b/test-parse-options.c index 434e8b8

[PATCH v2] MSVC: define INLINE=__inline so simple `make MSVC=1` actually works

2014-03-28 Thread Marat Radchenko
Without this, xdiff/xutils.c fails to compile. Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- I thought about removing #define inline __inline from compat/msvc.h but: * compat/msvc.h is included based on #if defined(_MSC_VER) and can be enabled even if MSVC != 1 * compat/msvc.h

[BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Marat Radchenko
Jeff King peff at peff.net writes: The write_or_die function will always die on an error, including EPIPE. However, it currently treats EPIPE specially by suppressing any error message, and by exiting with exit code 0. This causes error box on Windows in MSVC=1 build:

Re: [BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Marat Radchenko
Marat Radchenko marat at slonopotamus.org writes: Jeff King peff at peff.net writes: The write_or_die function will always die on an error, including EPIPE. However, it currently treats EPIPE specially by suppressing any error message, and by exiting with exit code 0

Re: [BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Marat Radchenko
Jeff King peff at peff.net writes: I'm not sure what an actual SIGPIPE death looks like on Windows. There is no SIGPIPE death on Windows due to total absence of SIGPIPE. raise(unsupported int) just causes ugly git.exe has stopped working window and possibly ends up as SIGABT (I don't know how

[PATCH] MSVC: fix t0040-parse-options

2014-03-28 Thread Marat Radchenko
Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- test-parse-options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test-parse-options.c b/test-parse-options.c index 434e8b8..7840493 100644 --- a/test-parse-options.c +++ b/test-parse-options.c @@ -11,6 +11,7

[PATCH v2] MSVC: link in invalidcontinue.obj for better POSIX compatibility

2014-03-28 Thread Marat Radchenko
, it is treated as invalid argument, causing abort() and crash report window. Linking in invalidcontinue.obj (provided along with MS compiler) allows raise(SIGPIPE) to return with errno=EINVAL. Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- config.mak.uname | 2 +- 1 file changed, 1 insertion

[PATCH] MSVC: allow enabling CURL

2014-03-27 Thread Marat Radchenko
Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- compat/vcbuild/scripts/clink.pl | 2 ++ config.mak.uname| 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl index 4374771..a87d0da 100755

[PATCH] MSVC: added missing include so `make INLINE=__inline` is no longer required

2014-03-27 Thread Marat Radchenko
Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- xdiff/xutils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xdiff/xutils.c b/xdiff/xutils.c index 62cb23d..a21a835 100644 --- a/xdiff/xutils.c +++ b/xdiff/xutils.c @@ -23,6 +23,7 @@ #include limits.h #include assert.h #include

Re: [PATCH] MSVC: added missing include so `makeINLINE=__inline` is no longer required

2014-03-27 Thread Marat Radchenko
Junio C Hamano gitster at pobox.com writes: My gut feeling is that adding a mechanism to add -DINLINE=__inline only on MSVC to the top-level Makefile, without touching this file, may be a much more palatable. Okay, I'll think more about this one. Maybe *moving* inline=__inline from

<    1   2