[PATCH] submodule recursion in git-archive

2013-11-25 Thread Nick Townsend
that crept in to existing doc and declarations. It is required for the second which actually implements the changes. All comments gratefully received! Regards Nick Townsend Subject: [PATCH 1/2] submodule: add_submodule_odb() usability Although add_submodule_odb() is documented as being externally

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 16:28, René Scharfe l@web.de wrote: Am 26.11.2013 23:18, schrieb Junio C Hamano: René Scharfe l@web.de writes: Thanks for the patches! Please send only one per message (the second one as a reply to the first one, or both as replies to a cover letter), though --

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 14:38, Heiko Voigt hvo...@hvoigt.net wrote: Hi, I like where this is going. On Tue, Nov 26, 2013 at 04:17:43PM +0100, René Scharfe wrote: Am 26.11.2013 01:04, schrieb Nick Townsend: + strbuf_addstr(dotgit, work_tree); + strbuf_addch(dotgit

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 14:18, Junio C Hamano gits...@pobox.com wrote: René Scharfe l@web.de writes: Thanks for the patches! Please send only one per message (the second one as a reply to the first one, or both as replies to a cover letter), though -- that makes commenting on them much

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 07:17, René Scharfe l@web.de wrote: Am 26.11.2013 01:04, schrieb Nick Townsend: My first git patch - so shout out if I’ve got the etiquette wrong! Or of course if I’ve missed something. Thanks for the patches! Please send only one per message (the second one

Re: [PATCH] submodule recursion in git-archive

2013-12-02 Thread Nick Townsend
On 27 Nov 2013, at 11:43, Junio C Hamano gits...@pobox.com wrote: Nick Townsend nick.towns...@mac.com writes: On 26 Nov 2013, at 14:18, Junio C Hamano gits...@pobox.com wrote: Even if the code is run inside a repository with a working tree, when producing a tarball out of an ancient

Fwd: [PATCH] submodule recursion in git-archive

2013-12-02 Thread Nick Townsend
Begin forwarded message: From: Nick Townsend nick.towns...@mac.com Subject: Re: [PATCH] submodule recursion in git-archive Date: 2 December 2013 16:00:50 GMT-8 To: Junio C Hamano gits...@pobox.com Cc: René Scharfe l@web.de, Jens Lehmann jens.lehm...@web.de, git@vger.kernel.org, Jeff

[PATCH] submodule recursion in git-archive

2013-12-02 Thread Nick Townsend
From: Nick Townsend nick.towns...@mac.com Subject: Re: [PATCH] submodule recursion in git-archive Date: 2 December 2013 15:55:36 GMT-8 To: Heiko Voigt hvo...@hvoigt.net Cc: Junio C Hamano gits...@pobox.com, René Scharfe l@web.de, Jens Lehmann jens.lehm...@web.de, git@vger.kernel.org, Jeff

[PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-02 Thread Nick Townsend
As per the previous patch request, I’ve delayed the work on git-archive. However the following two patches (attached as replies) should still be considered. Kind Regards Nick-- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-02 Thread Nick Townsend
From: Nick Townsend nick.towns...@mac.com Date: Mon, 25 Nov 2013 15:31:09 -0800 Subject: [PATCH 1/2] submodule: add_submodule_odb() usability Although add_submodule_odb() is documented as being externally usable, it is declared static and also has incorrect documentation. This commit fixes those

Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-02 Thread Nick Townsend
From: Nick Townsend nick.towns...@mac.com Date: Sat, 30 Nov 2013 16:54:20 -0800 Subject: [PATCH 2/2] Additional git-archive tests Interplay between paths specified in three ways now tested: * After a : in the tree-ish, * As a pathspec in the command, * By virtue of the current working directory

[PATCH] Additional git-archive tests

2013-12-04 Thread Nick Townsend
to regression test enhancements made to parse_treeish_arg() in archive.c Helped-by: Eric Sunshine sunsh...@sunshineco.com Signed-off-by: Nick Townsend nick.towns...@mac.com --- t/t5004-archive-corner-cases.sh | 71 + 1 file changed, 71 insertions(+) diff --git a/t

Re: [PATCH] Additional git-archive tests

2013-12-09 Thread Nick Townsend
On 5 Dec 2013, at 11:52, Junio C Hamano gits...@pobox.com wrote: Nick Townsend nick.towns...@mac.com writes: Interplay between paths specified in three ways now tested: * After a : in the tree-ish, * As a pathspec in the command, * By virtue of the current working directory Note