Re: [Feature Request] git blame showing only revisions from git rev-list --first-parent

2015-09-12 Thread Philip Oakley
From: "Junio C Hamano" Sent: Saturday, September 12, 2015 9:29 AM Jeff King writes: Yeah, I think what is happening in this first hunk: ... is doing the right thing. It did feel a little weird to me to be munging the global commit objects themselves, but I guess it is fairly normal for git

Re: storing cover letter of a patch series?

2015-09-10 Thread Philip Oakley
From: "Johannes Schindelin" On 2015-09-10 23:00, Jacob Keller wrote: On Thu, Sep 10, 2015 at 11:58 AM, Johannes Schindelin wrote: On 2015-09-10 18:28, Jacob Keller wrote: does anyone know of any tricks for storing a cover letter for a patch series inside of git somehow? It is not stored

Re: storing cover letter of a patch series?

2015-09-10 Thread Philip Oakley
From: "Jacob Keller" On Thu, Sep 10, 2015 at 11:44 AM, Junio C Hamano wrote: Jacob Keller writes: I hadn't thought of separating the cover letter from git-send-email. That would be suitable for me. Yeah, I said this number of times over time, and I said it once recently in another thread,

Re: [PATCH] show-ref: place angle brackets around variables in usage string

2015-08-29 Thread Philip Oakley
From: "Alex Henrie" Signed-off-by: Alex Henrie --- builtin/show-ref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/show-ref.c b/builtin/show-ref.c index dfbc314..131ef28 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -8,7 +8,7 @@ static const char * c

Re: Git's inconsistent command line options

2015-08-26 Thread Philip Oakley
From: "Jacob Keller" On Wed, Aug 26, 2015 at 10:56 AM, Junio C Hamano wrote: But notice that I said "if you really want to". I personally think it is a road to madness. Agreed. I don't believe in command line API here. I think we'd need a better solution. My gut says: Live with the warts o

Re: [PATCH v3] po/README: Update directions for l10n contributors

2015-08-16 Thread Philip Oakley
From: "Jiang Xin" From: Philip Oakley Some Linux distributions (such as Ubuntu) have their own l10n workflows, and their translations may be different. Add notes for this case for l10n translators. Signed-off-by: Philip Oakley Signed-off-by: Jiang Xin --- po/R

Re: [PATCH v2 0/1] handling mistranslation reports

2015-08-16 Thread Philip Oakley
From: "Jiang Xin" 2015-08-04 6:29 GMT+08:00 Philip Oakley : Hi Jiang, This is my updated patch based on your feedback at $gmane/275141 and $gmane/275142. I've used most of your wording, though have retained a comment on considering if the translation could be held her

Re: wishlist: make it possible to amend commit messages after push to remote

2015-08-07 Thread Philip Oakley
From: "Jarkko Hietaniemi" Thanks (also to Jacob Keller), the git-notes might work in some cases. But it's obviously a pasted-on solution, requiring a different usage, e.g. "git log --notes", and whatever other UIs do with it. One more thing, if you know that no one has fetched the branch you j

Re: [PATCH 1/1] po/README: split out the different contribution types

2015-08-03 Thread Philip Oakley
From: "Jiang Xin" 2015-08-02 21:42 GMT+08:00 Philip Oakley : Separate out the three different contribution styles for existing, new, and wider mis-translation contributions, with suitable headings for easy reference. In particular highlight the appropriate action should

Re: FeatureRequest: Build improvements for Windows

2015-07-26 Thread Philip Oakley
Hi, From: "Dangling Pointer" I searched in code and found instances of #ifdef _MSC_VER in https://github.com/git/git (original repository, not the fork). I am coming from github, where I have found many native lib repositories have two build files, build.sh and build.cmd with Git is a *nix co

Re: FeatureRequest: Build improvements for Windows

2015-07-26 Thread Philip Oakley
(In-line posting preferred; top-posting deprecated ;-) (retain all cc's) Hmm, it is already happening, isn't it? There is already a support of MSVCR in git's code base. I am referring to replacing that current support of 'older' MSVCR in favor of the latest one, so to make the git's code base

Re: [PATCH 1/9] refs: Introduce pseudoref and per-worktree ref concepts

2015-07-24 Thread Philip Oakley
From: "David Turner" Add glossary entries for both concepts. Pseudorefs and per-worktree refs do not yet have special handling, because the files refs backend already handles them correctly. Later, we will make the LMDB backend call out to the files backend to handle per-worktree refs. Signed

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-21 Thread Philip Oakley
From: "Junio C Hamano" Junio C Hamano writes: I was trying to use, essentially, 'cat list.txt' as the command,... One thing that needs to be made clear is that I do not think we want to encourage `cat list.txt #` abuse in the first place. OK [1] It is an unacceptable hack for us to en

Re: [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again

2015-07-21 Thread Philip Oakley
From: "Junio C Hamano" Junio C Hamano writes: "Philip Oakley" writes: ... Ideally, if part of this mainstream Git, it would get picked up automatically by them (rather than being local 'fixes' endlessly carried forward). Actually, that is not "ideal&q

Re: [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again

2015-07-21 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: This updates two patches in the series based on Eric Sunshine's comments. Patch 8b updates the commit message to make clear what was going wrong. Patch 10b improves the perl code. Is v2b like saying v3 or something else? Does 8

[PATCH v2 10b/16] engine.pl: delete the captured stderr file if empty

2015-07-20 Thread Philip Oakley
identically defined in their respective GIT_VERSION_GEN file DEF_VER variables. [1]: http://perldoc.perl.org/functions/-X.html [2]: http://git-for-windows.github.io/ Helped-by: Eric Sunshine Signed-off-by: Philip Oakley --- Eric's help gmane.comp.version-control.msysgit/21745 --- contrib/buildsy

[PATCH v2 8b/16] engine.pl: ignore invalidcontinue.obj which is known to MSVC

2015-07-20 Thread Philip Oakley
without source files) separate. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 60c7a7d..9db3d43 100755 --- a/contrib/buildsystems/e

[PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again

2015-07-20 Thread Philip Oakley
This updates two patches in the series based on Eric Sunshine's comments. Patch 8b updates the commit message to make clear what was going wrong. Patch 10b improves the perl code. Junio: would a full re-roll be appropriate at a suitable point? Philip Oakley (2): engine.pl: i

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: +git-send-email invokes the cc-cmd like this: + + $cc-cmd $patchfilename + +Thus the patch itself can be processed to locate appropriate email address +information if required. That's not even a valid command line (cc-cmd ca

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Philip Oakley
From: "Eric Sunshine" On Mon, Jul 20, 2015 at 2:26 PM, Philip Oakley wrote: Explain how the cc-cmd (and to-cmd) is invoked, along with two simple examples (and a how-not-to example) to help in getting started. Helped-by: Eric Sunshine Signed-off-by: Philip Oakley --- di

Re: [PATCH 2/3] doc: send-email; expand oon the meaning of 'auto-cc'

2015-07-20 Thread Philip Oakley
Sorry for the noise. - Original Message - From: "Philip Oakley" To: "Git List" Cc: "Junio C Hamano" ; "Eric Sunshine" Sent: Monday, July 20, 2015 7:26 PM Subject: [PATCH 2/3] doc: send-email; expand oon the meaning of 'auto-cc' --

[PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Philip Oakley
Explain how the cc-cmd (and to-cmd) is invoked, along with two simple examples (and a how-not-to example) to help in getting started. Helped-by: Eric Sunshine Signed-off-by: Philip Oakley --- http://article.gmane.org/gmane.comp.version-control.git/274302 --- Documentation/git-send-email.txt

[PATCH 0/3] Update send-email cc-cmd documentation

2015-07-20 Thread Philip Oakley
n docbook'ed. The series could be squashed together.. Philip Oakley (3): doc: convert send-email option headings to nouns doc: send-email; expand on the meaning of 'auto-cc' doc: give examples for send-email cc-cmd operation Documentation/git-send-email.txt | 54

[PATCH 2/3] doc: send-email; expand oon the meaning of 'auto-cc'

2015-07-20 Thread Philip Oakley
Signed-off-by: Philip Oakley --- Documentation/git-send-email.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index bc357b8..ddc8a11 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git

[PATCH 2/3] doc: send-email; expand on the meaning of 'auto-cc'

2015-07-20 Thread Philip Oakley
Signed-off-by: Philip Oakley --- Documentation/git-send-email.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index bc357b8..ddc8a11 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git

[PATCH 1/3] doc: convert send-email option headings to nouns

2015-07-20 Thread Philip Oakley
... for ease of reference within the text. Except the 'Sending options' for which there wasn't an obvious noun phrase. Signed-off-by: Philip Oakley --- Documentation/git-send-email.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documen

Re: How to use --cc-cmd in git-send-email?

2015-07-20 Thread Philip Oakley
From: "Eric Sunshine" On Mon, Jul 20, 2015 at 2:01 AM, Philip Oakley wrote: From: "Eric Sunshine" git-send-email invokes the cc-cmd like this: $cc-cmd $patchfilename so, when you used 'cat cc-cmd' as the value of --cc-cmd, your invocation became:

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-20 Thread Philip Oakley
From: "Eric Sunshine" On Mon, Jul 20, 2015 at 2:16 AM, Philip Oakley wrote: From: "Eric Sunshine" On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: Keep the build clean of extraneous files if it is indeed clean. Otherwise leave the msvc-build-makedryerrors.txt fil

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Philip Oakley
From: "Eric Sunshine" On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: Keep the build clean of extraneous files if it is indeed clean. Otherwise leave the msvc-build-makedryerrors.txt file both as a flag for any CI system or for manual debugging. Note that the file will conta

Re: [msysGit] [PATCH v2 08/16] engine.pl: ignore invalidcontinue.obj which is known to MSVC

2015-07-19 Thread Philip Oakley
From: "Eric Sunshine" Sent: Monday, July 20, 2015 2:54 AM On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: Commit 4b623d8 (MSVC: link in invalidcontinue.obj for better POSIX compatibility, 2014-03-29) is not processed correctly by the buildsystem. Ignore it. What does &quo

Re: How to use --cc-cmd in git-send-email?

2015-07-19 Thread Philip Oakley
From: "Eric Sunshine" On Sun, Jul 19, 2015 at 6:02 PM, Philip Oakley wrote: I've been using git-send-email with repeated individual --cc="email address" parameters on the command line. I tried putting all the addresses, one per line, into a file 'cc-cmd

How to use --cc-cmd in git-send-email?

2015-07-19 Thread Philip Oakley
I've been using git-send-email with repeated individual --cc="email address" parameters on the command line. I tried putting all the addresses, one per line, into a file 'cc-cmd', so I could use if for the --cc-cmd option. I then tried to use --cc-cmd='cat cc-cmd' to do the send-email (as a

Re: [PATCH v2 14/16] vcbuild/readme: Improve layout and reference msvc-build script

2015-07-19 Thread Philip Oakley
From: "Philip Oakley" Sent: Sunday, July 19, 2015 9:08 PM This "14/16" is the wrong version accidently left over from a previous draft. Please use the other version with the shorter subject line. Sorry for the noise / mistake. Layout the 'either/or' with mor

[PATCH v2 14/16] vcbuild/readme: Improve layout

2015-07-19 Thread Philip Oakley
Layout the 'either/or' with more white space to clarify which alternatives are matched up. A revised copy of the Msysgit msvc-build script which automates this README is introduced in the next commit. Signed-off-by: Philip Oakley --- compat/vcbuild/README | 25 +--

[PATCH v2 02/16] .gitignore: improve MSVC ignore patterns

2015-07-19 Thread Philip Oakley
uite. Signed-off-by: Philip Oakley --- Junio's correction http://marc.info/?l=git&m=143524522500906&w=2 (2015-06-25) --- .gitignore | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index a685ec1..91e75ee 100644 --- a/.gitignore +++ b/.giti

[PATCH v2 15/16] msvc-build: add complete Microsoft Visual C compilation script

2015-07-19 Thread Philip Oakley
ectories. The script is made executable in line with $msysgit/cb9836b8a (Mark scripts and binaries in /bin/ as executable, 2012-06-26) Signed-off-by: Philip Oakley --- TODO: resolve any further cleaning of newer VS2010... build products. --- compat/vcbuild/README | 2 + compat/vcbuil

[PATCH v2 06/16] engine.pl: Properly accept quoted spaces in filenames

2015-07-19 Thread Philip Oakley
The engine.pl script barfs on the properly quoted spaces in filename options prevalent on Windows. Use shellwords() rather than split() to separate such options. Helped-by: Junio C Hamano Signed-off-by: Philip Oakley --- Junio's help at gmane.comp.version-control.msysgit/21145 (2014-

[PATCH v2 08/16] engine.pl: ignore invalidcontinue.obj which is known to MSVC

2015-07-19 Thread Philip Oakley
source .c filename. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 60c7a7d..9db3d43 100755 --- a/contrib/buildsystems/engin

[PATCH v2 09/16] engine.pl: name the msvc buildsystem's makedry error file

2015-07-19 Thread Philip Oakley
Save the stderr from the dry MSVC make to a well named file for later review. Use 'msvc-build-makedryerrors.txt' which should be obvious as to its source, and is not ignored by 'git status'. Signed-off-by: Philip Oakley --- fixed false mode change:- Junio's report (last

[PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Philip Oakley
file. They are omitted if the release is tagged and indentically defined in their respective GIT_VERSION_GEN file DEF_VER variables. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/buildsystems/engine.pl b/contrib

[PATCH v2 07/16] engine.pl: Fix i18n -o option in msvc buildsystem generator

2015-07-19 Thread Philip Oakley
same vein as 74cf9bd (engine.pl: Fix a recent breakage of the buildsystem generator, 2010-01-22). Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 24b899

[PATCH v2 12/16] engine.pl: provide more debug print statements

2015-07-19 Thread Philip Oakley
part of final binary code) and it will be having traceability to its low level requirements (its a intentional code and it can be activated in some configurations through hardware traps for debugging or other purposes. Signed-off-by: Philip Oakley --- My response to Sebastian Schuberth's co

[PATCH v2 13/16] Vcproj.pm: list git.exe first to be startup project

2015-07-19 Thread Philip Oakley
e GUID of the project you moved to the top. So there are two places to move lines." Signed-off-by: Philip Oakley --- contrib/buildsystems/Generators/Vcproj.pm | 33 ++- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/contrib/buildsystems/

[PATCH v2 14/16] vcbuild/readme: Improve layout and reference msvc-build script

2015-07-19 Thread Philip Oakley
Layout the 'either/or' with more white space to clarify which alternatives are matched up. Reference the Msysgit build script which automates one sequence of options. Signed-off-by: Philip Oakley --- compat/vcbuild/README | 27 +++ 1 file changed, 19 insert

[PATCH v2 16/16] config.mak.uname: add MSVC No_SafeExeceptionHandler option

2015-07-19 Thread Philip Oakley
ff-by: Philip Oakley --- Junio/my discussion on reviews: http://marc.info/?l=git&m=143526063906215&w=2 (2015-06-25) Patch series v1: https://github.com/msysgit/git/pull/318 Yue Lin Ho: https://github.com/msysgit/git/pull/318#issuecomment-81292918 --- config.mak.uname | 9 + 1 fi

[PATCH v2 11/16] engine.pl: add debug line to capture the dry-run

2015-07-19 Thread Philip Oakley
Add a debug suggestion for capturing to file the stdout from the dry-run of the make file used in determining the msvc-build structure for easy debugging. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/buildsystems

[PATCH v2 03/16] .gitignore: ignore library directories created by MSVC VS2008 buildsystem

2015-07-19 Thread Philip Oakley
Signed-off-by: Philip Oakley --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 91e75ee..e35c492 100644 --- a/.gitignore +++ b/.gitignore @@ -178,6 +178,7 @@ /gitweb/gitweb.cgi /gitweb/static/gitweb.js /gitweb/static/gitweb.min.* +/libgit

[PATCH v2 04/16] (msvc-build) Vcproj.pm: remove duplicate GUID

2015-07-19 Thread Philip Oakley
Delete the duplicated GUID from the generation code for the Visual Studio .sln project file. The duplicate GUID tended to be allocated to test-svn-fe, which was then ignored by Visual Studio / MSVC, and its omission from the build never noticed. Signed-off-by: Philip Oakley --- Eric Sunshine

[PATCH v2 00/16] Make the msvc-build scripts work again

2015-07-19 Thread Philip Oakley
gle.com/forum/?hl=en_US?hl%3Den#!topic/msysgit/aiEVBKjRshY and as a PR https://github.com/msysgit/git/pull/318/files Philip Oakley (16): perl/Makefile: treat a missing PM.stamp as if empty .gitignore: improve MSVC ignore patterns .gitignore: ignore library directories created by MSVC VS2008

[PATCH v2 01/16] perl/Makefile: treat a missing PM.stamp as if empty

2015-07-19 Thread Philip Oakley
it msvc-build script which implements the compat/vcbuild/README using contrib/buildsystems. The script msvc-build is introduced later in this series. Protect the PM.stamp target when the PM.stamp file does not exist, allowing a Git 'Makefile -n' to succeed on a clean repo. Signed-off-

[PATCH v2 05/16] engine.pl: fix error message (lib->link)

2015-07-19 Thread Philip Oakley
Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 23da787..c8a5258 100755 --- a/contrib/buildsystems/engine.pl +++ b/contrib/buildsystems

Re: [PATCH v3 06/18] rerere: drop want_sp parameter from is_cmarker()

2015-07-18 Thread Philip Oakley
From: "Junio C Hamano" As the nature of the conflict marker line determies if there should "should be a"? i.e. s/a /be a /below a SP and label after it, the caller shouldn't have to pass the parameter redundantly. Signed-off-by: Junio C Hamano --- rerere.c | 27 ++--

Re: [PATCH 04/17] Makefile: a dry-run can error out if no perl. Document the issue

2015-07-14 Thread Philip Oakley
From: "Philip Oakley" Sent: Friday, June 26, 2015 12:34 AM From: "Junio C Hamano" "Philip Oakley" writes: From: "Junio C Hamano" I am not sure what this patch is trying to achieve. I have been able to repeat the issue, more below. It was pr

Git has a healthy truck factor..

2015-07-13 Thread Philip Oakley
It looks like Git has a healthy truck factor of 8, as reported in https://mtov.github.io/Truck-Factor/, which has Git eighth in the list of projects it analyzed, with Linux at second place. The analysis method paper is behind a pay wall, so I couldn't see how sensible the methodology, but it's

Re: [PATCHv2] rev-parse --parseopt: allow [*=?!] in argument hints

2015-07-13 Thread Philip Oakley
uld be redundant. I have also made a slight addition to the man page to clarify the parsing, based on the Philip Oakley comment. Not sure if it is at the level Philip wants it to be. Please, let me know if you think it is still not good enough. The doc patch looks good. I've made

Re: [PATCH] rev-parse --parseopt: allow [*=?!] in argument hints

2015-07-12 Thread Philip Oakley
From: Sent: Sunday, July 12, 2015 10:39 AM From: Ilya Bobyr It is not very likely that any of the "*=?!" Characters would be useful in the argument short or long names. On the other hand, there are already argument hints that contain the "=" sign. It used to be impossible to include any of

Re: [PATCH v8 0/7] ref backend preamble

2015-07-10 Thread Philip Oakley
From: "David Turner" The current state of the discussion on alternate ref backends is that we're going to continue to store pseudorefs (e.g. CHERRY_PICK_HEAD) as Assuming this is accepted, should the definition of pseudorefs be included in the gitglossary? Once ref backends become common, t

Re: [msysGit] Re: [PATCH 13/17] engine.pl: provide more debug print statements

2015-07-07 Thread Philip Oakley
From: "Sebastian Schuberth" On 25.06.2015 02:03, Philip Oakley wrote: --- a/contrib/buildsystems/engine.pl +++ b/contrib/buildsystems/engine.pl @@ -41,6 +41,7 @@ EOM # Parse command-line options while (@ARGV) { my $arg = shift @ARGV; + #print "Arg: $arg \n";

Re: [msysGit] [PATCH 03/17] (msvc-build) Vcproj.pm: remove duplicate GUID

2015-06-28 Thread Philip Oakley
From: "Eric Sunshine" On Wed, Jun 24, 2015 at 8:03 PM, Philip Oakley wrote: Delete the duplicated GUID from the generation code for the Visual Studio .sln project file. The duplicate GUID tended to be allocated to test-svn-fe, which was then ignored by Visual Studio / MSVC

Re: [PATCH 04/17] Makefile: a dry-run can error out if no perl. Document the issue

2015-06-25 Thread Philip Oakley
From: "Junio C Hamano" "Philip Oakley" writes: From: "Junio C Hamano" I am not sure what this patch is trying to achieve. It was probably a bit of 'don't mess with working code', given that I'd used the NO_PERL solution, rather 'do

Re: [PATCH 04/17] Makefile: a dry-run can error out if no perl. Document the issue

2015-06-25 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: A 'make -n' dry-run is used as part of the /compat/vcbuild and /contrib/buildsystems code. The commit ee9be06 (perl: detect new files in MakeMaker builds, 2012-07-27) was not aware of that dry-run usage and thus would no

Re: [PATCH 01/17] .gitignore: improve MSVC ignore patterns

2015-06-25 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: Add the Microsoft .manifest pattern, and correct the generic 'Debug' and 'Release' directory patterns which were mechanically adjusted way back in c591d5f (gitignore: root most patterns at the top-level director

Re: [PATCH 00/17] Make the msvc-build scripts work again

2015-06-25 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: Hopefully it's not too late in the cycle for a review of this contrib/compat item. Has this been discussed in the Windows land and folks are all happy with this change? If so the only thing we would need review on the main

[PATCH 15/17] vcbuild/readme: Improve layout and reference msvc-build script

2015-06-24 Thread Philip Oakley
Layout the 'either/or' with more white space to clarify which alternatives are matched up. Reference the Msysgit build script which automates one sequence of options. Signed-off-by: Philip Oakley --- compat/vcbuild/README | 27 +++ 1 file changed, 19 insert

[PATCH 12/17] engine.pl: add debug line to capture the dry-run

2015-06-24 Thread Philip Oakley
Add a debug suggestion for capturing to file the stdout from the dry-run of the make file used in determining the msvc-build structure for easy debugging. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/buildsystems

[PATCH 04/17] Makefile: a dry-run can error out if no perl. Document the issue

2015-06-24 Thread Philip Oakley
issue and the available solutions of either NO_PERL or a '+recipe'. Signed-off-by: Philip Oakley --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 149f1c7..22108bb 100644 --- a/Makefile +++ b/Makefile @@ -1746,6 +1746,9 @@ $(SCRIPT_PERL_GEN): p

[PATCH 14/17] Vcproj.pm: list git.exe first to be startup project

2015-06-24 Thread Philip Oakley
group of entries in the "GlobalSection(ProjectConfigurationPlatforms) = postSolution" group that has the GUID of the project you moved to the top. So there are two places to move lines." Signed-off-by: Philip Oakley --- contrib/buildsystems/Generators/Vcproj.pm | 33 +++

[PATCH 17/17] config.mak.uname: add MSVC No_SafeExeceptionHandler option

2015-06-24 Thread Philip Oakley
Signed-off-by: Philip Oakley --- config.mak.uname | 9 + 1 file changed, 9 insertions(+) diff --git a/config.mak.uname b/config.mak.uname index 943c439..1c27828 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -1,5 +1,9 @@ # Platform specific Makefile tweaks based on uname

[PATCH 13/17] engine.pl: provide more debug print statements

2015-06-24 Thread Philip Oakley
is doubly hard to get developers to ride both horses so, contrary to normal convention, retain selected debug statements as a safety net for those willing to try. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 4 1 file changed, 4 insertions(+) diff --git a/contr

[PATCH 00/17] Make the msvc-build scripts work again

2015-06-24 Thread Philip Oakley
jRshY https://github.com/msysgit/git/pull/318/files Hopefully it's not too late in the cycle for a review of this contrib/compat item. Philip Oakley (17): .gitignore: improve MSVC ignore patterns .gitignore: ignore library directories created by MSVC VS2008 buildsystem (msvc-build)

[PATCH 11/17] engine.pl: delete the captured stderr file if empty

2015-06-24 Thread Philip Oakley
file. They are omitted if the release is tagged and indentically defined in their respective GIT_VERSION_GEN file DEF_VER variables. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/buildsystems/engine.pl b/contrib

[PATCH 08/17] engine.pl: Fix i18n -o option in msvc buildsystem generator

2015-06-24 Thread Philip Oakley
same vein as 74cf9bd (engine.pl: Fix a recent breakage of the buildsystem generator, 2010-01-22). Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index ccb59f

[PATCH 02/17] .gitignore: ignore library directories created by MSVC VS2008 buildsystem

2015-06-24 Thread Philip Oakley
Signed-off-by: Philip Oakley --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 55498c1..706d0d9 100644 --- a/.gitignore +++ b/.gitignore @@ -177,6 +177,7 @@ /gitweb/gitweb.cgi /gitweb/static/gitweb.js /gitweb/static/gitweb.min.* +/libgit

[PATCH 07/17] engine.pl: Properly accept quoted spaces in filenames

2015-06-24 Thread Philip Oakley
The engine.pl script barfs on the properly quoted spaces in filename options prevalent on Windows. Use shellwords() rather than split() to separate such options. Helped-by: Junio C Hamano Signed-off-by: Philip Oakley --- $gamane/21145 & $gmane/21147 --- contrib/buildsystems/engine.pl

[PATCH 03/17] (msvc-build) Vcproj.pm: remove duplicate GUID

2015-06-24 Thread Philip Oakley
Delete the duplicated GUID from the generation code for the Visual Studio .sln project file. The duplicate GUID tended to be allocated to test-svn-fe, which was then ignored by Visual Studio / MSVC, and it's omission from the build never noticed. Signed-off-by: Philip Oakley --- co

[PATCH 10/17] engine.pl: name the msvc buildsystem's makedry error file

2015-06-24 Thread Philip Oakley
Save the stderr from the dry MSVC make to a well named file for later review. Use 'msvc-build-makedryerrors.txt' which should be obvious as to its source, and is not ignored by 'git status'. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 5 - 1 file c

[PATCH 05/17] engine.pl: fix error message (lib->link)

2015-06-24 Thread Philip Oakley
Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 23da787..5398315 100755 --- a/contrib/buildsystems/engine.pl +++ b/contrib/buildsystems

[PATCH 16/17] msvc-build: add complete Microsoft Visual C compilation script

2015-06-24 Thread Philip Oakley
. Original author: Johannes Schindelin (2011-11-01 3142da4 : Add a script to make the MSVC build more convenient). Signed-off-by: Philip Oakley --- TODO: Also resolve the cleaning of newer VS2010 products. --- compat/vcbuild/README | 2 +- compat/vcbuild/scripts/msvc-

[PATCH 06/17] engine.pl: Avoid complications with perl support

2015-06-24 Thread Philip Oakley
ee9be06 (perl: detect new files in MakeMaker builds, 2012-07-27) did not include dry-run support for the generation of the PM.stamp file, though the dry-run output is used by the build engine. Disable the perl processing during the dry-run to avoid the issue. Signed-off-by: Philip Oakley

[PATCH 09/17] engine.pl: ignore invalidcontinue.obj which is known to MSVC

2015-06-24 Thread Philip Oakley
source .c filename. Signed-off-by: Philip Oakley --- contrib/buildsystems/engine.pl | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 73f2472..e8aa8ea 100755 --- a/contrib/buildsystems/engin

[PATCH 01/17] .gitignore: improve MSVC ignore patterns

2015-06-24 Thread Philip Oakley
uite. Signed-off-by: Philip Oakley --- .gitignore | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 422c538..55498c1 100644 --- a/.gitignore +++ b/.gitignore @@ -246,5 +246,6 @@ *.user *.idb *.pdb -/Debug/ -/Release/ +*.manifest +**/Debug/ +*

Re: Permission denied ONLY after pulling bundles

2015-06-04 Thread Philip Oakley
From: "Christian Couder" Hi, On Thu, Jun 4, 2015 at 3:04 PM, Rossella Barletta wrote: Dear git group, I would like to ask your help for a problem that we cannot fix in any way. We have a git repository in folder on Windows. Then we use VMware player on CentOS_6 on which we create a clon

Re: Suggestion: make git checkout safer

2015-06-03 Thread Philip Oakley
From: "Ed Avis" Sent: Wednesday, June 03, 2015 10:55 AM Jeff King peff.net> writes: I would say the more "usual" way to use checkout like this is to give specific paths. I.e., run "git status", say "oh, I need to restore the contents of 'foo', but not 'bar'", and run "git checkout foo". That

Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit

2015-05-27 Thread Philip Oakley
From: "Junio C Hamano" Matthieu Moy writes: I find it weird to write noop True, but then it can be spelled # too, so do we still want 'drop'? Unless we have a strong reason to believe migrants from Hg cannot be (re)trained, personally, I'd feel that we do not need this 'drop' thi

Re: [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs")

2015-05-22 Thread Philip Oakley
From: "Johannes Schindelin" Hi, On 2015-05-22 19:14, Philip Oakley wrote: From: "Johannes Schindelin" On 2015-05-22 11:42, Johannes Schindelin wrote: On 2015-05-22 10:33, Roberto Tyley wrote: On Tuesday, 19 May 2015, Stefan Beller wrote: On Tue, May 19, 2015

Re: [PATCH] submodule documentation: Reorder introductory paragraphs

2015-05-22 Thread Philip Oakley
From: "Stefan Beller" It's better to start the man page with a description of what submodules actually are instead of saying what they are not. Reorder the paragraphs such that the first short paragraph introduces the submodule concept, the second paragraph highlights the usage of the submodul

Re: [PATCH] submodule documentation: Reorder introductory paragraphs

2015-05-22 Thread Philip Oakley
From: "Stefan Beller" On Fri, May 22, 2015 at 10:35 AM, Philip Oakley wrote: From: "Stefan Beller" On Fri, May 22, 2015 at 7:36 AM, Junio C Hamano wrote: Stefan Beller writes: On Thu, May 21, 2015 at 1:03 PM, Philip Oakley wrote: +Submodules are not to be c

Re: [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs")

2015-05-22 Thread Philip Oakley
From: "Junio C Hamano" Roberto Tyley writes: Hello, I'm stepping up to do that work :) Or at least, I'm implementing a one-way GitHub PR -> Mailing list tool, called submitGit: https://submitgit.herokuapp.com/ Yay ;-) Here's what a user does: * create a PR on https://github.com/git/git

Re: [PATCH] submodule documentation: Reorder introductory paragraphs

2015-05-22 Thread Philip Oakley
From: "Stefan Beller" On Fri, May 22, 2015 at 7:36 AM, Junio C Hamano wrote: Stefan Beller writes: On Thu, May 21, 2015 at 1:03 PM, Philip Oakley wrote: +Submodules are not to be confused with remotes, which are meant +mainly for branches of the same project; This use of

Re: [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs")

2015-05-22 Thread Philip Oakley
From: "Johannes Schindelin" Hi Roberto, On 2015-05-22 11:42, Johannes Schindelin wrote: On 2015-05-22 10:33, Roberto Tyley wrote: On Tuesday, 19 May 2015, Stefan Beller wrote: On Tue, May 19, 2015 at 12:29 PM, Robert Dailey wrote: > How do you send your patches inline? [snip] This workfl

Re: [PATCH] submodule documentation: Reorder introductory paragraphs

2015-05-22 Thread Philip Oakley
From: "Stefan Beller" On Thu, May 21, 2015 at 1:03 PM, Philip Oakley wrote: +Submodules are not to be confused with remotes, which are meant +mainly for branches of the same project; This use of 'branches' didn't work for me. "remotes are meant mainly for

Re: [PATCH] submodule documentation: Reorder introductory paragraphs

2015-05-21 Thread Philip Oakley
From: "Stefan Beller" It's better to start the man page with a description of what submodules actually are instead of saying what they are not. Reorder the paragraphs such that the first short paragraph introduces the submodule concept, the second paragraph highlights the usage of the submodul

Re: identical hashes on two branches, but holes in git log

2015-05-21 Thread Philip Oakley
From: "Philippe De Muyter" To: "Junio C Hamano" Cc: ; "Jeff King" ; "John Keeping" Sent: Thursday, May 21, 2015 8:15 AM Subject: Re: identical hashes on two branches, but holes in git log On Tue, May 19, 2015 at 03:12:31PM -0700, Junio C Hamano wrote: Philippe De Muyter writes: > On Tue

Re: [PATCH 3/3] clone: add `--seed` shorthand

2015-05-21 Thread Philip Oakley
From: "Johannes Schindelin" Hi Peff, On 2015-05-21 06:16, Jeff King wrote: diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt index f1f2a3f..ffeb03b 100644 --- a/Documentation/git-clone.txt +++ b/Documentation/git-clone.txt @@ -107,6 +107,9 @@ objects from the source repo

Re: git difftool and proper path escaping on windows

2015-05-10 Thread Philip Oakley
From: "David Aguilar" On May 8, 2015 10:31:05 AM PDT, Phil Susi wrote: I'm trying to have git difftool run winmerge to compare files, but it seems to be doing something silly with path translation. My first attempt was: git difftool -x /c/Program\ Files\ \(x86\)/WinMerge/WinMergeU.exe To wh

Re: Allowing weak references to blobs and strong references to commits

2015-03-31 Thread Philip Oakley
From: "Mike Hommey" [...] So I thought, since commits are already allowed in tree objects, for submodules, why not add a bit to the mode that would tell git that those commit object references are meant to always be there aka strong reference, as opposed to the current weak references for submo

Re: Sparse checkout not working as expected (colons in filenames on Windows)

2015-03-24 Thread Philip Oakley
From: "Duy Nguyen" On Fri, Mar 20, 2015 at 6:07 AM, Philip Oakley wrote: Hi, I was expecting that sparse checkout could be used to avoid the checking out, by git, of files which have colons in their name into the worktree when on Windows. Yue Lin Ho reported on the Msygit list [

Re: [PATCH] Documentation: Add target to build PDF manpages

2015-03-24 Thread Philip Oakley
From: "Michael J Gruber" Junio C Hamano venit, vidit, dixit 20.03.2015 23:38: Stefan Beller writes: Thomas referencing reading the man page offline, made me wonder why you wouldn't read the man pages itself as they can also be carried around offline. But the striking point is "on an iPad",

Re: [PATCH] Documentation: Add target to build PDF manpages

2015-03-20 Thread Philip Oakley
From: "Junio C Hamano" Stefan Beller writes: ... though how would I read man pages in pdf format? I tried searching the web and all I can find is how to convert the a man page to pdf. So is there a conveniant way to tell `man` to prefer opening pdfs when available? I presume that "man -Tpdf

Re: [PATCH] Documentation: Add target to build PDF manpages

2015-03-20 Thread Philip Oakley
From: "Stefan Beller" On Fri, Mar 20, 2015 at 4:23 AM, Thomas Schneider wrote: Signed-off-by: Thomas Schneider --- dblatex does print some warnings, but they seem to be irrelevant. Besides, first patch I submit to git or even to any project using a mailing list … let’s hope I did everything r

<    3   4   5   6   7   8   9   10   11   12   >