[PATCH v13 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C

are ported, this subcommand will be retired but its implementation will be called by some other methods. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 59 ++-- git-bisect.sh

[PATCH v13 11/13] bisect--helper: `bisect_next_check` & bisect_voc shell function in C

temporary measure to port shell function to C so as to use the existing test suite. As more functions are ported, this subcommand will be retired but its implementation will be called by some other methods. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva

[PATCH v13 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

d-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 3324229..8111c91 100644 --- a/builtin/bisect

[PATCH v13 07/13] bisect--helper: `bisect_reset` shell function in C

Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 48 +++- git-bisect.sh| 28 ++-- 2 files changed, 49 insertions(+), 27 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index

[PATCH v13 13/13] bisect--helper: `bisect_start` shell function partially in C

: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 252 +-- git-bisect.sh| 133 + 2 files changed, 246 insertions(+), 139 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect

[PATCH v13 02/13] bisect: rewrite `check_term_format` shell function in C

will be introduced for write_terms(). Helped-by: Johannes Schindelein Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 60 +++- git-bisect.sh| 31

Re: [GSOC Update] Week 15

From: Pranit Bauva Subject: [GSOC Update] Week 15 === SUMMARY == My public git.git is available here[1]. I regularly keep pushing my work so anyone interested can track me there. Feel free to participate in the discussions going on PRs with my mentors. Your comments

Re: [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

Hey Christian, On Sat, Aug 13, 2016 at 1:04 PM, Christian Couder wrote: > On Wed, Aug 10, 2016 at 11:57 PM, Pranit Bauva wrote: >> >> @@ -431,6 +434,244 @@ static int bisect_terms(struct bisect_terms *terms, >> const char **argv, int argc) >> return

Re: [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

Hey Junio, On Sat, Aug 13, 2016 at 12:55 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> + ... >> + /* >> + * Write new start state >> + */ >> + if (write_file(git_path_bisect_start(), "%s\n", start_head.buf)) { >

Re: [PATCH v12 11/13] bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Hey Junio, On Sat, Aug 13, 2016 at 12:19 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Pranit Bauva writes: >> >>> +static int bisect_next_check(const struct bisect_terms *terms, >>> + const char *current_term) >>>

[PATCH v12 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/am.c | 20 ++-- cache.h

[PATCH v12 11/13] bisect--helper: `bisect_next_check` & bisect_voc shell function in C

temporary measure to port shell function to C so as to use the existing test suite. As more functions are ported, this subcommand will be retired but its implementation will be called by some other methods. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva

[PATCH v12 09/13] bisect--helper: `bisect_write` shell function in C

pass the memory address around functions. This patch also introduces new methods namely bisect_state_init() and bisect_terms_release() for easy memory management for the struct bisect_terms. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin

Re: [PATCH v12 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

Here[1] is the link for interdiff. Sorry could not send a cover patch or put it in here. I am under a proxy which blocks IMAP/SMTP connections and gmail wraps the lines. [1]: http://paste.ubuntu.com/22794990/ Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscrib

[PATCH v12 05/13] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- I faced this problem while converting `bisect_clean_state` and

[PATCH v12 04/13] bisect--helper: `bisect_clean_state` shell function in C

ported, this subcommand will be retired but its implementation will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 55 +++- git-bisect.sh

[PATCH v12 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

ting test suite. As more functions are ported, this subcommand would be retired but its implementation will be called by some other method. Helped-by: Eric Sunshine Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c

[PATCH v12 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C

are ported, this subcommand will be retired but its implementation will be called by some other methods. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 59 ++-- git-bisect.sh

[PATCH v12 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

d-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 3324229..8111c91 100644 --- a/builtin/bisect

[PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 254 ++- git-bisect.sh| 133 + 2 files changed, 254 insertions(+), 133 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect

[PATCH v12 02/13] bisect: rewrite `check_term_format` shell function in C

will be introduced for write_terms(). Helped-by: Johannes Schindelein Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 60 +++- git-bisect.sh| 31

[PATCH v12 07/13] bisect--helper: `bisect_reset` shell function in C

Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 47 ++- git-bisect.sh| 28 ++-- 2 files changed, 48 insertions(+), 27 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index

[PATCH v12 03/13] bisect--helper: `write_terms` shell function in C

implementation will be called by some other method. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 36 +--- git-bisect.sh| 22 +++--- 2 files changed, 36 insertions(+), 22

[PATCH v12 10/13] bisect--helper: `check_and_set_terms` shell function in C

` and `term_bad` of `struct bisect_terms`. Also introduce set_terms() to copy the `term_good` and `term_bad` into `struct bisect_terms` and write it out to the file BISECT_TERMS. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c

[GSOC Update] Week 113

gards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Thu, Aug 4, 2016 at 10:20 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> Hey Junio, >> >> On Thu, Aug 4, 2016 at 9:15 PM, Junio C Hamano wrote: >>> Pranit Bauva writes: >>> >>>>> Also you do not seem to check the

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Thu, Aug 4, 2016 at 9:15 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >>> Also you do not seem to check the error from the function to smudge >>> the "result" you are returning from this function. >> >> Yes I should combin

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Tue, Aug 2, 2016 at 11:16 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int bisect_clean_state(void) >> +{ >> + int result = 0; >> + >> + /* There may be some refs packed during bisection */ >>

Re: [RFC/PATCH v11 09/13] bisect--helper: `bisect_write` shell function in C

Hey Junio, On Wed, Aug 3, 2016 at 3:47 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Pranit Bauva writes: >> >>> Reimplement the `bisect_write` shell function in C and add a >>> `bisect-write` subcommand to `git bisect--helper` to call it from

Re: [RFC/PATCH v11 09/13] bisect--helper: `bisect_write` shell function in C

Hey Junio, On Wed, Aug 3, 2016 at 1:55 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> Reimplement the `bisect_write` shell function in C and add a >> `bisect-write` subcommand to `git bisect--helper` to call it from >> git-bisect.sh > > Up to around this

Re: [RFC/PATCH v11 13/13] bisect--helper: `bisect_start` shell function partially in C

Hey Junio, On Wed, Aug 3, 2016 at 1:49 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int bisect_start(struct bisect_terms *terms, int no_checkout, >> + const char **argv, int argc) >> +{ >> + int i, j, has_double_dash = 0,

Re: [RFC/PATCH v11 11/13] bisect--helper: `bisect_next_check` shell function in C

Hey Junio, On Wed, Aug 3, 2016 at 12:47 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int mark_good(const char *refname, const struct object_id *oid, >> + int flag, void *cb_data) >> +{ >> + int *m_good = (int *)cb_data; >>

Re: [RFC/PATCH v11 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Hey Junio, On Wed, Aug 3, 2016 at 12:52 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int bisect_terms(struct bisect_terms *terms, int term_defined) >> +{ >> + if (get_terms(terms)) { >> + fprintf(stderr, "no terms defi

Re: [RFC/PATCH v11 10/13] bisect--helper: `check_and_set_terms` shell function in C

Hey Junio, On Wed, Aug 3, 2016 at 12:23 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> Reimplement the `check_and_set_terms` shell function in C and add >> `check-and-set-terms` subcommand to `git bisect--helper` to call it from >> git-bisect.sh >> &

Re: [RFC/PATCH v11 02/13] bisect: rewrite `check_term_format` shell function in C

Hey Junio, On Tue, Aug 2, 2016 at 11:01 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +/* >> + * Check whether the string `term` belongs to the set of strings >> + * included in the variable arguments. >> + */ >> +static int one_of(const char *t

Re: [RFC/PATCH v11 03/13] bisect--helper: `write_terms` shell function in C

Hey Junio, On Tue, Aug 2, 2016 at 11:08 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int write_terms(const char *bad, const char *good) >> +{ >> + FILE *fp; >> + int res; >> + >> + if (!strcmp(bad, good)) >> +

[RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

ported, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 55 +++- git-bisect.sh| 26

[RFC/PATCH v11 13/13] bisect--helper: `bisect_start` shell function partially in C

: Christian Couder Signed-off-by: Pranit Bauva --- This patch contains a small bug. The option handling for `--term-good` and `--term-bad` needs to be decided as it is now shared between `--bisect-terms` and `--bisect-start` and the later one also requires string support. Can comments on which

[RFC/PATCH v11 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

d-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 3324229..8111c91 100644 --- a/builtin/bisect

[RFC/PATCH v11 10/13] bisect--helper: `check_and_set_terms` shell function in C

`struct bisect_terms`. Also introduce set_terms() to copy the `term_good` and `term_bad` into `struct bisect_terms` and write it out to the file BISECT_TERMS. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 52

[RFC/PATCH v11 02/13] bisect: rewrite `check_term_format` shell function in C

for write_terms(). Helped-by: Johannes Schindelein Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 59 +++- git-bisect.sh| 31 ++--- 2 files changed

[RFC/PATCH v11 09/13] bisect--helper: `bisect_write` shell function in C

address around functions. This patch also introduces new methods namely bisect_state_init() and bisect_terms_release() for easy memory management for the struct bisect_terms. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 97

[RFC/PATCH v11 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

ting test suite. As more functions are ported, this subcommand would be retired and will be called by some other method. Helped-by: Eric Sunshine Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c

[RFC/PATCH v11 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 74 +++- git-bisect.sh| 35 ++- 2 files changed, 75 insertions(+), 34 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 71f4cf0

[RFC/PATCH v11 11/13] bisect--helper: `bisect_next_check` shell function in C

hneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 79 +++- git-bisect.sh| 60 +++- 2 files changed, 82 insertions(+), 57 deletions(-) diff --git a/builtin/bisect--helpe

[RFC/PATCH v11 07/13] bisect--helper: `bisect_reset` shell function in C

subcommand would be retired and will be called by some other method. Note: --bisect-clean-state subcommand has not been retired as there are still a function namely `bisect_start()` which still uses this subcommand. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit

[RFC/PATCH v11 03/13] bisect--helper: `write_terms` shell function in C

by some other method. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 36 +--- git-bisect.sh| 22 +++--- 2 files changed, 36 insertions(+), 22 deletions(-) diff --git

[RFC/PATCH v11 05/13] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- I faced this problem while converting `bisect_clean_state` and

[RFC/PATCH v11 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/am.c | 20 ++-- cache.h

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Hey Junio, On Tue, Jul 26, 2016 at 11:02 PM, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> On 07/25/2016 06:53 PM, Junio C Hamano wrote: >>> Pranit Bauva writes: >>> >>>>>> >>> +enum terms_defined { >>

Re: [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Hey Torsten, On Fri, Jul 22, 2016 at 7:59 AM, Torsten Bögershausen wrote: > > > On 07/20/2016 11:47 PM, Pranit Bauva wrote: >> >> Reimplement the `get_terms` and `bisect_terms` shell function in C and >> add `bisect-terms` subcommand to `git bisect--helper` to ca

[PATCH v10 08/12] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

ting test suite. As more functions are ported, this subcommand would be retired and will be called by some other method. Helped-by: Eric Sunshine Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c

[PATCH v10 09/12] bisect--helper: `bisect_write` shell function in C

address around functions. This patch also introduces new methods namely bisect_state_init() and bisect_terms_release() for easy memory management for the struct bisect_terms. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 97

[PATCH v10 07/12] bisect--helper: `bisect_reset` shell function in C

subcommand would be retired and will be called by some other method. Note: --bisect-clean-state subcommand has not been retired as there are still a function namely `bisect_start()` which still uses this subcommand. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit

[PATCH v10 03/12] bisect--helper: `write_terms` shell function in C

by some other method. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 36 +--- git-bisect.sh| 22 +++--- 2 files changed, 36 insertions(+), 22 deletions(-) diff --git

[PATCH v10 02/12] bisect: rewrite `check_term_format` shell function in C

for write_terms(). Helped-by: Johannes Schindelein Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 59 +++- git-bisect.sh| 31 ++--- 2 files changed

[PATCH v10 05/12] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- I faced this problem while converting `bisect_clean_state` and

[PATCH v10 04/12] bisect--helper: `bisect_clean_state` shell function in C

ported, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 55 +++- git-bisect.sh| 26

[PATCH v10 11/12] bisect--helper: `bisect_next_check` shell function in C

hneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 79 +++- git-bisect.sh| 60 +++- 2 files changed, 82 insertions(+), 57 deletions(-) diff --git a/builtin/bisect--helpe

[PATCH v10 10/12] bisect--helper: `check_and_set_terms` shell function in C

`struct bisect_terms`. Also introduce set_terms() to copy the `term_good` and `term_bad` into `struct bisect_terms` and write it out to the file BISECT_TERMS. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 52

[PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 74 +++- git-bisect.sh| 35 ++- 2 files changed, 75 insertions(+), 34 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 001096a

[PATCH v10 01/12] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

d-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 3324229..8111c91 100644 --- a/builtin/bisect

[PATCH v10 06/12] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/am.c | 20 ++-- cache.h

Re: [PATCH 0/9] Resend of gitster/pb/bisect

On Wed, Jul 13, 2016 at 4:05 AM, Pranit Bauva wrote: > Hey Junio, > > A small mistake got unnoticed by me which Lars recently pointed out. > The naming convention is "git_path_" and underscore > instead of spaces. > > Thanks! > > The interdiff is: > diff --

Re: What's cooking in git.git (Jul 2016, #06; Tue, 19)

g right now) then bisect_next(), bisect_replay(), bisect_state(), and a few small more. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[GSOC Update] Week 10

.gmane.org/gmane.comp.version-control.git/298263 [7]: http://thread.gmane.org/gmane.comp.version-control.git/298279 [8]: https://github.com/pranitbauva1997/git/pull/16 Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@

[PATCH 6/9] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/am.c | 20 ++-- cache.h

[PATCH 3/9] bisect--helper: `write_terms` shell function in C

by some other method. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 36 +--- git-bisect.sh| 22 +++--- 2 files changed, 36 insertions(+), 22 deletions(-) diff --git

[PATCH 0/9] Resend of gitster/pb/bisect

erms()); + remove_path(git_path_bisect_terms()); /* Cleanup head-name if it got left by an old version of git-bisect */ remove_path(git_path_head_name()); /* Pranit Bauva (9): bisect--helper: use OPT_CMDMODE instead of OPT_BOOL bisect: rewrite `check_term_format`

[PATCH 9/9] bisect--helper: `bisect_write` shell function in C

address around functions. This patch also introduces new methods namely bisect_state_init() and bisect_terms_release() for easy memory management for the struct bisect_terms. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 97

[PATCH 5/9] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- I faced this problem while converting `bisect_clean_state` and

[PATCH 4/9] bisect--helper: `bisect_clean_state` shell function in C

ported, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 55 +++- git-bisect.sh| 26

[PATCH 2/9] bisect: rewrite `check_term_format` shell function in C

for write_terms(). Helped-by: Johannes Schindelein Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 59 +++- git-bisect.sh| 31 ++--- 2 files changed

[PATCH 1/9] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

d-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 3324229..8111c91 100644 --- a/builtin/bisect

[PATCH 8/9] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

ting test suite. As more functions are ported, this subcommand would be retired and will be called by some other method. Helped-by: Eric Sunshine Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c

[PATCH 7/9] bisect--helper: `bisect_reset` shell function in C

subcommand would be retired and will be called by some other method. Note: --bisect-clean-state subcommand has not been retired as there are still a function namely `bisect_start()` which still uses this subcommand. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit

[PATCH v4 6/6] bisect--helper: `bisect_write` shell function in C

address around functions. This patch also introduces new methods namely bisect_state_init() and bisect_terms_release() for easy memory management for the struct bisect_terms. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 97

[PATCH v4 3/6] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/am.c | 20 ++-- cache.h

[PATCH v4 4/6] bisect--helper: `bisect_reset` shell function in C

subcommand would be retired and will be called by some other method. Note: --bisect-clean-state subcommand has not been retired as there are still a function namely `bisect_start()` which still uses this subcommand. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit

[PATCH v4 2/6] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- I faced this problem while converting `bisect_clean_state` and

[PATCH v4 5/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

ting test suite. As more functions are ported, this subcommand would be retired and will be called by some other method. Helped-by: Eric Sunshine Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c

[PATCH v4 1/6] bisect--helper: `bisect_clean_state` shell function in C

ported, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 55 +++- git-bisect.sh| 26

[PATCH v4 0/6] convert various shell functions in git-bisect to C

res = bisect_write(argv[0], argv[1], &terms, nolog); break; default: die("BUG: unknown subcommand '%d'", cmdmode); } - bisect_terms_release(&state); + bisect_terms_release(&terms); return res; } Pranit Bauva (6): bise

[GSOC Update] Week 9

ion-control.git/298279 [8]: Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] t3404: fix another typo

nsetting SHELL avoids such non-portable behavior > # in tests. It must be exported for it to take effect where needed. The change introduces fixed the grammo properly but the commit message probably reports it incorrectly. Would it be better if the commit message is without changing anything els

[GSOC Update] Week 8

e.org/gmane.comp.version-control.git/297266 [5]: http://thread.gmane.org/gmane.comp.version-control.git/295518 [6]: http://thread.gmane.org/gmane.comp.version-control.git/298263 [7]: http://thread.gmane.org/gmane.comp.version-control.git/298279 Regards, Pranit Bauva -- To unsubscribe from this list:

[RFC/PATCH 2/3] bisect--helper: `bisect_next_check` shell function in C

, this subcommand will be retired and will be called by some other methods. bisect_voc() is removed as it is redundant and does not serve any useful purpose. We are better off specifying "bad|new" "good|old" as and when we require in bisect_next_check(). Signed-off-by: Pranit Bauva

[RFC/PATCH 3/3] bisect--helper: `get_terms` & `bisect_terms` shell function in C

are ported, this subcommand will be retired and will be called by some other methods. Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 49 +++- git-bisect.sh| 35 ++ 2

[RFC/PATCH 1/3] bisect--helper: `check_and_set_terms` shell function in C

and allocate new memory for it thus flushing out the previous contents. Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- This series applies on top of my previous patch series[1]. [1]: http://thread.gmane.org/gmane.comp.version-control.git/298263 builtin/bisect--helper.c | 53

[PATCH v3 5/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

ting test suite. As more functions are ported, this subcommand would be retired and will be called by some other method. Helped-by: Eric Sunshine Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c

[PATCH v3 4/6] bisect--helper: `bisect_reset` shell function in C

subcommand would be retired and will be called by some other method. Note: --bisect-clean-state subcommand has not been retired as there are still a function namely `bisect_start()` which still uses this subcommand. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit

[PATCH v3 6/6] bisect--helper: `bisect_write` shell function in C

address around functions. This patch also introduces new methods namely bisect_state_init() and bisect_state_release() for easy memory management for the struct bisect_state. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 99

[PATCH v3 3/6] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/am.c | 20 ++-- cache.h

[PATCH v3 2/6] t6030: explicitly test for bisection cleanup

This is not an improvement in the test coverage but it helps in making it explicit as to what exactly would be the error as other tests are focussed on testing other things. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- I faced this problem while

[PATCH v3 1/6] bisect--helper: `bisect_clean_state` shell function in C

ported, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- builtin/bisect--helper.c | 55 +++- git-bisect.sh| 26

[PATCH v3 0/6] convert various shell functions in git-bisect to C

is_empty_file(const char *filename); +extern int is_empty_or_missing_file(const char *filename); #endif /* CACHE_H */ diff --git a/wrapper.c b/wrapper.c index 36a3eeb..e70e4d1 100644 --- a/wrapper.c +++ b/wrapper.c @@ -697,14 +697,14 @@ void sleep_millisec(int millisec) poll(NULL, 0, millisec);

[GSOC Update] Week 7

. [1]: https://github.com/pranitbauva1997/git [2]: http://thread.gmane.org/gmane.comp.version-control.git/297520 [3]: https://github.com/pranitbauva1997/git/pull/17 [4]: http://thread.gmane.org/gmane.comp.version-control.git/297266 Regards, Pranit Bauva -- To unsubscribe from this list: send the

[RFC/PATCH] bisect--helper: `check_and_set_terms` shell function in C

. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- Collecting reviews. This patch is based on my previous series. I will also include this the next time I reroll the series. builtin/bisect--helper.c | 44 +++- git

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

than setting up a coverage tool for shell scripts. [1]: http://thread.gmane.org/gmane.comp.version-control.git/295518 Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 6/6] bisect--helper: `bisect_write` shell function in C

Hey Christian, On Fri, Jun 17, 2016 at 2:08 AM, Christian Couder wrote: > On Thu, Jun 16, 2016 at 9:01 PM, Pranit Bauva wrote: >> Hey Eric, >> >> On Fri, Jun 17, 2016 at 12:25 AM, Eric Sunshine >> wrote: >>> On Wed, Jun 15, 2016 at 10:00 AM, Pran

<    1   2   3   4   5   6   7   >