On 01/10/15 18:05, Stefan Beller wrote:
> On Thu, Oct 1, 2015 at 5:02 AM, Ramsay Jones
> <ram...@ramsayjones.plus.com> wrote:
>>
[snip]
>> diff --git a/run-command.c b/run-command.c
>> index 341b23b..347d22e 100644
>> --- a/run-command.c
>> +++
git' version which would work on MinGW, cygwin and
linux. Note that some of the existing implementations didn't all agree on
what the tests should report! I don't remember if I looked at the POSIX
spec or not.
So, I don't know how useful it will be - if nothing else, there are some
tests! :-D
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com>
---
Hi Stefan,
When you next re-roll the patches for your
'sb/submodule-parallel-fetch' branch, could you please squash
parts of this into the relevant patches. [which would correspond
to commits a93fb7a ("run-c
Commits 9c0b9f6 ("worktree: add 'list' command", 18-09-2015) and
40ca3d3 ("worktree: add functions to get worktree details", 18-08-2015)
both introduce the use of a C99 feature (declare the loop control
variable in the loop header initializer section).
Signed-off-b
R;
> mode = 0100666;
> - strcpy(header.name, "pax_global_header");
> + xsnprintf(header.name, sizeof(header.name), "pax_global_header");
How about using strlcpy() instead? Thus:
- strcpy(header.name, "pax_global_header");
+ str
_XX");
> return mkstemp(path);
> } else {
> return create_file(path, !symlink ? ce->ce_mode : 0666);
Hmm, I was going to suggest strlcpy() again. However, if you expect an overflow
to
occur, then xsnprintf() will at least bring it to you
On 15/09/15 19:42, Jeff King wrote:
> On Tue, Sep 15, 2015 at 07:32:29PM +0100, Ramsay Jones wrote:
>
>>> diff --git a/archive-tar.c b/archive-tar.c
>>> index b6b30bb..d543f93 100644
>>> --- a/archive-tar.c
>>> +++ b/archive-tar.c
>>> @@ -301,
I haven't read any other patches yet (including those which use these
new '_to' functions), but I can't help feeling they should be named something
like 'sha1_to_hex_str()' and 'find_unique_abbrev_str()' instead. i.e. I don't
get
the '_to' thing - not that I'm any good at naming things ...
ATB,
Rams
On 07/09/15 13:31, Gábor Bernát wrote:
> From: Gabor Bernat <gabor.ber...@gravityrd.com>
>
> adds seconds progress and estimated seconds time if getting the current
> timestamp is supported by the date %+s command
s/%+s/+%s/
ATB,
Ramsay Jones
--
To unsubscribe from this l
Hi Johannes,
On 01/09/15 17:11, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On 2015-09-01 17:50, Ramsay Jones wrote:
>
>> diff --git a/.mailmap b/.mailmap
>> index ece2951..e5b4126 100644
>> --- a/.mailmap
>> +++ b/.mailmap
>> @@ -186,7 +186
Jones <ram...@ramsayjones.plus.com>
---
Hi Junio,
So, my home move caused a (reluctant) change in ISP too. :(
This, in turn, left me without any internet access for just over
three weeks; I was climbing the walls!
ATB,
Ramsay Jones
.mailmap | 2 +-
1 file changed, 1 insertion(+), 1 de
file local to external.
In order to revert the visibility of the symbol to file local, add
the static modifier to the declaration of 'common_list'.
Noticed by sparse (symbol 'common_list' was not declared. Should it
be static?).
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com>
---
Hi Dav
On 06/08/15 10:53, Ramsay Jones wrote:
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
Sorry for this hit-n-run patch, but I'm in a hurry ... :-D
Could you please squash this (or something like it) into
the relevant patch; Thanks!
Ah, I've just read your 'What's
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
Sorry for this hit-n-run patch, but I'm in a hurry ... :-D
Could you please squash this (or something like it) into
the relevant patch; Thanks!
[I noticed this simply because I have '-Wdeclaration-after-statement
run (IIUC). The last significant commit was 74cf9bd (engine.pl: Fix a
recent breakage of the buildsystem generator, 2010-01-22) Ramsay Jones,
so that's five and a half years.
I think Ramsay is still around on the list; I do not know if he
still does Windows, though.
[Sorry for not noticing
[...]
Helped-by: Eric Sunshine sunsh...@sunshineco.com
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
This should be (at most) 'Helped-by:' - my 'contribution' was
so minor that even a 'Helped-by:' is generous! :-D
ATB,
Ramsay Jones
Signed-off-by: Sébastien Guimmara sebastien.guimm
by callers (ie that the
parameter points to an _unitialized_ strbuf), a better solution
is to simply call the 'strbuf_init' function.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi David,
If you need to re-roll the patches in your 'dt/cat-file-follow-symlinks'
branch, could you please
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
This test recently started failing for me. I haven't heard anyone
else complaining about this, so maybe I should look into why my
environment may be different to everyone else ... :-D (when I can
find some time, of course
(or the funcname regex regex) within the file. You may
perhaps this should read the same as the hunk below, namely:
(or the funcname regex funcname) ...
[I haven't actually given it any thought, I just noticed the difference ...]
Thanks!
ATB,
Ramsay Jones
not give any pathspec limiters
qualifier to the function definition.
[An alternative solution, if this symbol should have external scope,
is to add an external declaration for the function to the cache.h
header file (next to the one for parse_sha1_header()).]
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Karthik
, socklist);
#else
...
#endif
Or, ... ;-)
ATB,
Ramsay Jones
if (socklist.nr == 0)
die(unable to allocate any listen sockets on port %u,
listen_port);
@@ -1196,7 +1216,7 @@ int main(int argc, char **argv)
{
int listen_port = 0
was skimming the email.
[So, if this is actually correct, sorry for the noise!]
ATB,
Ramsay Jones
+ d2 = noindex_filespec(NULL, 0);
+ name1 = NULL;
+ mode1 = 0;
+ }
+ /* emit that file
(Fix an implicit function
definition warning, 03-03-2007).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
I have a very vague recollection (back in March 2007) of trying to fix
the problem from commit 41b20017 using the solution in commit 3a0a3a89.
However, I can't remember
to the bikeshed, but ...
This sounds odd to me, so maybe:
--author '%s' is neither in the form of 'Name email' nor a match for an
existing author
although that is getting a bit long! :-D
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body
ULIMIT_FILE_DESCRIPTORS 'large transaction deleting
branches does not burst open file limit' '
(
for i in $(test_seq 33)
do
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
).
As for the fix, would it be sufficient to check != NULL instead of 0?
Hmm, I didn't give it any thought, but don't you want that to be '== NULL'?
(you don't want to use a NULL lock-lk-fp in the following fprintf()).
Or simply '!fdopen_lock_file(lock-lk, w)' I suppose.
ATB,
Ramsay Jones
On 22/01/15 19:51, Ramsay Jones wrote:
On 22/01/15 19:16, Stefan Beller wrote:
How do you run sparse on git?
$ make sparse sp-out 21
BTW, you can get gcc to warn about this also:
$ rm refs.o
$ make CFLAGS='-Wall -Wextra' refs.o
* new build flags
CC refs.o
In file included from
On 22/01/15 20:20, Stefan Beller wrote:
On Thu, Jan 22, 2015 at 12:13 PM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Notice the [-Wextra] warnings above. ;-)
ATB,
Ramsay Jones
Thanks, I put that into my config.mak
Though recompiling the whole project yields
4 [-Wempty-body
), for a counter-point. :-P
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
codebase). Also, it triggers a warning from
sparse. In order to suppress the warning, simply remove the
extern keyword from reflog_expire() definition.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Michael,
If you need to re-roll your 'mh/reflog-expire' series, could you
please squash
to this commit, to now (unexpectedly) pass. Mark this test as
passing.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
I noticed this last week while testing on cygwin. I have only tested
this on (64-bit) cygwin/ntfs, but I would assume that other case
insensitive filesystems
On 24/11/14 07:20, Torsten Bögershausen wrote:
On 2014-11-24 00.15, Ramsay Jones wrote:
On 23/11/14 18:53, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
On 23/11/14 14:16, Torsten Bögershausen wrote:
gcc under cygwin reports several warnings like this:
warning
with gcc v4.8.3-5 x86-64
Do not #define _XOPEN_SOURCE 600 for CYGWIN.
Reported-by: Ramsay Jones ram...@ramsay1.demon.co.uk
Signed-off-by: Torsten Bögershausen tbo...@web.de
---
This may be a start for a patch, tested under CYGWIN-32,
both Windows7 and XP
The tested under part would also
On 23/11/14 23:15, Ramsay Jones wrote:
On 23/11/14 18:53, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
On 23/11/14 14:16, Torsten Bögershausen wrote:
gcc under cygwin reports several warnings like this:
warning: implicit declaration of function 'memmem
On 24/11/14 21:44, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
I updated from cygwin 1.5 to cygwin 1.7 at the beginning of the year.
Since it is no longer supported, I don't think we need to worry about
version 1.5. When I said 'old installation' I meant my old
On 24/11/14 22:50, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
...
Although I have not done an actual diff of the various cdef.h files, they
do appear to be more or less the same. In other words, I no longer think
that the change results from a 'change in priority
installation
(about 6 months) but I'm a little surprised you found this issue
with gcc 4.7.3 (I'm _almost_ tempted to boot that laptop anyway
just to see what versions of software it is running).
Just for the reccord, my patch follows.
ATB,
Ramsay Jones
Do not #define _XOPEN_SOURCE 600
the _XOPEN_SOURCE
macro on cygwin
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
git-compat-util.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 400e921..cef2691 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -75,7
On 23/11/14 18:13, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
Just a quick heads-up on a recent cygwin breakage.
I updated my (64-bit) cygwin installation yesterday and (along
with many other packages) I noticed a new version of gcc (and
presumably libc
On 23/11/14 18:53, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
On 23/11/14 14:16, Torsten Bögershausen wrote:
gcc under cygwin reports several warnings like this:
warning: implicit declaration of function 'memmem'
[-Wimplicit-function-declaration]
This has been
(or a bug), but I couldn't see any mention
of this on the cygwin mailing list. (I don't intend to report this
to that mailing list; I don't want to subscribe to (yet another)
busy list). :(
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message
.
ATB,
Ramsay Jones
---
Documentation/git-imap-send.txt | 15 +++-
INSTALL | 15 ++--
Makefile| 18 +++-
imap-send.c | 176
++--
4 files changed, 187 insertions(+), 37 deletions
use the same
solution used in commit 9371322a6 (sparse: suppress some using
sizeof on a function warnings, 06-10-2013) which solved exactly
this problem for the other commands using libcurl.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Bernhard,
If you need to re-roll your 'br
Commit b74884b86 (untracked cache: make a wrapper around
{open,read,close}dir(), 27-10-2014) added the read_cached_dir()
function as an external symbol.
Noticed by sparse. ('read_cached_dir' was not declared. Should it
be static?).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi
Commit 8796e182 (receive-pack.c: use a single transaction when
atomic-push is negotiated, 21-10-2014) added the 'transaction'
and 'err' variables as external symbols.
Noticed by sparse. ('err' was not declared. Should it be static?)
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi
On 19/10/14 02:36, Jeff King wrote:
On Sat, Oct 18, 2014 at 10:36:12PM +0100, Ramsay Jones wrote:
I noticed that your 'jk/prune-mtime' branch removes the last caller
of the add_object() function; specifically commit 5f78a431a
(reachable: use traverse_commit_list instead of custom walk, 15-10
On 19/10/14 03:03, Jeff King wrote:
On Sun, Oct 19, 2014 at 12:19:07AM +0100, Ramsay Jones wrote:
[snip]
I actually wondered while writing this series whether anyone actually
_uses_ the mode in object_array (the new code I added sets it to the
appropriate value to be on the safe side
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
I noticed that your 'jk/prune-mtime' branch removes the last caller
of the add_object() function; specifically commit 5f78a431a
(reachable: use traverse_commit_list instead of custom walk, 15-10-2014).
If you need to re-roll
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
I noticed that your 'jk/prune-mtime' branch also removes the only
call to the add_object_array_with_mode() function outside of the
object.c file; specifically commit 75ac69fa (traverse_commit_list:
support pending blobs/trees
a
sparse warning), rather than add an extern declaration to cache.h (which would
also suppress sparse).
ATB,
Ramsay Jones
+{
+uint32_t i;
+int r = 0;
+
+for (i = 0; i p-num_objects; i++) {
+const unsigned char *sha1 = nth_packed_object_sha1(p, i);
+
+if (!sha1
within a conditional such that !log_all_ref_updates is true, so
that the above can be simplified!)
I guess 'create_reflog' should be called 'maybe_create_reflog' :-D
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
? Unless you also change each '.c' file which
includes cache.h to also include git-compat-util.h first, then I suspect
(if nothing else) file I/O may be broken. (see _FILE_OFFSET_BITS).
Also, see Documentation/CodingGuidelines (lines 331-333).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send
that the bug is still
present?
For example, if I anonymized git.git, and did 'git branch -v' (say), how
easy would it be for me to recognise which branch was 'next'?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More
/
format it into a temporary buffer and copy it to the final
flex-array).
Signed-off-by: Jeff King p...@peff.net
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
in these
two examples, I'm inclined to give up this line of inquiry.
Indeed. :-D
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26/08/14 13:14, Jeff King wrote:
On Tue, Aug 26, 2014 at 12:57:21PM +0100, Ramsay Jones wrote:
+ ret = xcalloc(1, base + extra);
+ va_start(ap, fmt);
+ vsnprintf(ret + offset, extra, fmt, ap);
What is the relationship between 'base' and 'offset'?
Let me assume that base
On 26/08/14 13:43, Jeff King wrote:
On Tue, Aug 26, 2014 at 01:37:44PM +0100, Ramsay Jones wrote:
On my 64-bit system using gcc, sizeof() returns 16; it has to pad the
whole thing to 64-bit alignment in case I put two of them in an array.
But offsetof(name) is 12, since the array of char
On 25/08/14 02:54, tsuna wrote:
On Sun, Aug 24, 2014 at 5:32 PM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Again, I don't have access to an OS X system, so I don't know
which package provides libintl/gettext, but it seems to be missing
on your system.
Probably yeah, those libraries
on this).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24/08/14 12:13, tsuna wrote:
On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Hmm, which version of OS X are we talking about?
OS X 10.9.4:
$ uname -a
Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun 3
21:27:35 PDT 2014; root:xnu
On 24/08/14 22:09, tsuna wrote:
On Sun, Aug 24, 2014 at 12:49 PM, Torsten Bögershausen tbo...@web.de wrote:
On 2014-08-24 18.18, Ramsay Jones wrote:
On 24/08/14 12:13, tsuna wrote:
On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Hmm, which version of OS X
upgraded to Linux Mint 17 since
then, so my toolchain may be up to the job now, so perhaps I should
build it myself. ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On 10/08/14 18:29, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
On 08/08/14 15:07, Tanay Abhra wrote:
...
(cc to Ramsay)
The discussion in both threads (v8 and v9), boils down to this,
is the `key_value_info` struct really required to be declared public
which introduces the
struct in cache.h does not make use of that struct in any interface.
It *is* an implementation detail of some code in config.c only.
I do not know how that structure will be used in future patches. ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe
the declaration in config.c until it is needed.
(To make it easier to see if it is necessary in the context of the
patch which will make use of it).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info
git_config_get_pathname(const char *key, const char **dest);
+struct key_value_info {
+ const char *filename;
+ int linenr;
+};
+
Hmm, why was this moved here? As far as I can tell, it is
(still) not needed outside of config.c. What am I missing?
ATB,
Ramsay Jones
Suppress the sparse errors by adding NORETURN to the function
declarations in the cache.h header file.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Tanay,
If you need to re-roll the patches in the 'ta/config-set-1' branch,
could you please squash this into the relevant patch. Thanks
caught and fixed already
but there might remain some more still; please test and report if
you find any.
This has been removed.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info
else (mainly UI related variables).
However, something else came up ...
Just an FYI.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
: Tue Jun 10 17:43:02 2014 -0400
commit: convert commit-buffer to a slab
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
so easy.
However, I think it you could create a list of pointer to hash-table
entry, string-list index pairs in the config_set and use that to do
the iteration. A bit ugly, but it should work.
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body
by
sparse, in the #if conditional already used to guard the code.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
I've been sitting on this patch for some time, while I try to
gauge how long it would take to fix sparse to cope with this
vectorised code. Unfortunately, it would
absolute_path() and using the result
to take the lock, storing it in the lock_file list, should not be
in the critical path, right? Not that I have measured it, of course! :)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
On 21/07/14 12:12, Tanay Abhra wrote:
Use `git_config_get_string()` instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
The function now raises an error instead of dying when a NULL value is found.
Signed-off-by: Tanay Abhra
up here.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21/07/14 14:47, Duy Nguyen wrote:
On Mon, Jul 21, 2014 at 8:27 PM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
+void make_locked_paths_absolute(void)
+{
+ struct lock_file *lk;
+ for (lk = lock_file_list; lk != NULL; lk = lk-next) {
+ if (lk-filename
On 14/07/14 06:57, Jeff King wrote:
On Sun, Jul 13, 2014 at 08:27:51PM +0100, Ramsay Jones wrote:
Thinking on this more, writing out the definitions is the only sane
thing to do here, now that alloc_commit_node does not use the macro.
Otherwise you are inviting people to modify the macro
on a possible problem.
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14/07/14 18:51, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
that the merge commit 7608c87e fails. Looking at the details of the
merge resolution, made me think of Duy's split index work.
Yes, there is a deliberately dropped hunk from dt/cache-tree-repair
]: parse_object_buffer: do not set object type
[5/8]: add object_as_type helper for casting objects
[6/8]: alloc: factor out commit index
[7/8]: object_as_type: set commit index
[8/8]: diff-tree: avoid lookup_unknown_object
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe
?
Or, if that's too verbose, maybe just: flag-type, type-node?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, alloc_tree_node());
+ return create_object(sha1, alloc_tree_node());
if (!obj-type)
obj-type = OBJ_TREE;
if (obj-type != OBJ_TREE) {
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
On 11/07/14 09:32, Jeff King wrote:
On Fri, Jul 11, 2014 at 01:59:53AM +0100, Ramsay Jones wrote:
The code you're touching here was trying to make sure that each commit
gets a unique index, under the assumption that commits only get
allocated via alloc_commit_node. But I think
are entering a realm of portability problems with older
compilers (I even saw one compiler's documentation claim that const
was forbidden on bitfields, even though C99 has an example which does
it).
Yes, I've come across such compilers too; I wouldn't go there! ;-P
ATB,
Ramsay Jones
(struct tree *item, void *buffer, unsigned long size)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
into
the first patch. (NOTE: I assume that you want c-index to start at
zero; if not ...)
ATB,
Ramsay Jones
Ramsay Allan Jones (2):
alloc.c: remove the alloc_raw_commit_node() function
alloc.c: remove the redundant commit_count variable
alloc.c | 50
() allocator, rather than the
intermediary allocator, which can now be removed.
Noticed by sparse (symbol 'alloc_raw_commit_node' was not declared.
Should it be static?).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
alloc.c | 47 +--
1 file
The 'commit_count' static variable is used in alloc_commit_node()
to set the 'index' field of the commit structure to a unique value.
This variable assumes the same value as the 'count' field of the
'commit_state' allocator state structure, which may be used in its
place.
Signed-off-by: Ramsay
On 11/07/14 01:09, Jeff King wrote:
On Fri, Jul 11, 2014 at 12:58:31AM +0100, Ramsay Jones wrote:
#define DEFINE_ALLOCATOR(name, type)\
-static unsigned int name##_allocs; \
+static struct alloc_state name##_state
On 11/07/14 01:30, Jeff King wrote:
On Fri, Jul 11, 2014 at 12:59:48AM +0100, Ramsay Jones wrote:
The 'commit_count' static variable is used in alloc_commit_node()
to set the 'index' field of the commit structure to a unique value.
This variable assumes the same value as the 'count' field
to fchmod() above are on config lock files, one
in git_config_set_multivar_in_file() and the other in
git_config_rename_section_in_file().
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 08/07/14 21:25, Ramsay Jones wrote:
On 08/07/14 20:34, Jens Lehmann wrote:
Am 07.07.2014 21:40, schrieb Torsten Bögershausen:
On 2014-07-07 19.05, Junio C Hamano wrote:
Jens Lehmann jens.lehm...@web.de writes:
Junio, do you want me to resend 02/14 without the non-portable echo -n
squint at the code, but at first
glance it looks good.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
for each bit-field. Note that the C
standard says that using anything other than _Bool, signed int
and unsigned int for the type of a bit-field is implementation
defined. (In addition, the signed-ness of the 'char' type is also
implementation defined).
Signed-off-by: Ramsay Jones ram...@ramsay1
On 23/06/14 17:20, Tanay Abhra wrote:
On 06/23/2014 07:57 AM, Ramsay Jones wrote:
On 23/06/14 11:11, Tanay Abhra wrote:
[snip]
+static struct hashmap *get_config_cache(void)
+{
+ static struct hashmap config_cache;
+ if (!hashmap_initialized) {
+ config_cache_init
On 24/06/14 00:25, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
+static struct hashmap *get_config_cache(void)
+{
+ static struct hashmap config_cache;
+ if (!hashmap_initialized) {
+ config_cache_init(config_cache);
+ hashmap_initialized
== NULL) {
+ value = BOOLEAN_NULL;
+ *boolean_null_flag = 1;
+ }
+ item = string_list_append(e-value_list, value);
+ item-util = boolean_null_flag;
+
+ return 0;
+}
+
[snip]
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line
On 19/06/14 10:19, Jeff King wrote:
On Wed, Jun 18, 2014 at 11:30:50PM +0100, Ramsay Jones wrote:
So, the patch below is a slight variation on the original patch.
I'm still slightly concerned about portability, but given that it
has been at least a decade since I last used a (pre-ANSI
601 - 700 of 940 matches
Mail list logo
