Re: Looking for help to understand external filter driver code

On 19 Jul 2016, at 20:53, Junio C Hamano wrote: > Junio C Hamano writes: > >> The key benefit of this arrangement is the above can be done without >> having to do poll() to flip between reading and writing that is >> needed to avoid deadlocking, which

Current state of Git worktree used with submodules?

Hi, some time ago Michael wrote in a blog post [1]: "It's not recommended to use git worktree with a repository that contains submodules." Plus "Documentation/git-worktree.txt" states: "Multiple checkout in general is still experimental, and the support for submodules is incomplete. It is NOT

Re: Looking for help to understand external filter driver code

> On 20 Jul 2016, at 10:59, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 2016-07-19 o 23:33, Junio C Hamano pisze: >> Lars Schneider <larsxschnei...@gmail.com> writes: >> >>>> Git writes --> 4 byte filename length >>>> Git write

Re: What's cooking in git.git (Jul 2016, #06; Tue, 19)

On 20 Jul 2016, at 00:54, Junio C Hamano wrote: > > [New Topics] > > ... > > * jk/push-scrub-url (2016-07-14) 1 commit > (merged to 'next' on 2016-07-19 at 6ada3f1) > + push: anonymize URL in status output > > "git fetch http://user:pass@host/repo...; scrubbed the

Re: What's cooking in git.git (Jul 2016, #05; Wed, 13)

> On 16 Jul 2016, at 23:04, Eric Wong <e...@80x24.org> wrote: > > Lars Schneider <larsxschnei...@gmail.com> wrote: >>> On 13 Jul 2016, at 18:56, Junio C Hamano <gits...@pobox.com> wrote: >>> * ew/http-walker (2016-07-12) 3 commits >>>

Re: What's cooking in git.git (Jul 2016, #05; Wed, 13)

> On 13 Jul 2016, at 18:56, Junio C Hamano wrote: > ... > > * ew/http-walker (2016-07-12) 3 commits > - http-walker: reduce O(n) ops with doubly-linked list > - http: avoid disconnecting on 404s for loose objects > - http-walker: remove unused parameter from fetch_object >

Re: Plugin mechanism(s) for Git?

> On 15 Jul 2016, at 08:46, Christian Couder wrote: > > [...] > > The current topics/work I can think of are: > > - the ref backend work by Michael based on Ronnie Sahlberg's and others' work, > - the smudge/clean filters work by Joey and Lars, > - the

Re: [RFC] Native access to Git LFS cache

> On 28 Jun 2016, at 15:14, Johannes Schindelin > wrote: > > Hi Duy, > > On Tue, 28 Jun 2016, Duy Nguyen wrote: > >> On Tue, Jun 28, 2016 at 11:40 AM, Johannes Schindelin >> wrote: >>> >>> On Mon, 27 Jun 2016, Duy Nguyen wrote: >>>

Re: [RFC] Native access to Git LFS cache

> On 27 Jun 2016, at 18:09, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> Unfortunately that fix helps only with cloning. Any local Git operation >> that invokes the clean/smudge filter (e.g. switching branches) is still >> slow. > > Do you know where the

Re: Designing the filter process protocol (was: Re: [PATCH v3 10/10] convert: add filter..process option)

> On 03 Aug 2016, at 20:30, Jakub Narębski wrote: > > The ultimate goal is to be able to run filter drivers faster for both `clean` > and `smudge` operations. This is done by starting filter driver once per > git command invocation, instead of once per file being processed.

Re: [PATCH v3 03/10] pkt-line: add packet_flush_gentle()

> On 02 Aug 2016, at 21:56, Torsten Bögershausen <tbo...@web.de> wrote: > > On Sun, Jul 31, 2016 at 11:45:08PM +0200, Lars Schneider wrote: >> >>> On 31 Jul 2016, at 22:36, Torstem Bögershausen <tbo...@web.de> wrote: >>> >>> >>>

Re: [PATCH v4 01/12] pkt-line: extract set_packet_header()

> On 04 Aug 2016, at 18:14, Junio C Hamano wrote: > > Jeff King writes: > >> The cost of write() may vary on other platforms, but the cost of memcpy >> generally shouldn't. So I'm inclined to say that it is not really worth >> micro-optimizing the interface.

Re: [PATCH v3 01/10] pkt-line: extract set_packet_header()

> On 03 Aug 2016, at 22:05, Jakub Narębski <jna...@gmail.com> wrote: > > [This response might have been invalidated by v4] > > W dniu 01.08.2016 o 13:33, Lars Schneider pisze: >>> On 30 Jul 2016, at 12:30, Jakub Narębski <jna...@gmail.com> wrote: >

Re: [PATCH v3 02/10] pkt-line: add direct_packet_write() and direct_packet_write_data()

> On 03 Aug 2016, at 22:12, Jakub Narębski <jna...@gmail.com> wrote: > > [This response might have been invalidated by v4] > > W dniu 01.08.2016 o 14:00, Lars Schneider pisze: >>> On 30 Jul 2016, at 12:49, Jakub Narębski <jna...@gmail.com> wrote: >&g

Re: [PATCH v4 11/12] convert: add filter..process option

> On 04 Aug 2016, at 00:46, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 03, 2016 at 11:48:00PM +0200, Lars Schneider wrote: > >> OK. Is this the v2 discussion you are referring to? >> http://public-inbox.org/git/1461972887-22100-1-git-send-email-sbeller%40goo

Re: [PATCH v4 07/12] run-command: add clean_on_exit_handler

> On 04 Aug 2016, at 01:15, Jeff King <p...@peff.net> wrote: > > On Thu, Aug 04, 2016 at 01:09:57AM +0200, Lars Schneider wrote: > >>> Or better yet, do not require a shutdown at all. The filter sees EOF and >>> knows there is nothing more to do. If we a

Re: [PATCH v3 10/10] convert: add filter..process option

> On 04 Aug 2016, at 12:18, Jakub Narębski wrote: > > ... + + sigchain_push(SIGPIPE, SIG_IGN); >>> >>> Hmmm... ignoring SIGPIPE was good for one-shot filters. Is it still >>> O.K. for per-command persistent ones? >> >> Very good question. You are right... we

Re: [PATCH v4 11/12] convert: add filter..process option

> On 05 Aug 2016, at 23:34, Torsten Bögershausen wrote: > > On 2016-08-03 18.42, larsxschnei...@gmail.com wrote: >> The filter is expected to respond with the result content in zero >> or more pkt-line packets and a flush packet at the end. Finally, a >> "result=success" packet

Re: [PATCH v4 07/12] run-command: add clean_on_exit_handler

> On 05 Aug 2016, at 23:19, Torsten Bögershausen <tbo...@web.de> wrote: > > On 2016-08-05 15.08, Lars Schneider wrote: > > [] >> Yeah it could do that. But then the filter cannot do things like >> modifying the index after the fact... however, that might

Re: [PATCH v4 11/12] convert: add filter..process option

> On 08 Aug 2016, at 17:02, Jeff King <p...@peff.net> wrote: > > On Sat, Aug 06, 2016 at 08:19:28PM +0200, Lars Schneider wrote: > >>> I dunno. It's not _that_ big a deal to code around. I was just surprised >>> not to see an up-front status when respon

Re: [PATCH v2 5/5] convert: add filter..process option

> On 05 Aug 2016, at 20:55, Eric Wong <e...@80x24.org> wrote: > > Lars Schneider <larsxschnei...@gmail.com> wrote: >>> On 27 Jul 2016, at 11:41, Eric Wong <e...@80x24.org> wrote: >>> larsxschnei...@gmail.com wrote: >>>> +static in

Re: Designing the filter process protocol (was: Re: [PATCH v3 10/10] convert: add filter..process option)

> On 03 Aug 2016, at 20:30, Jakub Narębski wrote: > > ... > > > 2. HANDSHAKE (INITIALIZATION) > > Next, there is deciding on and designing the handshake between Git (between > Git command) and the filter driver process. With the > `filter..process` > solution the driver

Re: [PATCH v4 11/12] convert: add filter..process option

> On 06 Aug 2016, at 00:27, Jeff King wrote: > > On Fri, Aug 05, 2016 at 03:06:28PM -0700, Junio C Hamano wrote: > >> Torsten Bögershausen writes: >> >>> On 2016-08-03 18.42, larsxschnei...@gmail.com wrote: The filter is expected to respond with the result

Re: [PATCH v4 11/12] convert: add filter..process option

> On 06 Aug 2016, at 14:14, Jeff King <p...@peff.net> wrote: > > On Sat, Aug 06, 2016 at 01:55:23PM +0200, Lars Schneider wrote: > >>> And I expect it makes the lives of the client >>> easier to get a code up front, before it starts taking steps to han

Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors

> On 06 Aug 2016, at 10:58, Johannes Schindelin > wrote: > > Hi Stefan, > > just quickly (i.e. addressing only one point, will try to address more at > a later date) because I want to be mostly offline this weekend: > > On Fri, 5 Aug 2016, Stefan Beller wrote: >

Re: [PATCH v3 06/10] run-command: add clean_on_exit_handler

> On 02 Aug 2016, at 07:53, Johannes Sixt <j...@kdbg.org> wrote: > > Am 01.08.2016 um 13:14 schrieb Lars Schneider: > >> On 30 Jul 2016, at 11:50, Johannes Sixt <j...@kdbg.org> wrote: > >> Am 30.07.2016 um 01:37 schrieb larsxschnei...@gmail.

Re: [PATCH v2 0/5] Git filter protocol

> On 29 Jul 2016, at 17:57, Jeff King <p...@peff.net> wrote: > > On Fri, Jul 29, 2016 at 10:14:17AM +0200, Lars Schneider wrote: > >> My current implementation supports only two cases. Either the filter >> knows the size and sends it back. Or the filter doesn't

Re: [PATCH v2 0/5] Git filter protocol

> On 29 Jul 2016, at 18:50, Jeff King <p...@peff.net> wrote: > > On Fri, Jul 29, 2016 at 06:20:51PM +0200, Lars Schneider wrote: > >>>> That being said a "fail" response is a very good idea! This allows >>>> the filter to communicate to g

Re: [PATCH v3 10/10] convert: add filter..process option

> On 01 Aug 2016, at 00:19, Jakub Narębski wrote: > > W dniu 30.07.2016 o 01:38, larsxschnei...@gmail.com pisze: > [LONG SNIP] First part answered here: http://public-inbox.org/git/5180D54D-92C4-4875-AEB3-801663D70A8B%40gmail.com/ > >> +} >> +process = >process;

Re: [PATCH v4 11/12] convert: add filter..process option

> On 03 Aug 2016, at 22:29, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> +#define FILTER_CAPABILITIES_CLEAN(1u<<0) >> +#define FILTER_CAPABILITIES_SMUDGE (1u<<1) >> +#define FILTER_SUPPORTS_CLEAN(type) ((type) & FILTER_CAPABILITIES_CLEAN) >>

Re: [PATCH v4 07/12] run-command: add clean_on_exit_handler

> On 03 Aug 2016, at 23:24, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 03, 2016 at 06:42:20PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Some commands might need to perform cleanup task

Re: [PATCH v4 07/12] run-command: add clean_on_exit_handler

> On 04 Aug 2016, at 00:53, Jeff King <p...@peff.net> wrote: > > On Thu, Aug 04, 2016 at 12:15:46AM +0200, Lars Schneider wrote: > >>> I'm not clear on why we want this cleanup filter. It looks like you use >>> it in the final patch to send an explicit

Re: [PATCH v4 11/12] convert: add filter..process option

> On 03 Aug 2016, at 19:45, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> packet: git< git-filter-protocol\n >> packet: git< version=2\n >> packet: git< capabilities=clean smudge\n > > During the discussion on the future of

Re: [PATCH v4 11/12] convert: add filter..process option

> On 03 Aug 2016, at 23:43, Junio C Hamano <gits...@pobox.com> wrote: > > On Wed, Aug 3, 2016 at 2:37 PM, Lars Schneider <larsxschnei...@gmail.com> > wrote: >>> >>> I think this was already pointed out in the previous review by Peff, >>> but

Re: [PATCH v4 01/12] pkt-line: extract set_packet_header()

> On 03 Aug 2016, at 22:18, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> set_packet_header() converts an integer to a 4 byte hex string. Make >> this f

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

> On 20 Jun 2016, at 01:51, Junio C Hamano wrote: > > Junio C Hamano writes: > >> Michael Haggerty writes: >> >>> According to [1], something in that test seems to have been trying to run >>> >>>git update-ref -d git-p4-tmp/6

Re: [PATCH 1/3] diff-highlight: add some tests.

> On 30 Jul 2016, at 17:11, Brian Henderson wrote: > > --- > contrib/diff-highlight/Makefile | 5 ++ > contrib/diff-highlight/t/Makefile| 19 +++ > contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++ >

Re: [PATCH 2/2] mingw: ensure temporary file handles are not inherited by child processes

> On 17 Aug 2016, at 14:41, Johannes Schindelin > wrote: > > From: Ben Wijen > > When the index is locked and child processes inherit the handle to > said lock and the parent process wants to remove the lock before the > child process exits, on

[PATCH v2] travis-ci: fix Perforce install on macOS

/homebrew-cask/pull/29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> --- Hi, this small update removes one more unnecessary line and makes the formula name lower case (no functional reason - just looks better ;-). @Junio: Do you prefer suc

Re: [PATCH] git-p4: Fix git-p4.mapUser on Windows

> On 21 Jan 2017, at 13:02, George Vanburgh wrote: > > From: George Vanburgh > > When running git-p4 on Windows, with multiple git-p4.mapUser entries in > git config - no user mappings are applied to the generated repository. > > Reproduction

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

> On 24 Jan 2017, at 01:18, Junio C Hamano wrote: > > * jk/fsck-connectivity-check-fix (2017-01-17) 6 commits > (merged to 'next' on 2017-01-23 at e8e9b76b84) > + fsck: check HAS_OBJ more consistently > + fsck: do not fallback "git fsck " to "git fsck" > + fsck: tighten

Re: [RFC] Case insensitive Git attributes

> On 23 Jan 2017, at 20:38, Junio C Hamano wrote: > > Junio C Hamano writes: > >> So you are worried about the case where somebody on a case >> insensitive but case preserving system would do >> >> $ edit file.txt >> $ edit .gitattributes >> $ git

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

> On 25 Jan 2017, at 23:51, Junio C Hamano wrote: > > Jeff King writes: > >> I guess the way to dig would be to add a test that looks at the output >> of "type mv" or something, push it to a Travis-hooked branch, and then >> wait for the output > > Sounds

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

> On 26 Jan 2017, at 10:14, Lars Schneider <larsxschnei...@gmail.com> wrote: > > >> On 25 Jan 2017, at 23:51, Junio C Hamano <gits...@pobox.com> wrote: >> >> Jeff King <p...@peff.net> writes: >> >>> I guess the way to dig wou

[RFC] Subtle differences in passing configs to git clone

Hi, I stumbled across the following today: (1) git -c foo.bar="foobar" clone --> uses the config temporarily (2) git clone -c foo.bar="foobar" --> uses the config and writes it to .git/config This was introduced in 84054f7 ("clone: accept config options on the command line") and it

Re: [PATCH] config: preserve case for one-shot config on the command line

> On 20 Feb 2017, at 10:58, Junio C Hamano wrote: > > Junio C Hamano writes: > >> I still haven't queued any of the variants I posted (and I do not >> think other people sent their own versions, either). I need to pick >> one and queue, with a test or

Re: [PATCH] travis-ci: run scan-build every time

> On 24 Feb 2017, at 18:29, Samuel Lijin wrote: > > Introduces the scan-build static code analysis tool from the Clang > project to all Travis CI builds. Installs clang (since scan-build > needs clang as a dependency) to make this possible (on macOS, also > updates PATH to

Re: SHA1 collisions found

> On 25 Feb 2017, at 00:06, Jeff King wrote: > > On Fri, Feb 24, 2017 at 11:47:46PM +0100, Jakub Narębski wrote: > >> I have just read on ArsTechnica[1] that while Git repository could be >> corrupted (though this would require attackers to spend great amount >> of resources

Re: [PATCH] travis-ci: run scan-build every time

> On 25 Feb 2017, at 23:31, Jeff King <p...@peff.net> wrote: > > On Sat, Feb 25, 2017 at 10:48:52PM +0100, Lars Schneider wrote: > >> >>> On 24 Feb 2017, at 18:29, Samuel Lijin <sxli...@gmail.com> wrote: >>> >>> Introduces the scan-b

Re: [PATCH] cocci: detect useless free(3) calls

> On 11 Feb 2017, at 14:58, René Scharfe wrote: > > Add a semantic patch for removing checks that cause free(3) to only be > called with a NULL pointer, as that must be a programming mistake. > > Signed-off-by: Rene Scharfe > --- > No cases are found in master or

[BUG] submodule config does not apply to upper case submodules?

It looks like as if submodule configs ("submodule.*") for submodules with upper case names are ignored. The test cases shows that skipping a submodule during a recursive clone seems not to work. Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> --- I observed the bug o

[PATCH v1] t7400: cleanup "submodule add clone shallow submodule" test

The test creates a "super" directory that is not removed after the test finished. This directory is not used in any subsequent tests and should therefore be removed. Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> --- I just noticed that my bug report test does not run

Re: git-p4.py caching

> On 14 Feb 2017, at 19:16, Martin-Louis Bright wrote: [CC'ing Luke and George] > hi! > > I am using git-p4.py to migrate a lot of medium and large Perforce > depots into git. I almost exclusively go one way: from Perforce to > git. I also frequently re-clone/re-migrate

Re: Cross-referencing the Git mailing list archive with their corresponding commits in `pu`

> On 06 Feb 2017, at 20:10, Junio C Hamano wrote: > > Johannes Schindelin writes: > >> So I thought maybe the From: line (from the body, if available, otherwise >> from the header) in conjunction with the "Date:" header would work. > > FYI, I

[PATCH v2] git-p4: fix git-p4.pathEncoding for removed files

s were not removed in a git-p4 cloned Git repository because the path names did not match. Fix this by moving the re-encoding to a place that affects "added" and "removed" paths. Add a test to demonstrate the issue. Signed-off-by: Lars Schneider <larsxschnei...@gmail.com&

Re: [PATCH] config: preserve case for one-shot config on the command line

t, too! > configuration variable is set to while the cmd is > running. The code to do so however downcased in its entirety, > which is wrong for a three-level ... > > The part needs to stay as-is. > > Reported-by: Lars Schneider <larsxschnei...@gmail.com> > Diagnosed-b

Re: [PATCH v1] travis-ci: fix Perforce install on macOS

> On 23 Jan 2017, at 19:22, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> Could you fast track the patch to `maint` if it works without trouble on >> `next` (as it should!)? >> >> Notes: >>Base Commit: 787f75f056 (master) > > I do not think there is

Re: [RFC] Case insensitive Git attributes

> On 23 Jan 2017, at 19:35, Junio C Hamano wrote: > > Dakota Hawkins writes: > >> Apologies for the delayed bump. I think because we're talking about >> affecting the behavior of .gitattributes that it would be better to >> have a distinct

Re: What's cooking in git.git (Jan 2017, #04; Mon, 23)

> On 24 Jan 2017, at 14:27, Jeff King <p...@peff.net> wrote: > > On Tue, Jan 24, 2017 at 11:04:21AM +0100, Lars Schneider wrote: > >> "fsck: prepare dummy objects for --connectivity-check" seems to >> make t1450-fsck.sh fail on macOS with TravisCI:

Re: [PATCH v4 01/12] pkt-line: extract set_packet_header()

> On 04 Aug 2016, at 18:14, Junio C Hamano wrote: > > Jeff King writes: > >> The cost of write() may vary on other platforms, but the cost of memcpy >> generally shouldn't. So I'm inclined to say that it is not really worth >> micro-optimizing the interface.

Re: 2.9.2 test failures on macOS

> On 03 Aug 2016, at 09:35, Jeremy Huddleston Sequoia > wrote: > > I have two test failures to report in git 2.9.2 on macOS: > > > t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2. This test passed > fine with 2.8.4, but it now fails with 2.9.2 at: > > not

Re: [PATCH] travis-ci: run scan-build every time

> On 26 Feb 2017, at 03:09, Samuel Lijin <sxli...@gmail.com> wrote: > > On Sat, Feb 25, 2017 at 3:48 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> >>> On 24 Feb 2017, at 18:29, Samuel Lijin <sxli...@gmail.com> wrote: >>> >

[PATCH v1] Travis: also test on 32-bit Linux

ndelin <johannes.schinde...@gmx.de> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> --- Thanks for the patch Dscho! The patch looks good to me in general but I want to propose the following changes: (1) Move all the docker magic into a dedicated file "ci/run-linux-32-build.

Re: [PATCH v1] Travis: also test on 32-bit Linux

> On 02 Mar 2017, at 12:24, Johannes Schindelin <johannes.schinde...@gmx.de> > wrote: > > Hi Lars, > > On Thu, 2 Mar 2017, Lars Schneider wrote: > >> The patch looks good to me in general but I want to propose the following >> changes: > >

[PATCH v2] convert: add "status=delayed" to filter process protocol

kouts only in `clone` (in unpack-trees.c) and `checkout` operations. Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> --- Hi, in v1 Junio criticized the "convert.h" interface of this patch [1]. After talking to Peff I think I understand Junio's point and I would like to ge

Re: [PATCH v2] convert: add "status=delayed" to filter process protocol

> On 27 Feb 2017, at 10:58, Jeff King <p...@peff.net> wrote: > > On Sun, Feb 26, 2017 at 07:48:16PM +0100, Lars Schneider wrote: > >> +If the request cannot be fulfilled within a reasonable amount of time >> +then the filter can respond with a "delayed&

Re: [PATCH 1/3] diff-highlight: add some tests.

> On 16 Aug 2016, at 22:48, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 30 Jul 2016, at 17:11, Brian Henderson <henderson...@gmail.com> wrote: >>> >>> --- >>> contrib

Re: [PATCH v6 12/13] convert: add filter..process option

> On 30 Aug 2016, at 22:46, Jakub Narębski wrote: > >>> The filter can exit right after the "error-all". If the filter does >>> not exit then Git will kill the filter. I'll add this to the docs. >> >> OK. > > Is it explicit kill, or implicit kill: close pipe and end process?

Re: [PATCH v1 2/2] read-cache: make sure file handles are not inherited by child processes

> On 06 Sep 2016, at 23:06, Eric Wong wrote: > > larsxschnei...@gmail.com wrote: >> static int ce_compare_data(const struct cache_entry *ce, struct stat *st) >> { >> int match = -1; >> -int fd = open(ce->name, O_RDONLY); >> +int fd = open(ce->name, O_RDONLY |

Re: [PATCH v1 1/2] sha1_file: open window into packfiles with CLOEXEC

> On 06 Sep 2016, at 13:38, Johannes Schindelin > wrote: > > Hi Eric & Lars, > > On Mon, 5 Sep 2016, Eric Wong wrote: > >> larsxschnei...@gmail.com wrote: >>> All processes that the Git main process spawns inherit the open file >>> descriptors of the main process.

Re: [PATCH v1 2/2] read-cache: make sure file handles are not inherited by child processes

> On 07 Sep 2016, at 20:23, Junio C Hamano wrote: > > Eric Wong writes: > >> We probably should be using O_NOATIME for all O_RDONLY cases >> to get the last bit of performance out (especially since >> non-modern-Linux systems probably still lack relatime). >

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

> On 29 Aug 2016, at 20:05, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Consider the case of a file that requires filtering and is present in >> branch

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

> On 29 Aug 2016, at 21:45, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> I see. Thanks for the explanation. > > I expect the updated log message to explain the issue correctly > then. Sure! &g

Re: [PATCH v6 10/13] convert: generate large test files only once

> On 29 Aug 2016, at 19:52, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 25 Aug 2016, at 21:17, Stefan Beller <sbel...@google.com> wrote: >>> >>>> On Thu, Aug 25, 2016 at

Re: [PATCH v6 10/13] convert: generate large test files only once

> On 29 Aug 2016, at 19:46, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh >> index 7b45136..34c8eb9 100755 >> --- a/t/t0021-conversion.sh >> +++ b/t/t0021-conversion.sh >> @@ -4,6 +4,15 @@

Re: [PATCH v7 10/10] convert: add filter..process option

> On 10 Sep 2016, at 08:29, Torsten Bögershausen wrote: > > On Thu, Sep 08, 2016 at 08:21:32PM +0200, larsxschnei...@gmail.com wrote: > [] >> +packet: git> git-filter-client >> +packet: git> version=2 >> +packet: git> version=42 >> +packet:

Re: [PATCH v7 03/10] pkt-line: add packet_write_fmt_gently()

> On 11 Sep 2016, at 18:01, Stefan Beller <sbel...@google.com> wrote: > > On Sun, Sep 11, 2016 at 4:36 AM, Lars Schneider > <larsxschnei...@gmail.com> wrote: > >>> >>> call check_pipe from write_or_die here instead of >>> reproducin

Re: [PATCH v7 06/10] pkt-line: add functions to read/write flush terminated packet streams

> On 08 Sep 2016, at 23:49, Stefan Beller <sbel...@google.com> wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> write_packetized_from_fd() and write_packetized

Re: [PATCH v7 08/10] convert: modernize tests

> On 09 Sep 2016, at 00:05, Stefan Beller <sbel...@google.com> wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Use `test_config` to set the config, check tha

Re: [ANNOUNCE] Git User's Survey 2016

> On 13 Sep 2016, at 17:54, Jakub Narębski wrote: > > On 13 September 2016 at 18:15, David Bainbridge > wrote: >> Hi Jakub, >> >> You said: >> P.S. At request I can open a separate channel in survey, with >> a separate survey URL, so that

Re: [PATCH v7 10/10] convert: add filter..process option

> On 10 Sep 2016, at 17:40, Torsten Bögershausen wrote: > > [] > > One general question up here, more comments inline. > The current order for a clean-filter is like this, I removed the error > handling: > > int convert_to_git() > { > ret |= apply_filter(path, src, len,

Re: [PATCH v7 04/10] pkt-line: add packet_flush_gently()

> On 13 Sep 2016, at 00:30, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_flush() would die in case of a write error even though for some &g

Re: Git Miniconference at Plumbers

> On 12 Sep 2016, at 21:11, Junio C Hamano wrote: > > [..] > properly; supporting "huge objects" better in the object layer, > without having to resort to ugly hacks like GitLFS that will never > be part of the core Git. [...] I agree with you that GitLFS is an ugly hack.

Re: [PATCH v7 10/10] convert: add filter..process option

> On 13 Sep 2016, at 17:42, Junio C Hamano wrote: > > Torsten Bögershausen writes: > >> I would really consider to treat pathnames as binary, and not add a trailing >> '\n', >> are there other opinions ? > > It would be the most consistent if the same

Re: [PATCH v7 04/10] pkt-line: add packet_flush_gently()

> On 13 Sep 2016, at 23:44, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 13 Sep 2016, at 00:30, Junio C Hamano <gits...@pobox.com> wrote: >>> >>> larsxschnei...@gmai

Re: [PATCH] pkt-line: mark a file-local symbol static

> On 14 Sep 2016, at 14:31, Ramsay Jones wrote: > > > Signed-off-by: Ramsay Jones > --- > > Hi Lars, > > If you need to re-roll your 'ls/filter-process' branch, could you > please squash this into the relevant patch; commit 2afd9b22

Re: [PATCH v7 03/10] pkt-line: add packet_write_fmt_gently()

> On 08 Sep 2016, at 23:18, Stefan Beller wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, wrote: > >> +static int packet_write_fmt_1(int fd, int gently, >> + const char *fmt, va_list args) >> +{ >> + struct strbuf

Re: [PATCH v7 05/10] pkt-line: add packet_write_gently()

> On 08 Sep 2016, at 23:24, Stefan Beller wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, wrote: > >> >> Add packet_write_gently() which writes arbitrary data and returns `0` >> for success and `-1` for an error. > > I think documenting the return

Re: [PATCH v8 02/11] pkt-line: extract set_packet_header()

On 24 Sep 2016, at 23:22, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Subject: [PATCH v8 02/11] pkt-line: extract set_packet_header()

Re: [PATCH v8 01/11] pkt-line: rename packet_write() to packet_write_fmt()

On 24 Sep 2016, at 23:14, Jakub Narębski <jna...@gmail.com> wrote: > Hello Lars, > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write() should be called packet_

Re: [PATCH v8 03/11] run-command: move check_pipe() from write_or_die to run_command

> On 25 Sep 2016, at 00:12, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Move check_pipe() to run_command and make it public. This is nec

Re: [PATCH v8 06/11] pkt-line: add packet_write_gently()

On 25 Sep 2016, at 13:26, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> ... >> >> +static int packet_write_gently(const int fd_out, const char *

Re: [PATCH v8 07/11] pkt-line: add functions to read/write flush terminated packet streams

On 25 Sep 2016, at 15:46, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> +{ >> +static char buf[PKTLINE_DATA_MAXLEN]; > > Sidenote: we have L

Re: [PATCH v8 00/11] Git filter protocol

> On 29 Sep 2016, at 18:57, Junio C Hamano wrote: > > Torsten Bögershausen writes: > >>> 1) Git exits >>> 2) The filter process receives EOF and prints "STOP" to the log >>> 3) t0021 checks the content of the log >>> >>> Sometimes 3 happened before 2 which

Re: [PATCH v9 04/14] run-command: add wait_on_exit

> On 06 Oct 2016, at 11:32, Johannes Schindelin <johannes.schinde...@gmx.de> > wrote: > > Hi Junio & Lars, > > On Wed, 5 Oct 2016, Junio C Hamano wrote: > >> Lars Schneider <larsxschnei...@gmail.com> writes: >> >>> OK. Something like

Re: [PATCH v8 11/11] convert: add filter..process option

> On 04 Oct 2016, at 22:50, Jakub Narębski <jna...@gmail.com> wrote: > > [Some of answers may get invalidated by v9] > > W dniu 30.09.2016 o 20:56, Lars Schneider pisze: >>> On 27 Sep 2016, at 00:41, Jakub Narębski <jna...@gmail.com> wrote: >>>

Re: [PATCH v8 00/11] Git filter protocol

> On 04 Oct 2016, at 21:04, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 03.10.2016 o 19:13, Lars Schneider pisze: >>> On 01 Oct 2016, at 22:48, Jakub Narębski <jna...@gmail.com> wrote: >>> W dniu 01.10.2016 o 20:59, Lars Schneider pisze: >&g

Re: What's cooking in git.git (Oct 2016, #01; Mon, 3)

> On 04 Oct 2016, at 00:31, Junio C Hamano wrote: > > > * ls/filter-process (2016-09-23) 11 commits > - convert: add filter..process option > - convert: make apply_filter() adhere to standard Git error handling > - convert: modernize tests > - convert: quote filter names in

Merge conflicts in .gitattributes can cause trouble

Hi, If there is a conflict in the .gitattributes during a merge then it looks like as if the attributes are not applied (which kind of makes sense as Git would not know what to do). As a result Git can treat e.g. binary files as text and they can end up with changed line endings in the

Re: [PATCH v8 11/11] convert: add filter..process option

> On 04 Oct 2016, at 23:00, Jakub Narębski <jna...@gmail.com> wrote: > > [Some of answers and comments may got invalidated by v9] > > W dniu 30.09.2016 o 21:38, Lars Schneider pisze: >>> On 27 Sep 2016, at 17:37, Jakub Narębski <jna...@gmail.com> wrote: >

<    1   2   3   4   5   6   7   8   9   10   >