Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Eric Blake
ect string comparison restriction; git also seems to have a > bug here. Because even if you have sender != author, then git falsely uses > author as sender of the cover letter, whereas the emails of the individual > patches are encoded correctly. At any rate, I'm glad that you have figured out a workaround, even if painful, while we wait for git to provide what we really need. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]

2018-05-04 Thread Eric Blake
different maintainers' areas, may make the cover letter have so many recipients that various mail gateways start rejecting it as potential spam. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: [PATCH] git-contacts: Add recognition of Reported-by

2017-07-21 Thread Eric Blake
On 07/21/2017 09:37 AM, Junio C Hamano wrote: > Eric Blake writes: > >> It's nice to cc someone that reported a bug, in order to let >> them know that a fix is being considered, and possibly even >> get their help in reviewing/testing the patch. >> >>

[PATCH] git-contacts: Add recognition of Reported-by

2017-07-21 Thread Eric Blake
It's nice to cc someone that reported a bug, in order to let them know that a fix is being considered, and possibly even get their help in reviewing/testing the patch. Signed-off-by: Eric Blake --- contrib/contacts/git-contacts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-05 Thread Eric Blake
e charset encoding is another case where the interactive parser should be taught to balk at nonsense encoding answers? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

2013-01-25 Thread Eric Blake
ion of a Windows system header (generally discouraged, but sometimes a necessary evil) might cause WIN32 to be defined for all subsequent headers. Which is why other projects, like gnulib, have # if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__ all over the place. -

Re: git send-email should not allow 'y' for in-reply-to

2013-01-11 Thread Eric Blake
On 01/11/2013 09:47 AM, Jeff King wrote: > On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote: > >>> Please don't answer "y" when git send email shows the following prompt: >>> >> >> Anyone willing to patch upstream 'git send-emai

git send-email should not allow 'y' for in-reply-to

2013-01-11 Thread Eric Blake
n blindly sending a bad messageID for the in-reply-to field, to help future users avoid this mistake? Obviously, it won't help until the patch eventually percolates into distros, so it would be a few more months before we see the benefits, but down the road it will prevent confusing thread

Re: [PATCH] notes: mention --notes in more places

2012-10-17 Thread Eric Blake
pretty-options.txt that is relevant to format-patch. If it's easy enough, I can also consider using --- instead of Notes: as the separator when using format-patch. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[PATCH] notes: mention --notes in more places

2012-10-16 Thread Eric Blake
.txt: Mention that --notes option exists in many commands to override defaults. * git-format-patch.txt: Include pretty-options, for things like --notes. * git-send-email.txt: Mention that revision lists forwarded to format-patch can also include options. Signed-off-by: Eric Blake --- Documentat