Re: [PATCH] rebase -i: introduce the 'test' command

2018-12-03 Thread Luc Van Oostenryck
On Mon, Dec 03, 2018 at 08:01:44PM +0100, Johannes Schindelin wrote: > Hi Luc, > > On Mon, 3 Dec 2018, Luc Van Oostenryck wrote: > > > On Sat, Dec 01, 2018 at 03:02:09PM -0500, Jeff King wrote: > > > I sometimes add "x false" to the top of the todo list

Re: [PATCH] rebase -i: introduce the 'test' command

2018-12-03 Thread Luc Van Oostenryck
On Sat, Dec 01, 2018 at 03:02:09PM -0500, Jeff King wrote: > On Thu, Nov 29, 2018 at 09:32:48AM +0100, Johannes Schindelin wrote: > > > > > Would it not make more sense to add a command-line option (and a config > > > > setting) to re-schedule failed `exec` commands? Like so: > > > > > > Your

Re: [PATCH] reopen_tempfile(): truncate opened file

2018-09-05 Thread Luc Van Oostenryck
On Tue, Sep 04, 2018 at 07:36:43PM -0400, Jeff King wrote: > On Tue, Sep 04, 2018 at 12:38:07PM -0400, Jeff King wrote: > > > > And just to be clear I'm looking forward to a patch from Jeff to fix > > > this since he clearly put more thoughts on this than me. With commit.c > > > being the only

Re: [BUG] index corruption with git commit -p

2018-09-02 Thread Luc Van Oostenryck
On Sun, Sep 02, 2018 at 03:24:09AM -0400, Jeff King wrote: > On Sun, Sep 02, 2018 at 09:12:04AM +0200, Duy Nguyen wrote: > > diff --git a/builtin/commit.c b/builtin/commit.c > > index 2be7bdb331..60f30b3780 100644 > > --- a/builtin/commit.c > > +++ b/builtin/commit.c > > @@ -432,6 +432,7 @@ static

[BUG] index corruption with git commit -p

2018-09-01 Thread Luc Van Oostenryck
'', but always seems 4 chars. If the commit command doesn't use the '-p' flag, there is no problem. The repository itself is not corrupted, it's only the index. It happends with git 2.18.0 and 2.17.0 -- Luc Van Oostenryck

Re: partial_clone_get_default_filter_spec has no callers

2017-12-07 Thread Luc Van Oostenryck
On Thu, Dec 07, 2017 at 01:59:26AM +, Ramsay Jones wrote: > > BTW, if you are using a version of sparse post v0.5.1, you can > get rid of the only sparse warning on Linux (assuming you don't > build with NO_REGEX set), by using the -Wno-memcpy-max-count option; > I have the following set in

Re: bug during checkout of remote branch and uncommited changes ?

2017-07-07 Thread Luc Van Oostenryck
On Fri, Jul 7, 2017 at 11:22 PM, Junio C Hamano <gits...@pobox.com> wrote: > Luc Van Oostenryck <luc.vanoostenr...@gmail.com> writes: > >> At least here, the scenario I gave allow to fully reproduce the problem. >> >> Would you like any other information? >

Re: bug during checkout of remote branch and uncommited changes ?

2017-07-07 Thread Luc Van Oostenryck
On Fri, Jul 07, 2017 at 08:53:39AM -0700, Junio C Hamano wrote: > Luc Van Oostenryck <luc.vanoostenr...@gmail.com> writes: > > > $ git reset --hard > > patching file afile.c > > Is that a message from something? It does not sound like something > &quo

bug during checkout of remote branch and uncommited changes ?

2017-07-07 Thread Luc Van Oostenryck
sition was ... Switched to branch '' -- Luc Van Oostenryck

Re: [PATCH] usage: fix a sparse 'redeclared with different type' error

2017-05-22 Thread Luc Van Oostenryck
onst' or 'extern'. But the real problem here with sparse is that while it indeed compare the declaration with the definition, this is done not by checking compatibility but by strict equality. In other words, the NORETURN, but also a 'static', in the declaration should be somehow inherited in a subsequent definition but sparse doesn't do that yet. -- Luc Van Oostenryck

Re: [BUG] branch renamed to 'HEAD'

2017-02-27 Thread Luc Van Oostenryck
On Mon, Feb 27, 2017 at 04:02:33AM -0500, Jeff King wrote: > Ugh. Actually, there are a few complications I found: > > 1. Checking "HEAD" afterwards means you can't actually have a branch > named "HEAD". Doing so is probably insane, but we probably really > _do_ want to just disallow

Re: [BUG] branch renamed to 'HEAD'

2017-02-26 Thread Luc Van Oostenryck
On Mon, Feb 27, 2017 at 11:43:46AM +0530, Karthik Nayak wrote: > Hello, > > Thanks for reporting, but I don't think it is a bug. > > On Mon, Feb 27, 2017 at 10:22 AM, Luc Van Oostenryck > <luc.vanoostenr...@gmail.com> wrote: > > Hi, > > > > I just disc

[BUG] branch renamed to 'HEAD'

2017-02-26 Thread Luc Van Oostenryck
amed 'HEAD'. Luc Van Oostenryck

Re: dangling commits in worktree

2016-11-23 Thread Luc Van Oostenryck
On Wed, Nov 23, 2016 at 04:45:56PM +0700, Duy Nguyen wrote: > > It's a known issue that gc (and maybe some others that do rev-list > --all, like fsck) "forgets" about some worktree's refs and you will > see what you see. Good. I just wanted to be sure it was a known problem. Thanks for the info.