Re: git-completion.tcsh

2015-04-24 Thread Marc Khouzam
On Fri, Apr 24, 2015 at 7:30 AM, SZEDER Gábor sze...@ira.uka.de wrote: Hi, Quoting Marc Khouzam marc.khou...@gmail.com: Hi, I did notice the problem a while ago and had traced it back to the fact that the bash completion scripts no longer adds the trailing '/' at the end of directories

Re: git-completion.tcsh

2015-04-23 Thread Marc Khouzam
Hi, I did notice the problem a while ago and had traced it back to the fact that the bash completion scripts no longer adds the trailing '/' at the end of directories. Tcsh needs that '/' to know not to add that annoying extra space. Bash 3 needed to put it that trailing '/' but bash 4 did not.

[PATCH] Completion: Cleanup tcsh script and add debug flag

2015-04-23 Thread Marc Khouzam
completions of directories/files. Also add -d/--debug flag support to help troubleshoot the script. Signed-off-by: Marc Khouzam marc.khou...@gmail.com --- I thought this would help when for people that experience issues with the script. Thanks! Marc contrib/completion/git-completion.tcsh

RE: [QUERY] How do you sort completions?

2013-05-24 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Ramkumar Ramachandra Sent: Friday, May 24, 2013 12:19 PM To: SZEDER Gábor Cc: Git List; Felipe Contreras Subject: Re: [QUERY] How do you sort completions? SZEDER Gábor wrote: I

RE: [PATCH] Handle path completion and colon for tcsh script

2013-02-03 Thread Marc Khouzam
intelligence to the tcsh completion script. Instead, it is simpler to ask the bash script to keep the trailing slash. This patch does this. Also, tcsh does not handle the colon as a completion separator so we remove it from the list of separators. Signed-off-by: Marc Khouzam

[PATCH] Handle path completion and colon for tcsh script

2013-02-02 Thread Marc Khouzam
method available for older bash versions. Also, tcsh does not handle the colon as a completion separator so we remove it from the list of separators. Signed-off-by: Marc Khouzam marc.khou...@ericsson.com --- Hi, Here is the update for tcsh completion which is needed to handle the cool new path

RE: [feature request] git add completion should exclude staged content

2013-01-30 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Monday, January 28, 2013 3:16 PM To: Junio C Hamano Cc: Michael J Gruber; wookietreiber; git@vger.kernel.org Subject: Re: [feature request] git add completion

RE: [feature request] git add completion should exclude staged content

2013-01-30 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Wednesday, January 30, 2013 1:24 PM To: Marc Khouzam Cc: 'Junio C Hamano'; 'Michael J Gruber'; 'wookietreiber'; 'git@vger.kernel.org' Subject: Re: [feature

RE: git-completion.tcsh and git-completion.zsh are broken?

2013-01-09 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Wednesday, January 09, 2013 2:17 PM To: git@vger.kernel.org Subject: git-completion.tcsh and git-completion.zsh are broken? -BEGIN PGP SIGNED MESSAGE-

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-07 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Monday, January 07, 2013 8:43 AM To: Marc Khouzam Cc: Junio C Hamano; git@vger.kernel.org; sze...@ira.uka.de; felipe.contre...@gmail.com Subject: Re: [PATCH v4

[PATCH] Prevent space after directories in tcsh completion

2013-01-07 Thread Marc Khouzam
as expected. Signed-off-by: Marc Khouzam marc.khou...@ericsson.com --- This update is meant to have tcsh completion work better if the feature git-completion.bash: add support for path completion is accepted. See http://www.mail-archive.com/git@vger.kernel.org/msg14137.html This commit does

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-05 Thread Marc Khouzam
Junio C Hamano gits...@pobox.com writes: Marc Khouzam marc.khou...@ericsson.com writes: I've been playing with it but I'm not getting the expected behavior when I cd to a sub-directory. Thanks for testing. Manlio? Can you try the attached patch? Thanks for this, it improves

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-04 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Friday, December 21, 2012 11:55 AM To: git@vger.kernel.org Cc: sze...@ira.uka.de; felipe.contre...@gmail.com; Manlio Perillo Subject: [PATCH v4]

[PATCH] Add file completion to tcsh git completion.

2012-12-11 Thread Marc Khouzam
with their directory prefix. - Completions containing shell variables are not handled. - Completions with ~ as the first character are not handled. Signed-off-by: Marc Khouzam marc.khou...@ericsson.com --- Beyond the described fix, this commit also improves minor aspects of the script. Normally I would submit

Re: [PATCH] Support for git aliasing for tcsh completion

2012-11-27 Thread Marc Khouzam
On Tue, Nov 27, 2012 at 12:16 PM, Junio C Hamano gits...@pobox.com wrote: The patch was linewrapped so I had to fix it up; Sorry about that. I don't know if it is gmail, or the fact that I use its web interface that causes these problems. please double check what will be queued on 'pu' to

[PATCH] Support for git aliasing for tcsh completion

2012-11-26 Thread Marc Khouzam
completion to work. A check for the presence of ${HOME}/.git-completion.bash is also added to help the user make use of the script properly. Signed-off-by: Marc Khouzam marc.khou...@gmail.com --- This issue was reported by someone already making use of the tcsh completion script. Thanks

[PATCH v2] Completion must sort before using uniq

2012-11-23 Thread Marc Khouzam
suggesting such invalid branch names is to first call 'sort' and then 'uniq -u'. Signed-off-by: Marc Khouzam marc.khou...@gmail.com --- The solution is to first call 'sort' and then 'uniq -u'. The solution to what? This seems to be the right thing indeed, but you don't explain what is the actual

[PATCH v3] Completion must sort before using uniq

2012-11-23 Thread Marc Khouzam
from suggesting such invalid branch names is to first call 'sort' and then 'uniq -u'. Signed-off-by: Marc Khouzam marc.khou...@gmail.com --- Mostly cosmetic suggestions, but it looks OK to me. Thanks for the suggestions, I updated the commit message. With this explanation the patch looks good

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-20 Thread Marc Khouzam
On Sat, Nov 17, 2012 at 1:01 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I gather that using a wrapper for zsh causes concerns about backwards-compatibility. I don't see any concerns. if [[ -n ${ZSH_VERSION-} ]]; then # replace below by zsh completion commands calling `bash

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-17 Thread Marc Khouzam
On Fri, Nov 16, 2012 at 4:56 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 10:20 PM, Junio C Hamano gits...@pobox.com wrote: The point is not about the quality of zsh's emulation of (k)sh when it is run under that mode, but is about not having to have that

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
On Thu, Nov 15, 2012 at 8:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam marc.khou...@gmail.com wrote: The current tcsh-completion support for Git, as can be found on the Internet, takes the approach of defining the possible completions

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 3:39 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Thu, Nov 15, 2012 at 8:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam

[PATCH v3] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
a third script Approach (C) was selected avoid any modification to git-completion.bash. Signed-off-by: Marc Khouzam marc.khou...@gmail.com --- Here's another version which adds contrib/completion/git-completion.tcsh but does not modify contrib/completion/git-completion.bash at all. (Sorry, but I

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
On Fri, Nov 16, 2012 at 12:18 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 4:48 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Is it possible to just check if this is a login

[PATCH v4] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
a third script Approach (C) was selected avoid any modification to git-completion.bash. Signed-off-by: Marc Khouzam marc.khou...@gmail.com --- As suggested, I put the 'sort | uniq' inside the script. In that case, I don't need to worry about aliases since 'sort |uniq' will be executed in bash

[PATCH] tcsh-completion re-using git-completion.bash

2012-11-15 Thread Marc Khouzam
Approach (A) was selected to keep the tcsh completion support well isolated without introducing excessive complexity. Signed-off-by: Marc Khouzam marc.khou...@gmail.com --- Here is the updated version of the patch. I got git send-email to work, so I hope the formatting will be correct. Thanks in advance

Re: Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread Marc Khouzam
Thanks for the review. On Tue, Nov 13, 2012 at 6:14 AM, SZEDER Gábor sze...@ira.uka.de wrote: Hi, On Mon, Nov 12, 2012 at 03:07:46PM -0500, Marc Khouzam wrote: Hi, [...] Signed-off-by: Marc Khouzam marc.khou...@gmail.com [...] Thanks Marc --- contrib/completion/git

Re: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread Marc Khouzam
Thanks for the review. I wasn't aware that you were doing a similar effort for zsh. On Tue, Nov 13, 2012 at 1:31 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam marc.khou...@gmail.com wrote: this patch allows tcsh-users to get the benefits

Re: Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread Marc Khouzam
On Tue, Nov 13, 2012 at 6:46 PM, SZEDER Gábor sze...@ira.uka.de wrote: Hi, On Tue, Nov 13, 2012 at 03:12:44PM -0500, Marc Khouzam wrote: +if [ -n $1 ] ; then + # If there is an argument, we know the script is being executed + # so go ahead and run the _git_complete_with_output function

Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-12 Thread Marc Khouzam
completion support well isolated without introducing excessive complexity. Signed-off-by: Marc Khouzam marc.khou...@gmail.com == With the changes applied, tcsh users should: #1) Copy both this file and the bash completion script to your ${HOME} directory # using the names ${HOME}/.git