What happen if show_http_message fails to reencode?

2015-04-20 Thread Yi, EungJun
I'm trying to make my git server sends http messages in non-ASCII encoding. And I have a question. At 206-218 in remote-curl.c: static int show_http_message(struct strbuf *type, struct strbuf *charset, struct strbuf *msg) { const char *p, *eol; /* * We only

Re: Git + SFC Status Update

2015-04-16 Thread Yi EungJun
- Written policy: https://git-scm.com/trademark My browser shows an Untrusted Connection page when click the link. Does git-scm have no TLS certificate? -- View this message in context: http://git.661346.n2.nabble.com/Git-SFC-Status-Update-tp7628669p7628850.html Sent from the git mailing

Re: How to send a warning message from git hosting server?

2015-04-12 Thread Yi, EungJun
On Wed, Apr 8, 2015 at 8:08 PM, Tony Finch d...@dotat.at wrote: Yi, EungJun semtlen...@gmail.com wrote: I want a way to response a remote message when a client send any kind of request. Is it possible? Yes, though you need a wrapper around git. Recent versions of gitolite have a motd

How to send a warning message from git hosting server?

2015-04-05 Thread Yi, EungJun
Hello. I am serving a git hosting service for my company. Sometimes I want to send a warning message to users who use my service; e.g. the service will be shutdown tomorrow for a while temporary. I know it is possible to a remote message by hooks or HTTP body if an error occured. But it seems

Feature request: Update remote url if it is redirected.

2015-04-05 Thread Yi, EungJun
Some git hosting services, like Github, a url to a git repository can be changed by changing the name of the repository by the owner. If someone tries to get the repository with the old url, usually the hosting service serves the request with the repository indiciated by the new url. It is very

Re: [PATCH v3] diff-highlight: do not split multibyte characters

2015-04-04 Thread Yi, EungJun
are mucking with code in the split_line function, we change a '*' quantifier to a '+' quantifier when matching the $COLOR expression which has the side effect of speeding everything up while eliminating useless '' elements in the returned array. Reported-by: Yi EungJun semtlen...@gmail.com Signed

Re: [PATCH] diff-highlight: Fix broken multibyte string

2015-04-02 Thread Yi, EungJun
I timed this one versus the existing diff-highlight. It's about 7% slower. That's not great, but is acceptable to me. The String::Multibyte version was a lot faster, which was nice (but I'm still unclear on _why_). I think the reason is here: sub split_line { local $_ = shift;

[PATCH] diff-highlight: Fix broken multibyte string

2015-03-30 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Highlighted string might be broken if the common subsequence is a proper subset of a multibyte character. For example, if the old string is 진 and the new string is 지, then we expect the diff is rendered as follows: -진 +지 but actually

Re: [ANNOUNCE] Git Merge, April 8-9, Paris

2015-02-20 Thread Yi EungJun
I heard Git Contributors Summit is scheduled on April 8th at Git Merge 2015. Does anyone know the agenda of the summit? I am considering to attend the summit. -- View this message in context: http://git.661346.n2.nabble.com/ANNOUNCE-Git-Merge-April-8-9-Paris-tp7624561p7625750.html Sent from

Re: [PATCH v9 0/1] http: Add Accept-Language header if possible

2015-01-30 Thread Yi, EungJun
I'm very glad to hear that. Thanks to all reviewers! On Thu, Jan 29, 2015 at 3:19 PM, Junio C Hamano gits...@pobox.com wrote: Thanks; queued. Let's run with this and try to make it graduate early next cycle. -- To unsubscribe from this list: send the line unsubscribe git in the body of a

[PATCH v9 1/1] http: Add Accept-Language header if possible

2015-01-28 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en - Accept-Language: ko, en;q=0.9, *;q=0.1 LANGUAGE=ko LANG=en_US.UTF-8 - Accept

Re: [PATCH] http: Add Accept-Language header if possible

2015-01-28 Thread Yi, EungJun
I agree that a list of char* is enough for language_tags. Thanks for your review and patch. I'll apply your patch and send v9. On Wed, Jan 28, 2015 at 3:15 PM, Junio C Hamano gits...@pobox.com wrote: On Tue, Jan 27, 2015 at 3:34 PM, Junio C Hamano gits...@pobox.com wrote: Yi EungJun semtlen

[PATCH v9 0/1] http: Add Accept-Language header if possible

2015-01-28 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Change since v8 Apply Junio's patch: Use an array of char* instead of strbuf for language_tags. Yi EungJun (1): http: Add Accept-Language header if possible http.c | 147 + remote

[PATCH v8 0/1] http: Add Accept-Language header if possible

2015-01-27 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Change since v7 From Torsten Bögershausen's review: * remove unnecessary if-statement From Eric Sunshine's review: * fix memory leaks and uninitialized variables * remove unnecessary if-statement From Junio C Hamano's review

[PATCH] http: Add Accept-Language header if possible

2015-01-27 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en - Accept-Language: ko, en;q=0.9, *;q=0.1 LANGUAGE=ko LANG=en_US.UTF-8 - Accept

[PATCH v7 0/1] http: Add Accept-Language header if possible

2015-01-18 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Changes since v6 From Junio C Hamano's review: * Fix check_language() in t5550-http-fetch-dumb.sh as his suggestion. From Eric Sunshine's review: * Rewrite the parser without state. Yi EungJun (1): http: Add Accept-Language header if possible

[PATCH v7 1/1] http: Add Accept-Language header if possible

2015-01-18 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en - Accept-Language: ko, en;q=0.9, *;q=0.1 LANGUAGE=ko LANG=en_US.UTF-8 - Accept

[ANN] SVNGit - Checkout Git repository by SVN Client

2015-01-08 Thread Yi, EungJun
Hello, all. I just have started to develop SVNGit, the servlet library in pure Java for SVN Client to checkout Git repository. The project is hosted at https://github.com/naver/svngit. Since the project is at very early stage, SVNGit unstably supports only a few SVN commands: checkout, update

[PATCH v6 0/1] http: Add Accept-Language header if possible

2014-12-22 Thread Yi EungJun
points an empty string. From Jeff King's advice: * get_preferred_languages() considers LC_MESSAGES only if NO_GETTEXT is not defined. * Remove the tests for LC_MESSAGES, LANG and LC_ALL. Yi EungJun (1): http: Add Accept-Language header if possible http.c | 173

[PATCH v6 1/1] http: Add Accept-Language header if possible

2014-12-22 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en - Accept-Language: ko, en;q=0.9, *;q=0.1 LANGUAGE=ko LANG=en_US.UTF-8 - Accept

Re: Accept-language test fails on Mac OS

2014-12-06 Thread Yi, EungJun
Could you tell me your locale information from executing 'locale' command and the verbose message you can get by accessing any git repository via HTTP protocol? (e.g. GIT_CURL_VERBOSE=1 git clone http://github.com/foo/bar ) I think the failures are related with your locale information. On Sat,

Re: Accept-language test fails on Mac OS

2014-12-06 Thread Yi, EungJun
Thank you for providing useful information to fix the failures. On Sun, Dec 7, 2014 at 6:04 AM, Torsten Bögershausen tbo...@web.de wrote: On 2014-12-06 20.44, Yi, EungJun wrote: Could you tell me your locale information from executing 'locale' command and the verbose message you can get

[PATCH v5 0/1] http: Add Accept-Language header if possible

2014-12-02 Thread Yi EungJun
Changes since v4 * Fix styles as Junio C Hamano suggested. * Limit number of languages and length of Accept-Language header. Yi EungJun (1): http: Add Accept-Language header if possible http.c | 154 + remote-curl.c

[PATCH v5 1/1] http: Add Accept-Language header if possible

2014-12-02 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en - Accept-Language: ko, en;q=0.9, *;q=0.1 LANGUAGE=ko LANG=en_US.UTF-8 - Accept

Re: [PATCH v4 1/1] http: Add Accept-Language header if possible

2014-08-03 Thread Yi, EungJun
Thanks very much for your detailed review and sorry for late reply. 2014-07-22 4:01 GMT+09:00 Junio C Hamano gits...@pobox.com: Yi EungJun semtlen...@gmail.com writes: From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages

[PATCH v4 0/1] http: Add Accept-Language header if possible

2014-07-19 Thread Yi EungJun
Changes since v3: * Fix styles and syntax. (Thanks to Jeff King and Eric Sunshine) * Cache Accept-Language header. (Thanks to Jeff King) * Remove floating point numbers. (Thanks to Junio C Hamano) * Make the for-loop to get the value of the header simpler. * Add more comments. Yi EungJun (1

[PATCH v4 1/1] http: Add Accept-Language header if possible

2014-07-19 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en - Accept-Language: ko, en; q=0.9, *; q=0.1 LANGUAGE=ko LANG=en_US.UTF-8

Re: [PATCH v3] http: Add Accept-Language header if possible

2014-07-13 Thread Yi, EungJun
2014-07-13 13:26 GMT+09:00 Eric Sunshine sunsh...@sunshineco.com: + /* Decide the precision for q-factor on number of preferred languages. */ + if (num_langs + 1 100) { /* +1 is for '*' */ + q_precision = 0.001; + q_format = ; q=%.3f; + } else

Re: [PATCH v3] http: Add Accept-Language header if possible

2014-07-13 Thread Yi, EungJun
2014-07-14 1:57 GMT+09:00 Junio C Hamano gits...@pobox.com: If you do not want floating point (and I think we tend to avoid it when we do not need it), you can realize that in your use of 0.1 and 0.01 and 0.001 there is nothing fundamentally floating-point; you can measure how many digits

Re: [PATCH v3] http: Add Accept-Language header if possible

2014-07-12 Thread Yi, EungJun
Thanks for your detailed review and nice suggestions. I will accept most of them. 2014-07-12 2:35 GMT+09:00 Jeff King p...@peff.net: + /* Decide the precision for q-factor on number of preferred languages. */ + if (num_langs + 1 100) { /* +1 is for '*' */ + q_precision =

Re: [PATCH] http: Add Accept-Language header if possible

2014-07-11 Thread Yi, EungJun
2014-07-09 19:40 GMT+09:00 Peter Krefting pe...@softwolves.pp.se: Yi EungJun: Example: LANGUAGE= - LANGUAGE=ko - Accept-Language: ko; q=1.000, *; q=0.001 LANGUAGE=ko:en - Accept-Language: ko; q=1.000, en; q=0.999, *; q=0.001 Avoid adding q=1.000. It is redundant (the default for any

Re: [PATCH] http: Add Accept-Language header if possible

2014-07-11 Thread Yi, EungJun
2014-07-11 5:10 GMT+09:00 Jeff King p...@peff.net: On Wed, Jul 09, 2014 at 11:46:14AM +0100, Peter Krefting wrote: Jeff King: I did some digging, and I think the public API is setlocale with a NULL parameter, like: printf(%s\n, setlocale(LC_MESSAGES, NULL)); That still will end up

[PATCH v2] http: Add Accept-Language header if possible

2014-07-11 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en - Accept-Language: ko, en; q=0.9, *; q=0.1 LANGUAGE=ko LANG=en_US.UTF-8

Re: [PATCH] http: Add Accept-Language header if possible

2014-07-11 Thread Yi, EungJun
2014-07-12 1:24 GMT+09:00 Eric Sunshine sunsh...@sunshineco.com: On Fri, Jul 11, 2014 at 5:22 AM, Yi, EungJun semtlen...@gmail.com wrote: 2014-07-09 6:52 GMT+09:00 Eric Sunshine sunsh...@sunshineco.com: + grep ^Accept-Language: ko; q=1.000, en; q=0.999, \*; q=0.001 actual Do you want

[PATCH v3] http: Add Accept-Language header if possible

2014-07-11 Thread Yi EungJun
=en_US.UTF-8 - Accept-Language: en-US, *; q=0.1 This gives git servers a chance to display remote error messages in the user's preferred language. Signed-off-by: Yi EungJun eungjun...@navercorp.com --- http.c | 125 + remote-curl.c

[PATCH] http: Add Accept-Language header if possible

2014-07-08 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by 'LANGUAGE' environment variable if the variable is not empty. Example: LANGUAGE= - LANGUAGE=ko - Accept-Language: ko; q=1.000, *; q=0.001 LANGUAGE=ko:en

Re: [PATCH] http: Add Accept-Language header if possible

2014-07-08 Thread Yi, EungJun
2014-07-09 14:10 GMT+09:00 Jeff King p...@peff.net: On Wed, Jul 09, 2014 at 12:54:06AM +0900, Yi EungJun wrote: From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by 'LANGUAGE' environment variable if the variable

[PATCH v3] http: fix charset detection of extract_content_type()

2014-06-17 Thread Yi, EungJun
From: Yi EungJun eungjun...@navercorp.com extract_content_type() could not extract a charset parameter if the parameter is not the first one and there is a whitespace and a following semicolon just before the parameter. For example: text/plain; format=fixed ;charset=utf-8 And it also could

[PATCH v4] http: fix charset detection of extract_content_type()

2014-06-17 Thread Yi EungJun
From: Yi EungJun eungjun...@navercorp.com extract_content_type() could not extract a charset parameter if the parameter is not the first one and there is a whitespace and a following semicolon just before the parameter. For example: text/plain; format=fixed ;charset=utf-8 And it also could

Re: [PATCH] http-protocol.txt: Basic Auth is RFC 2617, not RFC 2616

2014-06-16 Thread Yi, EungJun
Thanks for your advice. i'll resend it. 2014-06-17 3:26 GMT+09:00 Junio C Hamano gits...@pobox.com: Yi EungJun semtlen...@gmail.com writes: Could you change the author to Yi EungJun eungjun...@navercorp.com if you apply this patch? You can send a patch with the desired From: line

[PATCH v2] http-protocol.txt: Basic Auth is RFC 2617, not RFC 2616

2014-06-16 Thread Yi, EungJun
From: Yi EungJun eungjun...@navercorp.com Signed-off-by: Yi EungJun eungjun...@navercorp.com --- Documentation/technical/http-protocol.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt

Re: [PATCH] http-protocol.txt: Basic Auth is RFC 2617, not RFC 2616

2014-06-15 Thread Yi EungJun
Could you change the author to Yi EungJun eungjun...@navercorp.com if you apply this patch? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] http: fix charset detection of extract_content_type()

2014-06-15 Thread Yi EungJun
Could you change the author to Yi EungJun eungjun...@navercorp.com if you apply this patch? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: More detailed error message for 403 forbidden.

2013-03-31 Thread Yi, EungJun
Maybe. But I would worry somewhat about sites which provide a useless and verbose text/plain message. Ideally an x-git-error-message would be no more than few lines, suitable for the error message of a terminal program. I would not want a site-branded Your page cannot be found. Here's a

More detailed error message for 403 forbidden.

2013-03-26 Thread Yi, EungJun
Currently, if user tried to access a git repository via HTTP and it fails because the user's permission is not enough to access the repository, git client tells that http request failed and the error was 403 forbidden. But It is not enough for user to understand why it fails, especially if the

Re: Remove all files except a few files, using filter-branch

2012-09-18 Thread Yi, EungJun
a32b84ed7cec5686e43a47195dfa8114f83619f3 (2/2) Ref 'refs/heads/master' was rewritten ~/filter-branch2$ git log -- b commit 19611f9eaf412232e237afcc059d0324a862062f Author: Yi EungJun semtlen...@gmail.com Date: Tue Sep 18 23:51:53 2012 +0900 first Am I doing something wrong? On Mon, Sep 17, 2012 at 2:06 AM, Andreas

Re: Remove all files except a few files, using filter-branch

2012-09-18 Thread Yi, EungJun
I think it should be '... git reset -q $GIT_COMMIT -- filename' It works! Thanks to Hannes and Andreas! On Wed, Sep 19, 2012 at 12:10 AM, Johannes Sixt j.s...@viscovery.net wrote: Am 9/18/2012 17:01, schrieb Yi, EungJun: --index-filter git rm --cached -qr -- . git reset -q -- filename Hmm

Re: How do I pronounce blob?

2012-09-15 Thread Yi, EungJun
Thanks for your help, Jan! On Sat, Sep 15, 2012 at 10:26 PM, Jan Engelhardt jeng...@inai.de wrote: On Saturday 2012-09-15 15:24, Yi, EungJun wrote: bee-lob or bla:b? http://en.wiktionary.org/wiki/blob BLOB as a Binary Large OBject reeks of a retronym. I guess bee-lob is correct if it means