Re: [PATCH] MSVC: link dynamically to the CRT

2014-05-03 Thread Marat Radchenko
On Wed, Apr 30, 2014 at 12:54:15PM -0700, Junio C Hamano wrote: Sebastian Schuberth sschube...@gmail.com writes: On 30.04.2014 20:36, Junio C Hamano wrote: I am not intimate with the msysgit developer community, and I do not know if it is appropriate for me to respond with a Does

Re: [PATCH] MSVC: link dynamically to the CRT

2014-04-30 Thread Junio C Hamano
Stepan Kasal ka...@ucw.cz writes: From: Karsten Blees bl...@dcon.de Date: Fri, 7 Jan 2011 17:20:21 +0100 Dynamic linking is generally preferred over static linking, and MSVCRT.dll has been integral part of Windows for a long time. This also fixes linker warnings for _malloc and _free in

Re: [PATCH] MSVC: link dynamically to the CRT

2014-04-30 Thread Sebastian Schuberth
On 30.04.2014 20:36, Junio C Hamano wrote: I am not intimate with the msysgit developer community, and I do not know if it is appropriate for me to respond with a Does this look OK with msysgit folks? This patch has been carried in the msysgit tree since more than 3 years, although

Re: [PATCH] MSVC: link dynamically to the CRT

2014-04-30 Thread Junio C Hamano
Sebastian Schuberth sschube...@gmail.com writes: On 30.04.2014 20:36, Junio C Hamano wrote: I am not intimate with the msysgit developer community, and I do not know if it is appropriate for me to respond with a Does this look OK with msysgit folks? This patch has been carried in the

Re: [PATCH] MSVC: link dynamically to the CRT

2014-04-30 Thread Stepan Kasal
Hello Junio, On Wed, Apr 30, 2014 at 11:36:37AM -0700, Junio C Hamano wrote: like I do not have to ask does this look ok? question when seeing a patch from Erik or J6t, is it unnecessary for me to do so for a patch from you? it _is_ necessary to ask, as I'm just a newcomer who has

[PATCH] MSVC: link dynamically to the CRT

2014-04-29 Thread Stepan Kasal
From: Karsten Blees bl...@dcon.de Date: Fri, 7 Jan 2011 17:20:21 +0100 Dynamic linking is generally preferred over static linking, and MSVCRT.dll has been integral part of Windows for a long time. This also fixes linker warnings for _malloc and _free in zlib.lib, which seems to be compiled for