Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
On Sun, Feb 03, 2013 at 06:37:42PM +, Anand Kumria wrote: Hi Pau, I've not been able to find the canonical location of your gitk repository. I've tried kernel.org, samba.org and ozlabs.org; none of them to have it - nor does any amount of google searching I do reveal the location. I realise you've probably had a busy month with linux.conf.au but it would be nice to have some feedback. Could you let me know where gitk is hosted and I'll re-roll this patch against that (and update the docs so others don't need to go hunting). It's at git://ozlabs.org/~paulus/gitk.git Paul. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
Hi Pau, I've not been able to find the canonical location of your gitk repository. I've tried kernel.org, samba.org and ozlabs.org; none of them to have it - nor does any amount of google searching I do reveal the location. I realise you've probably had a busy month with linux.conf.au but it would be nice to have some feedback. Could you let me know where gitk is hosted and I'll re-roll this patch against that (and update the docs so others don't need to go hunting). Thanks, Anand On 5 January 2013 19:38, Junio C Hamano gits...@pobox.com wrote: Anand Kumria wildf...@progsoc.org writes: Sorry, I didn't know that gitk had been split back out (and Documentation/gitk.txt still mentions it is part of the git suite). It is not split back at all, and it won't be. From git user's point of view it is part of the suite. Gitk however is still a viable freestanding project, so it would be selfish for me to take a patch to gitk-git/gitk directly to my tree, as the patch will not be able to flow back to the standalone gitk project. Hence we always let patches go through Paul's tree and then I pull from him. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
Hi Anand, Anand Kumria wrote: I've not been able to find the canonical location of your gitk repository. Here's how I find it: $ git clone git://repo.or.cz/git.git [...] $ cd git $ git log -1 --oneline -- gitk-git ec3ae6ec Merge git://ozlabs.org/~paulus/gitk $ cd .. $ git clone git://ozlabs.org/~paulus/gitk.git Patches, including documentation patches, go to git@vger.kernel.org, cc-ing Paul Mackerras. Hope that helps, Jonathan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
Jonathan Nieder jrnie...@gmail.com writes: Anand Kumria wrote: I've not been able to find the canonical location of your gitk repository. Here's how I find it: $ git clone git://repo.or.cz/git.git [...] $ cd git $ git log -1 --oneline -- gitk-git ec3ae6ec Merge git://ozlabs.org/~paulus/gitk $ cd .. $ git clone git://ozlabs.org/~paulus/gitk.git Patches, including documentation patches, go to git@vger.kernel.org, cc-ing Paul Mackerras. Or look at A note from the maintainer posted here every few months. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
Hi Junio, On 4 January 2013 23:50, Junio C Hamano gits...@pobox.com wrote: Anand Kumria wildf...@progsoc.org writes: By selecting a tag within gitk you can display information about it. This information is output by using the command 'git cat-file tag tagid' This outputs the *raw* information from the tag, amongst which is the time - in seconds since the epoch. As useful as that value is, I find it a lot easier to read and process time which it is something like: Mon Dec 31 14:26:11 2012 -0800 This change will modify the display of tags in gitk like so: @@ -1,7 +1,7 @@ object 5d417842efeafb6e109db7574196901c4e95d273 type commit tag v1.8.1 -tagger Junio C Hamano gits...@pobox.com 1356992771 -0800 +tagger Junio C Hamano gits...@pobox.com Mon Dec 31 14:26:11 2012 -0800 Git 1.8.1 -BEGIN PGP SIGNATURE- Signed-off-by: Anand Kumria wildf...@progsoc.org --- Sounds like a sensible thing to do but I didn't check how else (other than purely for displaying) this string is used. As far as I can tell it is only used for display (cached_tagcontent in gitk) purposes. Paul, the patch is not made against your tree, so if you choose to take it you would need to strip the leading directory at the top. Sorry, I didn't know that gitk had been split back out (and Documentation/gitk.txt still mentions it is part of the git suite). Regards, Anand -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
Anand Kumria wildf...@progsoc.org writes: Sorry, I didn't know that gitk had been split back out (and Documentation/gitk.txt still mentions it is part of the git suite). It is not split back at all, and it won't be. From git user's point of view it is part of the suite. Gitk however is still a viable freestanding project, so it would be selfish for me to take a patch to gitk-git/gitk directly to my tree, as the patch will not be able to flow back to the standalone gitk project. Hence we always let patches go through Paul's tree and then I pull from him. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] gitk: Display the date of a tag in a human friendly way.
By selecting a tag within gitk you can display information about it.
This information is output by using the command
'git cat-file tag tagid'
This outputs the *raw* information from the tag, amongst which is the
time - in seconds since the epoch. As useful as that value is, I find it
a lot easier to read and process time which it is something like:
Mon Dec 31 14:26:11 2012 -0800
This change will modify the display of tags in gitk like so:
@@ -1,7 +1,7 @@
object 5d417842efeafb6e109db7574196901c4e95d273
type commit
tag v1.8.1
-tagger Junio C Hamano gits...@pobox.com 1356992771 -0800
+tagger Junio C Hamano gits...@pobox.com Mon Dec 31 14:26:11 2012 -0800
Git 1.8.1
-BEGIN PGP SIGNATURE-
Signed-off-by: Anand Kumria wildf...@progsoc.org
---
gitk-git/gitk |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index d93bd99..aae1c58 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -10675,7 +10675,7 @@ proc showtag {tag isnew} {
set linknum 0
if {![info exists cached_tagcontent($tag)]} {
catch {
- set cached_tagcontent($tag) [exec git cat-file tag $tag]
+ set cached_tagcontent($tag) [exec git cat-file -p $tag]
}
}
if {[info exists cached_tagcontent($tag)]} {
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
Anand Kumria wildf...@progsoc.org writes:
By selecting a tag within gitk you can display information about it.
This information is output by using the command
'git cat-file tag tagid'
This outputs the *raw* information from the tag, amongst which is the
time - in seconds since the epoch. As useful as that value is, I find it
a lot easier to read and process time which it is something like:
Mon Dec 31 14:26:11 2012 -0800
This change will modify the display of tags in gitk like so:
@@ -1,7 +1,7 @@
object 5d417842efeafb6e109db7574196901c4e95d273
type commit
tag v1.8.1
-tagger Junio C Hamano gits...@pobox.com 1356992771 -0800
+tagger Junio C Hamano gits...@pobox.com Mon Dec 31 14:26:11 2012 -0800
Git 1.8.1
-BEGIN PGP SIGNATURE-
Signed-off-by: Anand Kumria wildf...@progsoc.org
---
Sounds like a sensible thing to do but I didn't check how else
(other than purely for displaying) this string is used.
Paul, the patch is not made against your tree, so if you choose to
take it you would need to strip the leading directory at the top.
Thanks.
PS. I haven't received a pull request from you for a while; are
there accumulated changes I should be pulling in before -rc0 of the
next release we are working on?
gitk-git/gitk |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index d93bd99..aae1c58 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -10675,7 +10675,7 @@ proc showtag {tag isnew} {
set linknum 0
if {![info exists cached_tagcontent($tag)]} {
catch {
- set cached_tagcontent($tag) [exec git cat-file tag $tag]
+ set cached_tagcontent($tag) [exec git cat-file -p $tag]
}
}
if {[info exists cached_tagcontent($tag)]} {
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
