On Wed, Jun 25, 2014 at 3:58 AM, Jeff King p...@peff.net wrote:
Here's a replacement patch that handles this (and just drops the ugly
mallocs as a side effect).
Shortly after I wrote my email, I thought about getenvdup() and look
for similar getenv/xstrdup patterns. But I saw only one in
Jeff King p...@peff.net writes:
Here's a replacement patch that handles this (and just drops the ugly
mallocs as a side effect).
-- 8 --
Subject: [PATCH] setup_git_env: copy getenv return value
The return value of getenv is not guaranteed to survive
across further invocations of setenv or
On Wed, Jun 25, 2014 at 10:20:13AM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
Here's a replacement patch that handles this (and just drops the ugly
mallocs as a side effect).
-- 8 --
Subject: [PATCH] setup_git_env: copy getenv return value
The return value of
Jeff King p...@peff.net writes:
On Wed, Jun 25, 2014 at 10:20:13AM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
Here's a replacement patch that handles this (and just drops the ugly
mallocs as a side effect).
-- 8 --
Subject: [PATCH] setup_git_env: copy getenv
On Mon, Jun 23, 2014 at 5:21 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Thu, Jun 19, 2014 at 5:28 PM, Jeff King p...@peff.net wrote:
This is shorter, harder to get wrong, and more clearly
captures the intent.
Signed-off-by: Jeff King p...@peff.net
---
I wondered if there was a
While it's about malloc..
On Fri, Jun 20, 2014 at 4:28 AM, Jeff King p...@peff.net wrote:
diff --git a/environment.c b/environment.c
index 4dac5e9..4de7b81 100644
--- a/environment.c
+++ b/environment.c
@@ -135,15 +135,11 @@ static void setup_git_env(void)
gitfile =
On Tue, Jun 24, 2014 at 08:30:26PM +0700, Duy Nguyen wrote:
On Fri, Jun 20, 2014 at 4:28 AM, Jeff King p...@peff.net wrote:
diff --git a/environment.c b/environment.c
index 4dac5e9..4de7b81 100644
--- a/environment.c
+++ b/environment.c
@@ -135,15 +135,11 @@ static void
On Thu, Jun 19, 2014 at 5:28 PM, Jeff King p...@peff.net wrote:
This is shorter, harder to get wrong, and more clearly
captures the intent.
Signed-off-by: Jeff King p...@peff.net
---
I wondered if there was a reason to avoid this (because we are in
setup_git_env, which can potentially be
Eric Sunshine sunsh...@sunshineco.com writes:
On Thu, Jun 19, 2014 at 5:28 PM, Jeff King p...@peff.net wrote:
This is shorter, harder to get wrong, and more clearly
captures the intent.
Signed-off-by: Jeff King p...@peff.net
---
I wondered if there was a reason to avoid this (because we
This is shorter, harder to get wrong, and more clearly
captures the intent.
Signed-off-by: Jeff King p...@peff.net
---
I wondered if there was a reason to avoid this (because we are in
setup_git_env, which can potentially be called by git_pathdup). But the
git_graft_file initialization below
10 matches
Mail list logo