Re: [PATCH v4 5/7] i18n: am: mark more strings for translation

2012-07-25 Thread Stefano Lattarini
Sorry to be so nit-picky, but ... On 07/25/2012 05:53 AM, Jiang Xin wrote: Mark strings in 'git-am.sh' for translation. In the last chunk, I changed '$1' to '-b/--binary' for this reason: * First, if there is a variable in the l10n message, we could not use gettext. Because the variable

Re: [PATCH v4 5/7] i18n: am: mark more strings for translation

2012-07-25 Thread Jiang Xin
2012/7/25 Stefano Lattarini stefano.lattar...@gmail.com: * Second, if there is a positional parameter ($1, $2,...) in the message, we could not use eval_gettext either. Because eval_gettext may be a wapper for gettext, and the positional parameter would loose it's original context.

[PATCH v4 5/7] i18n: am: mark more strings for translation

2012-07-24 Thread Jiang Xin
Mark strings in 'git-am.sh' for translation. In the last chunk, I changed '$1' to '-b/--binary' for this reason: * First, if there is a variable in the l10n message, we could not use gettext. Because the variable will be expanded (evaluated) and will never match the entry in the po file.

Re: [PATCH v4 5/7] i18n: am: mark more strings for translation

2012-07-24 Thread Jonathan Nieder
Jiang Xin wrote: Mark strings in 'git-am.sh' for translation. In the last chunk, I changed '$1' to '-b/--binary' for this reason: * First, if there is a variable in the l10n message, we could not use gettext. Because the variable will be expanded (evaluated) and will never match the