(cc-ing some area experts)
Hi Andrej,
Andrej Andb wrote:
[Subject: remove protocol from gravatar and picon links for clear if
Gitweb is being called through a secure server]
Sounds good to me. May we have your signoff? (See
Documentation/SubmittingPatches for what this means.)
Thanks,
Jonathan Nieder jrnie...@gmail.com writes:
(cc-ing some area experts)
Hi Andrej,
Andrej Andb wrote:
[Subject: remove protocol from gravatar and picon links for clear if
Gitweb is being called through a secure server]
Sounds good to me. May we have your signoff? (See
Junio C Hamano gits...@pobox.com writes:
-
http://www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/; .
+ //www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/
.
Hrmph. Is that even a valid URL to refer to that external site from
a
Junio C Hamano wrote:
Andrej Andb wrote:
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2068,7 +2068,7 @@ sub picon_url {
if (!$avatar_cache{$email}) {
my ($user, $domain) = split('@', $email);
$avatar_cache{$email} =
-
Jonathan Nieder jrnie...@gmail.com writes:
Junio C Hamano wrote:
Andrej Andb wrote:
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2068,7 +2068,7 @@ sub picon_url {
if (!$avatar_cache{$email}) {
my ($user, $domain) = split('@', $email);
Or maybe option like:
/etc/gitweb.conf:
$feature{'ssl'}{'default'} = ['allways']; ['auto']; ['none'];
but it's hard for me :) i don't know perl
2013/1/29 Junio C Hamano gits...@pobox.com:
Jonathan Nieder jrnie...@gmail.com writes:
Junio C Hamano wrote:
Andrej Andb wrote:
---
Junio C Hamano wrote:
I am sure mixed content warning was the primary motivation of the
patch.
Sure, but that's not enough motivation for me to like it. ;-)
The privacy aspect is enough to motivate it for me.
Do we know these external sites actually server what we want
over
Андрей Баранов ad...@andrej-andb.ru writes:
Or maybe option like:
/etc/gitweb.conf:
$feature{'ssl'}{'default'} = ['allways']; ['auto']; ['none'];
but it's hard for me :) i don't know perl
The effect is the same and your original patch is shorter and
cleaner to see what is going on; as far
re sended. Very big thanks for example :D
2013/1/29 Junio C Hamano gits...@pobox.com:
Андрей Баранов ad...@andrej-andb.ru writes:
Or maybe option like:
/etc/gitweb.conf:
$feature{'ssl'}{'default'} = ['allways']; ['auto']; ['none'];
but it's hard for me :) i don't know perl
The effect is
9 matches
Mail list logo
