Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not work (no editor is launched and the
whole hunk is committed).
Benoit Pierre benoit.pie...@gmail.com writes:
+test_expect_failure 'edit hunk commit -p -m message' '
+ test_when_finished rm -f editor_was_started
Not just when finished, run rm -f here to make sure that the
file does not exist. Later other people may add new tests before
this test
On Mon, Mar 17, 2014 at 7:49 PM, Junio C Hamano gits...@pobox.com wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not
On Mon, Mar 17, 2014 at 3:46 PM, Benoit Pierre benoit.pie...@gmail.com wrote:
On Mon, Mar 17, 2014 at 7:49 PM, Junio C Hamano gits...@pobox.com wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will
On Mon, Mar 17, 2014 at 7:53 PM, Junio C Hamano gits...@pobox.com wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
+test_expect_failure 'edit hunk commit -p -m message' '
+ test_when_finished rm -f editor_was_started
Not just when finished, run rm -f here to make sure that the
file
On Mon, Mar 17, 2014 at 8:51 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Mon, Mar 17, 2014 at 3:46 PM, Benoit Pierre benoit.pie...@gmail.com
wrote:
On Mon, Mar 17, 2014 at 7:49 PM, Junio C Hamano gits...@pobox.com wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
[...]
diff
Benoit Pierre benoit.pie...@gmail.com writes:
On Mon, Mar 17, 2014 at 7:49 PM, Junio C Hamano gits...@pobox.com wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will be used (by setting GIT_EDITOR
Benoit Pierre benoit.pie...@gmail.com writes:
Isn't the point of using when finished to have each test leave the
tree clean after execution, to avoid bleeding onto the next test(s)?
But you cannot anticipate what other people will do in the future
before you have a chance to run this piece.
On 2014-03-11 22.03, Junio C Hamano wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not work (no editor is launched and
On Sat, Mar 15, 2014 at 1:28 PM, Torsten Bögershausen tbo...@web.de wrote:
On 2014-03-11 22.03, Junio C Hamano wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to
On 2014-03-15 17.11, Benoit Pierre wrote:
On Sat, Mar 15, 2014 at 1:28 PM, Torsten Bögershausen tbo...@web.de wrote:
On 2014-03-11 22.03, Junio C Hamano wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) test: with commit changing the environment to let hooks
now that no
Eric Sunshine sunsh...@sunshineco.com writes:
On Mon, Mar 10, 2014 at 2:49 PM, Benoit Pierre benoit.pie...@gmail.com
wrote:
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not work (no editor is launched and the
whole hunk is committed).
Signed-off-by:
On Mon, Mar 10, 2014 at 2:49 PM, Benoit Pierre benoit.pie...@gmail.com wrote:
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not work (no editor is launched and the
whole hunk
mincro nit.
From: Benoit Pierre benoit.pie...@gmail.com
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to :), the
s/now/know/
edit hunk functionality does not work (no editor is launched and the
whole hunk is
15 matches
Mail list logo