Re: [PATCH v5 00/12] Update git revisions

[Junio C Hamano]

"Philip Oakley"  writes:

> I'll work on the tweaks, though it'll probably be tomorrow as we have
> visitors.

Thank you for working on this; Marc, thank you for many good review
comments.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 00/12] Update git revisions

[Philip Oakley]

From: "Marc Branchaud" 

On 2016-08-12 03:07 AM, Philip Oakley wrote:

[2nd attempt : ISP troubles]

This has grown like topsy from a little two patch series that tried to
name the 2-dots notation [1] into this extended set of tweaks.


Honestly, I start just trying point out something concrete, like 
misrendered headers, but then I figure since I'm sending a review comment 
anyway I might as well go in-depth on the rest of the patch.


I think I'm sticking to substantive comments, but if I'm getting too picky 
please just swat me down!


No, that's fine. It's important to at least review these points.

I thought I'd picked up all the issues, but it looks like I missed at least 
one.


The caret thing has a bit of history - see 87c6aeb4efdd43559

It looks like its the two carets on a line mean superscript (Unconstrained 
quotes) and that maybe the issue.


Then it looks like {caret} does a replacement, though I can't find that in 
the asciidoc user guide.



I don't quite understand why the ^ symbols work for the Loliger examples, 
but hey ho, it's good they do...


I'll work on the tweaks, though it'll probably be tomorrow as we have 
visitors.


--
Philip 


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 00/12] Update git revisions

[Marc Branchaud]

On 2016-08-12 03:07 AM, Philip Oakley wrote:

[2nd attempt : ISP troubles]

This has grown like topsy from a little two patch series that tried to
name the 2-dots notation [1] into this extended set of tweaks.


Honestly, I start just trying point out something concrete, like 
misrendered headers, but then I figure since I'm sending a review 
comment anyway I might as well go in-depth on the rest of the patch.


I think I'm sticking to substantive comments, but if I'm getting too 
picky please just swat me down!


M.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 00/12] Update git revisions

[Philip Oakley]

I'm having trouble with my ISP is not playing ball. only cover and patch 1 
were sent.


Will retry with alternate service.

Philip
- Original Message - 
From: "Philip Oakley" 

Sent: Thursday, August 11, 2016 10:50 PM
Subject: [PATCH v5 00/12] Update git revisions



This has grown like topsy from a little two patch series that tried to
name the 2-dots notation [1] into this extended set of tweaks.

As documentation can be rather personal, I've split out each small change
so each can be individually justified.

Since V4, I've confirmed that the format breaking issue is that we cannot
quote code in headings in the man page layout - ultimately it's a docbook
decision, and follows the line of analysis Peff identified (see commentary
in the patch).

In addition the multi-parent notations have been clarified and extended.

Thus the old patch 4 has been split into three. The first three patches 
are

unchanged. The following 4 patches are also unchanged.

Finally, at the end an extra 2 patches are added to build up the examples 
by

including details of the notation expansions.

This updates po/range-doc (2016-07-20) 8 commits.

Hopefully my updated workflow will get the right patches to the right 
people.


[1] 
https://public-inbox.org/git/0648000B273C412AB7140AE959EBC99A%40PhilipOakley/


Philip Oakley (12):
 doc: use 'symmetric difference' consistently
 doc: revisions - name the left and right sides
 doc: show the actual left, right, and boundary marks
 doc: revisions: give headings for the two and three dot notations
 doc: revisions: extra clarification of ^! notation effects
 doc: revisions: single vs multi-parent notation comparison
 doc: gitrevisions - use 'reachable' in page description
 doc: gitrevisions - clarify 'latter case' is revision walk
 doc: revisions  - define `reachable`
 doc: revisions - clarify reachability examples
 doc: revisions: show revision expansion in examples
 doc: revisions: sort examples and fix alignment of the unchanged

Documentation/gitk.txt |   2 +-
Documentation/gitrevisions.txt |   6 +-
Documentation/pretty-formats.txt   |   2 +-
Documentation/rev-list-options.txt |   4 +-
Documentation/revisions.txt| 121 
+++--

5 files changed, 84 insertions(+), 51 deletions(-)

--
2.9.0.windows.1





--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html