Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Junio C Hamano
Sverre Rabbelier writes: > On Mon, Nov 26, 2012 at 11:26 AM, Johannes Schindelin > wrote: >>> We added rev_cmdline_info since then so that we can tell what refs >>> were given from the command line in what way, and I thought that we >>> applied a patch from Sverre that uses it instead of the obj

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Sverre Rabbelier
On Mon, Nov 26, 2012 at 11:26 AM, Johannes Schindelin wrote: >> We added rev_cmdline_info since then so that we can tell what refs >> were given from the command line in what way, and I thought that we >> applied a patch from Sverre that uses it instead of the object >> flags. Am I misremembering

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Johannes Schindelin
Hi Junio, On Mon, 26 Nov 2012, Junio C Hamano wrote: > Johannes Schindelin writes: > > > If you changed your stance on the patch Sverre and I sent to fix this, > > we could get a non-partial fix for this. > > This is long time ago so I may be misremembering the details, but I > thought the ori

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Junio C Hamano
Johannes Schindelin writes: > If you changed your stance on the patch Sverre and I sent to fix this, we > could get a non-partial fix for this. This is long time ago so I may be misremembering the details, but I thought the original patch was (ab)using object flags to mark "this was explicitly a

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Johannes Schindelin
Hi Junio, On Sun, 25 Nov 2012, Junio C Hamano wrote: > From: Johannes Schindelin > Subject: Re: [PATCH v3 4/4] fast-export: make sure refs are updated properly > Date: Fri, 2 Nov 2012 16:17:14 +0100 (CET) > Message-ID: > > > (which is $gmane/208946) that says: > > Note that > >

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-25 Thread Junio C Hamano
Felipe Contreras writes: > On Wed, Nov 21, 2012 at 8:48 PM, Jeff King wrote: > ... > I would like to understand that that even means. What behavior is > currently broken? I do not know if this is the same as what Peff was referring to, but I found this message in the discussion thread during my

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-22 Thread Max Horn
On 21.11.2012, at 06:08, Junio C Hamano wrote: > Jonathan Nieder writes: > >> Never mind that others have said that that's not the current interface >> (I don't yet see why it would be a good interface after a transition, >> but maybe it would be). Still, hopefully that clarifies the intended >

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-22 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 8:48 PM, Jeff King wrote: > On Tue, Nov 20, 2012 at 09:08:36PM -0800, Junio C Hamano wrote: > >> With such a one-sided discussion, I've been having a hard time >> convincing myself if Felipe's effort is making the interface better, >> or just breaking it even more for exist

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-22 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 11:30 PM, Max Horn wrote: > 2) Some are interfaces to foreign systems (bzr, hg, mediawiki, ...). They > cannot use sha1s and must use marks (at least that is how I understand > felipe's explanation). These tools use import combined with either export, or > push. Example

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-21 Thread Jeff King
On Tue, Nov 20, 2012 at 09:08:36PM -0800, Junio C Hamano wrote: > With such a one-sided discussion, I've been having a hard time > convincing myself if Felipe's effort is making the interface better, > or just breaking it even more for existing remote helpers, only to > fit his world model better.

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-21 Thread Junio C Hamano
Felipe Contreras writes: > They have been marked as UNINTERESTING for a reason, lets respect that. > ... > The current behavior is most certainly not what we want. After this > patch, nothing gets exported, because nothing was selected (everything > is UNINTERESTING). The old behaviour was an in

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 6:08 AM, Junio C Hamano wrote: > I see Felipe keeps repeating that there are bugs, and keeps posting > patches to change fast-export, but I haven't seen a concrete "No, > the reason why you see these problems is because you are not using > the interface correctly; the curr

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Junio C Hamano
Jonathan Nieder writes: > Never mind that others have said that that's not the current interface > (I don't yet see why it would be a good interface after a transition, > but maybe it would be). Still, hopefully that clarifies the intended > meaning. Care to explain how the current interface is

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 5:17 AM, Jonathan Nieder wrote: > Junio C Hamano wrote: >> Felipe Contreras writes: > >>> Of course, transport-helper shouldn't even be specifying the negative >>> (^) refs, but that's another story. >> >> Hrm, I am not sure I understand what you mean by this. >> >> How sh

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Jonathan Nieder
Junio C Hamano wrote: > Felipe Contreras writes: >> Of course, transport-helper shouldn't even be specifying the negative >> (^) refs, but that's another story. > > Hrm, I am not sure I understand what you mean by this. > > How should it be telling the fast-export up to what commit the > receivin

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Junio C Hamano
Felipe Contreras writes: > Of course, transport-helper shouldn't even be specifying the negative > (^) refs, but that's another story. Hrm, I am not sure I understand what you mean by this. How should it be telling the fast-export up to what commit the receiving end should already have the hist