t3200-branch.sh number 102 fails when run under make test

2014-07-09 Thread Keller, Jacob E
Hello,

I recently cloned the master branch of the git repo, and when I ran make
test, it fails on test 102 of the t3200-branch.sh test cases.

not ok 102 - tracking with unexpected .fetch refspec
#
#   rm -rf a b c d 
#   git init a 
#   (
#   cd a 
#   test_commit a
#   ) 
#   git init b 
#   (
#   cd b 
#   test_commit b
#   ) 
#   git init c 
#   (
#   cd c 
#   test_commit c 
#   git remote add a ../a 
#   git remote add b ../b 
#   git fetch --all
#   ) 
#   git init d 
#   (
#   cd d 
#   git remote add c ../c 
#   git config remote.c.fetch 
+refs/remotes/*:refs/remotes/* 
#   git fetch c 
#   git branch --track local/a/master remotes/a/master 
#   test $(git config branch.local/a/master.remote) = c 

#   test $(git config branch.local/a/master.merge) = 
refs/remotes/a/master 
#   git rev-parse --verify a expect 
#   git rev-parse --verify local/a/master actual 
#   test_cmp expect actual
#   )
#
# failed 1 among 102 test(s)
1..102

However, when I run the test file manually it passes. I am currently
running through a verbose output test run to see if I can find more
useful output..

For reference, the commit I am testing against is:

72c779457cd7 (line-log: use commit_list_append() instead of duplicating its 
code)

Thanks,
Jake
N�r��yb�X��ǧv�^�)޺{.n�+ا���ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z��w���?��)ߢf

Re: t3200-branch.sh number 102 fails when run under make test

2014-07-09 Thread Jeff King
On Wed, Jul 09, 2014 at 08:37:51PM +, Keller, Jacob E wrote:

 I recently cloned the master branch of the git repo, and when I ran make
 test, it fails on test 102 of the t3200-branch.sh test cases.

Just a guess, but try reverting 745224e (refs.c: SSE2 optimizations for
check_refname_component, 2014-06-18).

That commit causes some weird memory accesses that only show up under
certain conditions[1]. There's a possible fix that is not yet applied,
but reverting should be an easy way to test.

-Peff

[1] http://thread.gmane.org/gmane.comp.version-control.git/252881
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: t3200-branch.sh number 102 fails when run under make test

2014-07-09 Thread Keller, Jacob E
On Wed, 2014-07-09 at 13:37 -0700, Jacob E Keller wrote:
 Hello,
 
 I recently cloned the master branch of the git repo, and when I ran make
 test, it fails on test 102 of the t3200-branch.sh test cases.
 
 not ok 102 - tracking with unexpected .fetch refspec
 #
 #   rm -rf a b c d 
 #   git init a 
 #   (
 #   cd a 
 #   test_commit a
 #   ) 
 #   git init b 
 #   (
 #   cd b 
 #   test_commit b
 #   ) 
 #   git init c 
 #   (
 #   cd c 
 #   test_commit c 
 #   git remote add a ../a 
 #   git remote add b ../b 
 #   git fetch --all
 #   ) 
 #   git init d 
 #   (
 #   cd d 
 #   git remote add c ../c 
 #   git config remote.c.fetch 
 +refs/remotes/*:refs/remotes/* 
 #   git fetch c 
 #   git branch --track local/a/master remotes/a/master 
 #   test $(git config branch.local/a/master.remote) = 
 c 
 #   test $(git config branch.local/a/master.merge) = 
 refs/remotes/a/master 
 #   git rev-parse --verify a expect 
 #   git rev-parse --verify local/a/master actual 
 #   test_cmp expect actual
 #   )
 #
 # failed 1 among 102 test(s)
 1..102
 
 However, when I run the test file manually it passes. I am currently
 running through a verbose output test run to see if I can find more
 useful output..
 
 For reference, the commit I am testing against is:
 
 72c779457cd7 (line-log: use commit_list_append() instead of duplicating its 
 code)
 
 Thanks,
 Jake

I ran the test wit the GIT_TEST_OPS set to --verbose, and the output I got is:
expecting success: 
rm -rf a b c d 
git init a 
(
cd a 
test_commit a
) 
git init b 
(
cd b 
test_commit b
) 
git init c 
(
cd c 
test_commit c 
git remote add a ../a 
git remote add b ../b 
git fetch --all
) 
git init d 
(
cd d 
git remote add c ../c 
git config remote.c.fetch +refs/remotes/*:refs/remotes/* 
git fetch c 
git branch --track local/a/master remotes/a/master 
test $(git config branch.local/a/master.remote) = c 
test $(git config branch.local/a/master.merge) = 
refs/remotes/a/master 
git rev-parse --verify a expect 
git rev-parse --verify local/a/master actual 
test_cmp expect actual
)

Initialized empty Git repository in /home/jekeller/git/git/t/trash 
directory.t3200-branch/a/.git/
[master (root-commit) ce450c7] a
 Author: A U Thor aut...@example.com
 1 file changed, 1 insertion(+)
 create mode 100644 a.t
Initialized empty Git repository in /home/jekeller/git/git/t/trash 
directory.t3200-branch/b/.git/
[master (root-commit) 19acec0] b
 Author: A U Thor aut...@example.com
 1 file changed, 1 insertion(+)
 create mode 100644 b.t
Initialized empty Git repository in /home/jekeller/git/git/t/trash 
directory.t3200-branch/c/.git/
[master (root-commit) ea1ac38] c
 Author: A U Thor aut...@example.com
 1 file changed, 1 insertion(+)
 create mode 100644 c.t
fatal: Invalid refspec '+refs/heads/*:refs/remotes/b/*'
not ok 102 - tracking with unexpected .fetch refspec
#   
#   rm -rf a b c d 
#   git init a 
#   (
#   cd a 
#   test_commit a
#   ) 
#   git init b 
#   (
#   cd b 
#   test_commit b
#   ) 
#   git init c 
#   (
#   cd c 
#   test_commit c 
#   git remote add a ../a 
#   git remote add b ../b 
#   git fetch --all
#   ) 
#   git init d 
#   (
#   cd d 
#   git remote add c ../c 
#   git config remote.c.fetch 
+refs/remotes/*:refs/remotes/* 
#   git fetch c 
#   git branch --track local/a/master remotes/a/master 
#   test $(git config branch.local/a/master.remote) = c 

#   test $(git config branch.local/a/master.merge) = 
refs/remotes/a/master 
#   git rev-parse --verify a expect 
#   git rev-parse --verify local/a/master actual 
#

Re: t3200-branch.sh number 102 fails when run under make test

2014-07-09 Thread Keller, Jacob E
On Wed, 2014-07-09 at 16:54 -0400, Jeff King wrote:
 On Wed, Jul 09, 2014 at 08:37:51PM +, Keller, Jacob E wrote:
 
  I recently cloned the master branch of the git repo, and when I ran make
  test, it fails on test 102 of the t3200-branch.sh test cases.
 
 Just a guess, but try reverting 745224e (refs.c: SSE2 optimizations for
 check_refname_component, 2014-06-18).
 
 That commit causes some weird memory accesses that only show up under
 certain conditions[1]. There's a possible fix that is not yet applied,
 but reverting should be an easy way to test.
 
 -Peff
 
 [1] http://thread.gmane.org/gmane.comp.version-control.git/252881
 --
 To unsubscribe from this list: send the line unsubscribe git in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yes, performing the revert appears to fix the issue. Hopefully the
proposed fix also works.

Thanks,
Jake
N�r��yb�X��ǧv�^�)޺{.n�+ا���ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z��w���?��)ߢf