[PATCH/RFC] grep: add a grep.patternType configuration setting

2012-08-03 Thread J Smith
The grep.extendedRegexp configuration setting enables the -E flag on grep by default but there are no equivalents for the -G, -F and -P flags. Rather than adding an additional setting for grep.fooRegexp for current and future pattern matching options, add a grep.patternType setting that can

Re: [PATCH/RFC] grep: add a grep.patternType configuration setting

2012-08-02 Thread J Smith
Alright, I have revised the patch and fixed up the nits that were picked and made a quick modification. I've added a setting for grep.patternType for default which can restore the default grep pattern matching behaviour and restores the functionality back to grep.extendedRegexp. I added this

[PATCH/RFC] grep: add a grep.patternType configuration setting

2012-08-01 Thread J Smith
Adds the grep.patternType configuration setting which sets the default pattern matching behavior. The values basic, extended, fixed, and perl can be used to set --basic-regexp, --extended-regexp, --fixed-strings, and --perl-regexp options by default respectively. A value of true is equivalent to

Re: [PATCH/RFC] grep: add a grep.patternType configuration setting

2012-08-01 Thread Junio C Hamano
J Smith dark.pa...@gmail.com writes: As the basic structure and the direction looks good, let's start nitpicking ;-) Adds the grep.patternType configuration setting which sets the default pattern matching behavior. The values basic, extended, fixed, and perl can be used to set --basic-regexp,

Re: [PATCH/RFC] grep: add a grep.patternType configuration setting

2012-08-01 Thread Štěpán Němec
On Wed, 01 Aug 2012 14:55:52 -0700 Junio C. Hamano wrote: J Smith dark.pa...@gmail.com writes: grep.extendedRegexp:: -If set to true, enable '--extended-regexp' option by default. +If set to true, enable '--extended-regexp' option by default. This +option is ignored when the

Re: [PATCH/RFC] grep: add a grep.patternType configuration setting

2012-08-01 Thread J Smith
On Wed, Aug 1, 2012 at 5:55 PM, Junio C Hamano gits...@pobox.com wrote: As the basic structure and the direction looks good, let's start nitpicking ;-) Sounds good. We tend to write the commit log message in imperative mood, as if you are giving an order to the codebase to behave this way!.