Re: [PATCH] Unify appending signoff in format-patch, commit and sequencer

2012-11-15 Thread Nguyen Thai Ngoc Duy
On Fri, Nov 16, 2012 at 3:42 AM, Brandon Casey wrote: >> Interestingly this patch triggers the fault that it fixes. >> I was surprised that there was no blank line before my S-o-b >> and thought I broke something. It turns out I used unmodified >> format-patch and it mistook the S-o-b quote as

Re: [PATCH] Unify appending signoff in format-patch, commit and sequencer

2012-11-15 Thread Brandon Casey
On Thu, Nov 15, 2012 at 4:32 AM, Nguyễn Thái Ngọc Duy wrote: > There are two implementations of append_signoff in log-tree.c and > sequencer.c, which do more or less the same thing. This patch > > - teaches sequencer.c's append_signoff() not to append the signoff if >it's already there but no

[PATCH] Unify appending signoff in format-patch, commit and sequencer

2012-11-15 Thread Nguyễn Thái Ngọc Duy
There are two implementations of append_signoff in log-tree.c and sequencer.c, which do more or less the same thing. This patch - teaches sequencer.c's append_signoff() not to append the signoff if it's already there but not at the bottom - removes log-tree.c's - make sure "Signed-off-by: