Re: [PATCH] send-email: support NNTP

2013-04-25 Thread Łukasz Stelmach
It was 2013-04-24 śro 18:17, when Junio C Hamano wrote: l.stelm...@samsung.com (Łukasz Stelmach) writes: It was 2013-04-23 wto 17:02, when Junio C Hamano wrote: Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). --- The patch implements

Re: [PATCH] send-email: support NNTP

2013-04-25 Thread Łukasz Stelmach
It was 2013-04-25 czw 00:41, when Junio C Hamano wrote: Thomas Rast tr...@inf.ethz.ch writes: Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). I'm surprised Junio didn't mention this: your patch lacks the Signed-off-by. Heh, that was

Re: [PATCH] send-email: support NNTP

2013-04-25 Thread Junio C Hamano
l.stelm...@samsung.com (Łukasz Stelmach) writes: OK, I see. Good point. Where would you recommend me to put these modules and how to name them? I mean I don't want to make to much mess here (; I would not recommend you to do any of the above now. As I said, the open-coded if/elsif cascade

Re: [PATCH] send-email: support NNTP

2013-04-25 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: l.stelm...@samsung.com (Łukasz Stelmach) writes: OK, I see. Good point. Where would you recommend me to put these modules and how to name them? I mean I don't want to make to much mess here (; I would not recommend you to do any of the above now. As

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Eric Sunshine
On Tue, Apr 23, 2013 at 7:13 AM, Łukasz Stelmach l.stelm...@samsung.com wrote: Enable sending patches to NNTP servers (Usenet, Gmane). --- diff --git a/git-send-email.perl b/git-send-email.perl index bd13cc8..0356635 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1174,6

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Łukasz Stelmach
It was 2013-04-24 śro 09:19, when Eric Sunshine wrote: On Tue, Apr 23, 2013 at 7:13 AM, Łukasz Stelmach l.stelm...@samsung.com wrote: Enable sending patches to NNTP servers (Usenet, Gmane). --- diff --git a/git-send-email.perl b/git-send-email.perl index bd13cc8..0356635 100755 ---

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Łukasz Stelmach
It was 2013-04-23 wto 17:02, when Junio C Hamano wrote: Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). --- The patch implements support for sending messages to groups on NNTP serviers. Cute. A Perl guru might want to encapsulate the

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Thomas Rast
Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). I'm surprised Junio didn't mention this: your patch lacks the Signed-off-by. + if ($email_protocol eq 'nntp') { + $header = Newsgroups: $to\n . $header; + } else { +

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Łukasz Stelmach
It was 2013-04-24 śro 09:38, when Thomas Rast wrote: Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). I'm surprised Junio didn't mention this: your patch lacks the Signed-off-by. +if ($email_protocol eq 'nntp') { +

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Thomas Rast
l.stelm...@samsung.com (Łukasz Stelmach) writes: It was 2013-04-24 śro 09:38, when Thomas Rast wrote: Łukasz Stelmach l.stelm...@samsung.com writes: + if ($email_protocol eq 'nntp') { + $header = Newsgroups: $to\n . $header; + } else { + $header = To: $to${ccline}\n

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Junio C Hamano
l.stelm...@samsung.com (Łukasz Stelmach) writes: It was 2013-04-23 wto 17:02, when Junio C Hamano wrote: Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). --- The patch implements support for sending messages to groups on NNTP

Re: [PATCH] send-email: support NNTP

2013-04-24 Thread Junio C Hamano
Thomas Rast tr...@inf.ethz.ch writes: Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). I'm surprised Junio didn't mention this: your patch lacks the Signed-off-by. Heh, that was because I took the patch as an early preview and not a

[PATCH] send-email: support NNTP

2013-04-23 Thread Łukasz Stelmach
Enable sending patches to NNTP servers (Usenet, Gmane). --- The patch implements support for sending messages to groups on NNTP serviers. The patch does not (attempts not to) change the default behavior i.e. to use sendmail and/or Net::SMTP. To use NNTP one needs to configure the server (see the

Re: [PATCH] send-email: support NNTP

2013-04-23 Thread Junio C Hamano
Łukasz Stelmach l.stelm...@samsung.com writes: Enable sending patches to NNTP servers (Usenet, Gmane). --- The patch implements support for sending messages to groups on NNTP serviers. Cute. A Perl guru might want to encapsulate the differences between $smtp and $nntp codepaths into two