Re: [PATCH] sequencer: support folding in rfc2822 footer

2016-09-06 Thread Jeff King
On Tue, Sep 06, 2016 at 04:30:24PM -0700, Jonathan Tan wrote: > On 09/06/2016 03:08 PM, Jonathan Tan wrote: > > On 09/02/2016 07:23 PM, Junio C Hamano wrote: > > > A slightly related tangent. An unconditionally good change you > > > could make is to allow folding of in-body headers. I.e. you can

Re: [PATCH] sequencer: support folding in rfc2822 footer

2016-09-06 Thread Jonathan Tan
On 09/06/2016 03:08 PM, Jonathan Tan wrote: On 09/02/2016 07:23 PM, Junio C Hamano wrote: A slightly related tangent. An unconditionally good change you could make is to allow folding of in-body headers. I.e. you can have e.g. -- >8 -- Subject: [PATCH] sequencer: support in-body heade

Re: [PATCH] sequencer: support folding in rfc2822 footer

2016-09-06 Thread Jonathan Tan
On 09/02/2016 07:23 PM, Junio C Hamano wrote: Jonathan Tan writes: Sample-field: multiple-line field body that causes a blank line below I am not sure this is unconditionally good, or may cause problems to those with workflows you did not consider when you wrote this patch. Not being too l

Re: [PATCH] sequencer: support folding in rfc2822 footer

2016-09-02 Thread Junio C Hamano
Jonathan Tan writes: > Sample-field: multiple-line field body > that causes a blank line below I am not sure this is unconditionally good, or may cause problems to those with workflows you did not consider when you wrote this patch. Not being too lenient here historically has been a deliberate

[PATCH] sequencer: support folding in rfc2822 footer

2016-09-02 Thread Jonathan Tan
When running `git cherry-pick -x`, a blank line would be inserted if a line in the footer was broken into multiple lines (which is inconsistent with its behavior if no lines were broken). For example, this command would produce: --- Sample-field: no blank line below (cherry picked from commit ...)