Re: [PATCH] submodule-config: use explicit empty string instead of strbuf in config_from()

Heiko Voigt writes: > Thats a good idea. Can send a patch, but I noticed that your change is > already in next and my change has not been picked up. So I am unsure if > I should base my patches on next or if Junio wants to keep your change? When you noticed something you want

Re: [PATCH] submodule-config: use explicit empty string instead of strbuf in config_from()

Hi, On Thu, Jul 21, 2016 at 08:57:03PM +0200, René Scharfe wrote: > >diff --git a/submodule-config.c b/submodule-config.c > >index 077db40..dccea59 100644 > >--- a/submodule-config.c > >+++ b/submodule-config.c [...] > >@@ -431,14 +432,19 @@ static const struct submodule *config_from(struct >

Re: [PATCH] submodule-config: use explicit empty string instead of strbuf in config_from()

Am 20.07.2016 um 10:25 schrieb Heiko Voigt: Hi, On Tue, Jul 19, 2016 at 09:05:43PM +0200, René Scharfe wrote: Use a string constant instead of an empty strbuf to shorten the code and make it easier to read. This must have been some oversight from my original code. I also can not see any

Re: [PATCH] submodule-config: use explicit empty string instead of strbuf in config_from()

Hi, On Tue, Jul 19, 2016 at 09:05:43PM +0200, René Scharfe wrote: > Use a string constant instead of an empty strbuf to shorten the code > and make it easier to read. This must have been some oversight from my original code. I also can not see any purpose. > Signed-off-by: Rene Scharfe

Re: [PATCH] submodule-config: use explicit empty string instead of strbuf in config_from()

On Tue, Jul 19, 2016 at 12:15 PM, Junio C Hamano wrote: > René Scharfe writes: > >> Use a string constant instead of an empty strbuf to shorten the code >> and make it easier to read. >> >> Signed-off-by: Rene Scharfe >> --- >> ... unless someone

Re: [PATCH] submodule-config: use explicit empty string instead of strbuf in config_from()

René Scharfe writes: > Use a string constant instead of an empty strbuf to shorten the code > and make it easier to read. > > Signed-off-by: Rene Scharfe > --- > ... unless someone can come up with a suitable non-empty string to feed > to git_config_from_mem() as its

[PATCH] submodule-config: use explicit empty string instead of strbuf in config_from()

Use a string constant instead of an empty strbuf to shorten the code and make it easier to read. Signed-off-by: Rene Scharfe --- ... unless someone can come up with a suitable non-empty string to feed to git_config_from_mem() as its name parameter. submodule-config.c | 3 +-- 1