Re: [PATCH] t3400 (rebase): add failing test for a peculiar rev spec

2013-04-19 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> peel_committish () { >> case "$1" in >> :/*) >> peeltmp=$(git rev-parse --verify "$1") && >> git rev-parse --verify "$peeltmp^0" >>

Re: [PATCH] t3400 (rebase): add failing test for a peculiar rev spec

2013-04-19 Thread Junio C Hamano
Junio C Hamano writes: > That would make this > > ":/!(a=Ramkumar)(s=move diff.wordRegex)~4" > > a way to find the fourth-generation parent of ... ... 0b830ac52137 (Documentation: move diff.wordRegex from config.txt to diff-config.txt, 2012-11-13) I had a log output on another terminal an

Re: [PATCH] t3400 (rebase): add failing test for a peculiar rev spec

2013-04-19 Thread Junio C Hamano
Ramkumar Ramachandra writes: > I'm more interested in knowing what you think of my first point: is > :/text fundamentally broken, as it can't be combined with other > operators like the other rev specs can? If so, how do you think we > should fix it? The question :/string wants to ask is fundam

Re: [PATCH] t3400 (rebase): add failing test for a peculiar rev spec

2013-04-19 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > peel_committish () { > case "$1" in > :/*) > peeltmp=$(git rev-parse --verify "$1") && > git rev-parse --verify "$peeltmp^0" > ;; > *) >

Re: [PATCH] t3400 (rebase): add failing test for a peculiar rev spec

2013-04-18 Thread Junio C Hamano
Ramkumar Ramachandra writes: > 'git rebase' does not recognize revisions specified as :/text. This > is because the attempts to rev-parse ${REV}^0, which fails in this > case. Add a test to document this failure. > - The failure occurs in git-rebase.sh:403. Is it using the ^0 only >to ma

[PATCH] t3400 (rebase): add failing test for a peculiar rev spec

2013-04-18 Thread Ramkumar Ramachandra
'git rebase' does not recognize revisions specified as :/text. This is because the attempts to rev-parse ${REV}^0, which fails in this case. Add a test to document this failure. Signed-off-by: Ramkumar Ramachandra --- Okay, so I'm not sure what the right fix for this is. - The :/text syntax