Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-09 Thread Ramkumar Ramachandra
Jeff King wrote: That is not actually a submodule, but rather just a repo that happens to be inside our working tree. I know the distinction is subtle, but according to the thread I linked to above, we may actually treat paths with gitlinked index entries separately already (I did not try it,

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-09 Thread Jakub Narębski
W dniu 08.04.2013 23:30, Jeff King pisze: On Mon, Apr 08, 2013 at 03:56:49PM +0530, Ramkumar Ramachandra wrote: git add currently goes past submodule boundaries. Document this bug. It's not just submodules, but we should not recurse into any sub-repository. If I have an unrelated Meta/

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-09 Thread Ramkumar Ramachandra
Jakub Narębski wrote: Hmmm... I used to do (and still do) such not-recommended thing, i.e. keeping git/gitweb/TODO etc. in git/gitweb/.git repository, while having git/gitweb/gitweb.perl in git/.git repository. Why don't you put the gitweb/TODO in a different branch in the git.git repository?

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-09 Thread Jakub Narębski
On 09.04.2013, Ramkumar Ramachandra wrote: Jakub Narębski wrote: Hmmm... I used to do (and still do) such not-recommended thing, i.e. keeping git/gitweb/TODO etc. in git/gitweb/.git repository, while having git/gitweb/gitweb.perl in git/.git repository. Why don't you put the gitweb/TODO in

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-09 Thread Jeff King
On Tue, Apr 09, 2013 at 02:49:24PM +0530, Ramkumar Ramachandra wrote: On the wording issue, a submodule is a submodule whether in-index or otherwise. I would write two different tests: one for in-worktree submodule and another for in-index submodule, and name them appropriately. Does that

[PATCH] t3700 (add): add failing test for add with submodules

2013-04-08 Thread Ramkumar Ramachandra
git add currently goes past submodule boundaries. Document this bug. Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- t/t3700-add.sh | 14 ++ 1 file changed, 14 insertions(+) diff --git a/t/t3700-add.sh b/t/t3700-add.sh index 874b3a6..a1ea050 100755 --- a/t/t3700-add.sh

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-08 Thread Duy Nguyen
On Mon, Apr 8, 2013 at 8:26 PM, Ramkumar Ramachandra artag...@gmail.com wrote: +test_expect_failure 'git add should not go past submodule boundaries' ' + mkdir submodule_dir + ( + cd submodule_dir + git init + cat foo -\EOF +

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-08 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Mon, Apr 8, 2013 at 8:26 PM, Ramkumar Ramachandra artag...@gmail.com wrote: +test_expect_failure 'git add should not go past submodule boundaries' ' + mkdir submodule_dir + ( + cd submodule_dir + git init

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-08 Thread Jeff King
On Mon, Apr 08, 2013 at 03:56:49PM +0530, Ramkumar Ramachandra wrote: git add currently goes past submodule boundaries. Document this bug. It's not just submodules, but we should not recurse into any sub-repository. If I have an unrelated Meta/ repository, I should not be able to git add

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-08 Thread Jeff King
On Mon, Apr 08, 2013 at 03:03:41PM -0700, Junio C Hamano wrote: +test_expect_failure 'git add should not go past submodule boundaries' ' + mkdir submodule_dir + ( + cd submodule_dir + git init + cat foo -\EOF + Some content + EOF