Re: [PATCH 05/15] sequencer: use logmsg_reencode in get_message

On Tue, Jun 10, 2014 at 02:40:30PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Note that we may be fixing a bug here. The existing code > > does: > > > > if (same_encoding(to, from)) > > reencode_string(buf, to, from); > > > > That probably should have been "!same_encoding". >

Re: [PATCH 05/15] sequencer: use logmsg_reencode in get_message

Jeff King writes: > Note that we may be fixing a bug here. The existing code > does: > > if (same_encoding(to, from)) > reencode_string(buf, to, from); > > That probably should have been "!same_encoding". > > Signed-off-by: Jeff King > --- > I didn't actually test for the bug, so it's

[PATCH 05/15] sequencer: use logmsg_reencode in get_message

This simplifies the code, as logmsg_reencode handles the reencoding for us in a single call. It also means we learn logmsg_reencode's trick of pulling the buffer from disk when commit->buffer is NULL (we currently just silently return!). It is doubtful this matters in practice, though, as sequencer