Re: [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS

2013-04-29 Thread Ramsay Jones
Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Ramsay Jones wrote: [snip] While I really like seeing an unfinished topic completed by tying its loose ends like this patch does, it feels a bit too late for the cycle, especially given that we _know_ the changes still need to

Re: [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS

2013-04-28 Thread Jonathan Nieder
Ramsay Jones wrote: After this change, it should be possible to drop the CYGWIN_V15_WIN32API setting without any negative effect. [rj: %s/NATIVE_WINDOWS/GIT_NATIVE_WINDOWS/g ] Signed-off-by: Jonathan Nieder jrnie...@gmail.com Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk Yay!

Re: [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS

2013-04-28 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Ramsay Jones wrote: After this change, it should be possible to drop the CYGWIN_V15_WIN32API setting without any negative effect. [rj: %s/NATIVE_WINDOWS/GIT_NATIVE_WINDOWS/g ] Signed-off-by: Jonathan Nieder jrnie...@gmail.com Signed-off-by:

[PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS

2013-04-27 Thread Ramsay Jones
From: Jonathan Nieder jrnie...@gmail.com Throughout git, it is assumed that the WIN32 preprocessor symbol is defined on native Windows setups (mingw and msvc) and not on Cygwin. On Cygwin, most of the time git can pretend this is just another Unix machine, and Windows-specific magic is generally