[PATCH 1/3] log-tree: make add_name_decoration a public function

2014-08-26 Thread Jeff King
The log-tree code keeps a struct decoration hash to show text decorations for each commit during log traversals. It makes this available to other files by providing global access to the hash. This can result in other code adding entries that do not conform to what log-tree expects. For example,

Re: [PATCH 1/3] log-tree: make add_name_decoration a public function

2014-08-26 Thread Ramsay Jones
On 26/08/14 11:23, Jeff King wrote: The log-tree code keeps a struct decoration hash to show text decorations for each commit during log traversals. It makes this available to other files by providing global access to the hash. This can result in other code adding entries that do not conform

Re: [PATCH 1/3] log-tree: make add_name_decoration a public function

2014-08-26 Thread Jeff King
On Tue, Aug 26, 2014 at 12:48:24PM +0100, Ramsay Jones wrote: We can fix this by making name_decoration's adding function public. If all callers use it, then any changes to structi s/structi/struct/ I blame vi finger-cruft. initialization only need to happen in one place (and because