Re: [PATCH 1/3] name-rev: fix assumption about --name-only usage

2013-07-08 Thread Ramkumar Ramachandra
Junio C Hamano wrote: >> would get name-rev to print output in the same format as describe, >> >> $ git describe --contains --all v1.8.3~1 >> tags/v1.8.3~1 >> >> would not strip the leading "tags/". > > If you _know_ v1.8.3 does not appear outside "tags/", this does look > inconsistent, but I d

Re: [PATCH 1/3] name-rev: fix assumption about --name-only usage

2013-07-07 Thread Junio C Hamano
Ramkumar Ramachandra writes: > 236157 (Teach git-describe how to run name-rev, 2007-05-21) introduced > `git name-rev --name-only`, with the intent of using it to implement > `git describe --contains`. According to the message, users wanted to > use describe to figure out which tags contains a s

[PATCH 1/3] name-rev: fix assumption about --name-only usage

2013-07-07 Thread Ramkumar Ramachandra
236157 (Teach git-describe how to run name-rev, 2007-05-21) introduced `git name-rev --name-only`, with the intent of using it to implement `git describe --contains`. According to the message, users wanted to use describe to figure out which tags contains a specific commit. name-rev already did th