Re: [PATCH 11/13] contrib/subtree: Make each test self-contained

2013-02-18 Thread greened
Junio C Hamano gits...@pobox.com writes: I also think it would be a good idea for you to learn to push back to the original authors; fixing problems in patches by others, while is a good way to learn how their thinking process went, is not necessarily fun. Sure, but in this case I said I'd

[PATCH 11/13] contrib/subtree: Make each test self-contained

2013-02-05 Thread David A. Greene
From: Techlive Zheng techlivezh...@gmail.com Signed-off-by: Techlive Zheng techlivezh...@gmail.com Signed-off-by: David A. Greene gree...@obbligato.org --- contrib/subtree/t/t7900-subtree.sh | 871 +--- 1 file changed, 613 insertions(+), 258 deletions(-) diff

Re: [PATCH 11/13] contrib/subtree: Make each test self-contained

2013-02-05 Thread Junio C Hamano
gree...@obbligato.org writes: Junio C Hamano gits...@pobox.com writes: David A. Greene gree...@obbligato.org writes: +test_create_commit() ( + repo=$1 + commit=$2 + cd $repo + mkdir -p $(dirname $commit) + echo $commit $commit Style. I need a little more explanation. :)

[PATCH 11/13] contrib/subtree: Make each test self-contained

2013-02-04 Thread David A. Greene
From: Techlive Zheng techlivezh...@gmail.com Signed-off-by: Techlive Zheng techlivezh...@gmail.com Signed-off-by: David A. Greene gree...@obbligato.org --- contrib/subtree/t/t7900-subtree.sh | 871 +--- 1 file changed, 613 insertions(+), 258 deletions(-) diff

Re: [PATCH 11/13] contrib/subtree: Make each test self-contained

2013-02-04 Thread Junio C Hamano
David A. Greene gree...@obbligato.org writes: +test_create_commit() ( + repo=$1 + commit=$2 + cd $repo + mkdir -p $(dirname $commit) + echo $commit $commit Style. + git add $commit + git commit -m $commit +) Very nice, but don't we want to check for