Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-06-03 Thread Junio C Hamano
Ramkumar Ramachandra writes: > The documentation of -S and -G is very sketchy. Completely rewrite the > sections in Documentation/diff-options.txt and > Documentation/gitdiffcore.txt. Will queue; thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-06-02 Thread Ramkumar Ramachandra
Junio C Hamano wrote: >> Why do a poor-man's version of --pickaxe-all here, when the last >> paragraph already does justice to this? > > The point of the first paragraph is to serve to help both: My question pertains to whether or not the explanation of --pickaxe-all can wait till the last paragra

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-06-02 Thread Junio C Hamano
Ramkumar Ramachandra writes: >> Without >> --pickaxe-all, only the filepairs matching the given >> criterion is left in the output; all filepairs are left in >> the output when --pickaxe-all is used and if at least one >> filepair matches the given criterio

[PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-31 Thread Ramkumar Ramachandra
The documentation of -S and -G is very sketchy. Completely rewrite the sections in Documentation/diff-options.txt and Documentation/gitdiffcore.txt. References: 52e9578 ([PATCH] Introducing software archaeologist's tool "pickaxe".) f506b8e (git log/diff: add -G that greps in the patch text) Inpu

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-31 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > [...] I agree with everything else, and made changes accordingly. > This transformation limits the set of filepairs to those > that change specified strings between the preimage and the > postimage in a certain way. Definitely good. > -S a

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-24 Thread Junio C Hamano
Ramkumar Ramachandra writes: > The documentation of -S and -G is very sketchy. Completely rewrite the > sections in Documentation/diff-options.txt and > Documentation/gitdiffcore.txt. > > References: > 52e9578 ([PATCH] Introducing software archaeologist's tool "pickaxe".) > f506b8e (git log/diff

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-24 Thread Junio C Hamano
Phil Hord writes: > On Fri, May 24, 2013 at 5:37 AM, Ramkumar Ramachandra > wrote: >> Junio C Hamano wrote: >>> [...] >> >> I agree with the other comments, and have made suitable changes. >> Let's review your block now. >> >>> This transformation is used to find filepairs that represent

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-24 Thread Ramkumar Ramachandra
Phil Hord wrote: > It fits the beginning of the > document where it says this: Ah, I missed that. Either way, I'm quite happy with v3: we can change the first paragraph to use the word "transformation" if we really want. -- To unsubscribe from this list: send the line "unsubscribe git" in the bod

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-24 Thread Phil Hord
On Fri, May 24, 2013 at 5:37 AM, Ramkumar Ramachandra wrote: > Junio C Hamano wrote: >> [...] > > I agree with the other comments, and have made suitable changes. > Let's review your block now. > >> This transformation is used to find filepairs that represent >> two kinds of change

[PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-24 Thread Ramkumar Ramachandra
The documentation of -S and -G is very sketchy. Completely rewrite the sections in Documentation/diff-options.txt and Documentation/gitdiffcore.txt. References: 52e9578 ([PATCH] Introducing software archaeologist's tool "pickaxe".) f506b8e (git log/diff: add -G that greps in the patch text) Inpu

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-24 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > [...] I agree with the other comments, and have made suitable changes. Let's review your block now. > This transformation is used to find filepairs that represent > two kinds of changes, and is controlled by the -S, -G and > --pickaxe-all options.

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-19 Thread Junio C Hamano
Junio C Hamano writes: > Ramkumar Ramachandra writes: > ... >> -G:: >> -Look for differences whose added or removed line matches >> -the given . >> +Grep through the patch text of commits for added/removed lines >> +that match . `--pickaxe-regex` is implied in this >> +mode

Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-17 Thread Junio C Hamano
Ramkumar Ramachandra writes: > diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt > index 104579d..b61a666 100644 > --- a/Documentation/diff-options.txt > +++ b/Documentation/diff-options.txt > @@ -383,14 +383,35 @@ ifndef::git-format-patch[] > that matches other c

[PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

2013-05-17 Thread Ramkumar Ramachandra
The documentation of -S and -G is very sketchy. Completely rewrite the sections in Documentation/diff-options.txt and Documentation/gitdiffcore.txt. References: 52e9578 ([PATCH] Introducing software archaeologist's tool "pickaxe".) f506b8e (git log/diff: add -G that greps in the patch text) Inpu