Re: Recommended configurations (was Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting)

2018-10-24 Thread Junio C Hamano
Jeff King writes: > I do hope that some options will just be no-brainers to enable always, > though (e.g., I think in the long run commit-graph should just default > to "on"; it's cheap to keep up to date and helps proportionally to the > repo size). Same here. We should strive to make any feat

Re: Recommended configurations (was Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting)

2018-10-24 Thread Jeff King
On Wed, Oct 24, 2018 at 11:48:20AM -0400, Derrick Stolee wrote: > Generally, there are a lot of config settings that are likely in the "if you > have a big repo, then you should use this" category. However, there is > rarely a one-size-fits-all solution to these problems, just like there are > dif

Recommended configurations (was Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting)

2018-10-24 Thread Derrick Stolee
On 10/23/2018 4:03 PM, Ævar Arnfjörð Bjarmason wrote: [snip] The --ahead-behind config setting stalled on-list before: https://public-inbox.org/git/36e3a9c3-f7e2-4100-1bfc-647b809a0...@jeffhostetler.com/ Now we have this similarly themed thing. I think we need to be mindful of how changes like

Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting

2018-10-23 Thread Ævar Arnfjörð Bjarmason
On Tue, Oct 23 2018, Ben Peart wrote: > On 10/23/2018 5:13 AM, Ævar Arnfjörð Bjarmason wrote: >> >> On Wed, Oct 17 2018, Jeff King wrote: >> >>> On Wed, Oct 17, 2018 at 02:19:59PM -0400, Eric Sunshine wrote: >>> On Wed, Oct 17, 2018 at 12:40 PM Ben Peart wrote: > Add a reset.quietDefau

Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting

2018-10-23 Thread Jeff King
On Tue, Oct 23, 2018 at 02:11:01PM -0400, Ben Peart wrote: > This sounds like an easy way to choose a set of default values that we think > make sense to get bundled together. That could be a way for users to quickly > choose a set of good defaults but I still think you would want find grained > c

Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting

2018-10-23 Thread Ben Peart
On 10/23/2018 5:13 AM, Ævar Arnfjörð Bjarmason wrote: On Wed, Oct 17 2018, Jeff King wrote: On Wed, Oct 17, 2018 at 02:19:59PM -0400, Eric Sunshine wrote: On Wed, Oct 17, 2018 at 12:40 PM Ben Peart wrote: Add a reset.quietDefault config setting that sets the default value of the --quiet

Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting

2018-10-23 Thread Ævar Arnfjörð Bjarmason
On Wed, Oct 17 2018, Jeff King wrote: > On Wed, Oct 17, 2018 at 02:19:59PM -0400, Eric Sunshine wrote: > >> On Wed, Oct 17, 2018 at 12:40 PM Ben Peart wrote: >> > Add a reset.quietDefault config setting that sets the default value of the >> > --quiet flag when running the reset command. This e

Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting

2018-10-17 Thread Jeff King
On Wed, Oct 17, 2018 at 02:19:59PM -0400, Eric Sunshine wrote: > On Wed, Oct 17, 2018 at 12:40 PM Ben Peart wrote: > > Add a reset.quietDefault config setting that sets the default value of the > > --quiet flag when running the reset command. This enables users to change > > the default behavior

Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting

2018-10-17 Thread Eric Sunshine
On Wed, Oct 17, 2018 at 12:40 PM Ben Peart wrote: > Add a reset.quietDefault config setting that sets the default value of the > --quiet flag when running the reset command. This enables users to change > the default behavior to take advantage of the performance advantages of > avoiding the scan

[PATCH v1 2/2] reset: add new reset.quietDefault config setting

2018-10-17 Thread Ben Peart
From: Ben Peart Add a reset.quietDefault config setting that sets the default value of the --quiet flag when running the reset command. This enables users to change the default behavior to take advantage of the performance advantages of avoiding the scan for unstaged changes after reset. Defaul