Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On Sat, Jul 23, 2016 at 07:27:21AM +, Eric Wong wrote: > Jakub Narębski wrote: > > W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: > > > +use strict; > > > +use warnings; > > > +use autodie; > > > > autodie? > > "set -e" for Perl (man autodie) > > It's been a

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

W dniu 2016-07-25 o 22:09, Lars Schneider pisze: > On 24 Jul 2016, at 22:14, Jakub Narębski wrote: >> W dniu 2016-07-24 o 20:36, Lars Schneider pisze: >>> On 23 Jul 2016, at 02:11, Jakub Narębski wrote: W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

W dniu 2016-07-25 o 22:16, Lars Schneider pisze: > > On 24 Jul 2016, at 23:30, Jakub Narębski wrote: > >> W dniu 2016-07-24 o 22:14, Jakub Narębski pisze: >>> W dniu 2016-07-24 o 20:36, Lars Schneider pisze: >> I agree that the name is not ideal. "UseProtocol" as it is

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

W dniu 2016-07-25 o 22:32, Lars Schneider pisze: > On 25 Jul 2016, at 01:22, Jakub Narębski wrote: >> W dniu 2016-07-25 o 00:36, Ramsay Jones pisze: >>> On 24/07/16 18:16, Lars Schneider wrote: It was a conscious decision to have the `filter` talk first. My reasoning

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 25 Jul 2016, at 01:22, Jakub Narębski wrote: > W dniu 2016-07-25 o 00:36, Ramsay Jones pisze: >> On 24/07/16 18:16, Lars Schneider wrote: >>> On 23 Jul 2016, at 01:19, Ramsay Jones wrote: On 22/07/16 16:49, larsxschnei...@gmail.com wrote:

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 25 Jul 2016, at 00:36, Ramsay Jones wrote: > On 24/07/16 18:16, Lars Schneider wrote: >> >> On 23 Jul 2016, at 01:19, Ramsay Jones wrote: >> >>> On 22/07/16 16:49, larsxschnei...@gmail.com wrote: From: Lars Schneider

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 24 Jul 2016, at 23:30, Jakub Narębski wrote: > W dniu 2016-07-24 o 22:14, Jakub Narębski pisze: >> W dniu 2016-07-24 o 20:36, Lars Schneider pisze: > >>> I agree that the name is not ideal. "UseProtocol" as it is would be a >>> boolean. >>> I thought about "persistent"

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 24 Jul 2016, at 22:14, Jakub Narębski wrote: > W dniu 2016-07-24 o 20:36, Lars Schneider pisze: >> On 23 Jul 2016, at 02:11, Jakub Narębski wrote: >>> W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: From: Lars Schneider

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On Sun, Jul 24, 2016 at 9:11 PM, Lars Schneider wrote: > > On 23 Jul 2016, at 10:14, Eric Wong wrote: > >> larsxschnei...@gmail.com wrote: >>> Please note that the protocol filters do not support stream processing >>> with this implemenatation because

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

Lars Schneider wrote: > On 23 Jul 2016, at 10:14, Eric Wong wrote: > > larsxschnei...@gmail.com wrote: > >> +static struct cmd2process *start_protocol_filter(const char *cmd) > >> +{ > >> + int ret = 1; > >> + struct cmd2process *entry = NULL; > >> +

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

W dniu 2016-07-25 o 00:36, Ramsay Jones pisze: > On 24/07/16 18:16, Lars Schneider wrote: >> On 23 Jul 2016, at 01:19, Ramsay Jones wrote: >>> On 22/07/16 16:49, larsxschnei...@gmail.com wrote: [...] This patch adds the filter..useProtocol option which, if

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 24/07/16 18:16, Lars Schneider wrote: > > On 23 Jul 2016, at 01:19, Ramsay Jones wrote: > >> On 22/07/16 16:49, larsxschnei...@gmail.com wrote: >>> From: Lars Schneider >>> >>> Git's clean/smudge mechanism invokes an external filter

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

W dniu 2016-07-24 o 22:14, Jakub Narębski pisze: > W dniu 2016-07-24 o 20:36, Lars Schneider pisze: >> I agree that the name is not ideal. "UseProtocol" as it is would be a >> boolean. >> I thought about "persistent" but this name wouldn't convey the scope of the >> persistency ("persistent

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

W dniu 2016-07-24 o 20:36, Lars Schneider pisze: > On 23 Jul 2016, at 02:11, Jakub Narębski wrote: >> W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: >>> From: Lars Schneider >> >> Nb. this line is only needed if you want author name and/or

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 10:14, Eric Wong wrote: > larsxschnei...@gmail.com wrote: >> Please note that the protocol filters do not support stream processing >> with this implemenatation because the filter needs to know the length of >> the result in advance. A protocol version 2 could

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 02:11, Jakub Narębski wrote: > W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: >> From: Lars Schneider > > Nb. this line is only needed if you want author name and/or date > different from the email sender, or if you

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 01:19, Ramsay Jones wrote: > On 22/07/16 16:49, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> Git's clean/smudge mechanism invokes an external filter process for every >> single blob that is affected by

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 00:32, Torsten Bögershausen wrote: > On 07/22/2016 05:49 PM, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> [...] >> >> 1. Git starts the filter on first usage and expects a welcome message >> with protocol version

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

larsxschnei...@gmail.com wrote: > Please note that the protocol filters do not support stream processing > with this implemenatation because the filter needs to know the length of > the result in advance. A protocol version 2 could address this in a > future patch. Would it be prudent to reuse

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

Jakub Narębski wrote: > W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: > > +use strict; > > +use warnings; > > +use autodie; > > autodie? "set -e" for Perl (man autodie) It's been a part of Perl for ages, but I've never used it myself, either; I suppose it's fine

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: > From: Lars Schneider Nb. this line is only needed if you want author name and/or date different from the email sender, or if you have sender line misconfigured (e.g. lacking the human readable name). > >

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

Hi Lars, On 23/07/16 00:19, Ramsay Jones wrote: > > > On 22/07/16 16:49, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> Git's clean/smudge mechanism invokes an external filter process for every >> single blob that is affected by a filter. If Git

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 22/07/16 16:49, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > Git's clean/smudge mechanism invokes an external filter process for every > single blob that is affected by a filter. If Git filters a lot of blobs > then the startup time of the external

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 07/22/2016 05:49 PM, larsxschnei...@gmail.com wrote: From: Lars Schneider Git's clean/smudge mechanism invokes an external filter process for every single blob that is affected by a filter. If Git filters a lot of blobs then the startup time of the external

[PATCH v1 3/3] convert: add filter..useProtocol option

From: Lars Schneider Git's clean/smudge mechanism invokes an external filter process for every single blob that is affected by a filter. If Git filters a lot of blobs then the startup time of the external filter processes can become a significant part of the overall Git