Re: [PATCH v13 02/14] apply: rename and move opt constants to apply.h

2016-09-01 Thread Christian Couder
On Wed, Aug 31, 2016 at 11:46 PM, Stefan Beller wrote: > On Sat, Aug 27, 2016 at 11:45 AM, Christian Couder > wrote: >> extern int check_apply_state(struct apply_state *state, int force_apply); >> > > With greater scope comes greater responsibility. Nit of the day: > In case a reroll is necessar

Re: [PATCH v13 02/14] apply: rename and move opt constants to apply.h

2016-08-31 Thread Stefan Beller
On Sat, Aug 27, 2016 at 11:45 AM, Christian Couder wrote: > extern int check_apply_state(struct apply_state *state, int force_apply); > With greater scope comes greater responsibility. Nit of the day: In case a reroll is necessary, consider putting a comment here. (What are these constants? what

[PATCH v13 02/14] apply: rename and move opt constants to apply.h

2016-08-27 Thread Christian Couder
The constants for the "inaccurate-eof" and the "recount" options will be used in both "apply.c" and "builtin/apply.c", so they need to go into "apply.h", and therefore they need a name that is more specific to the API they belong to. Signed-off-by: Christian Couder --- apply.h | 3 +++