[PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Jonathan Nieder
Starting with v1.7.12-rc0~4^2 (build: reconfigure automatically if configure.ac changes, 2012-07-19), configure is automatically run every time the configure script changes. In particular, that means configure is automatically rerun whenever the version number changes (which changes the configure

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Jeff King
On Wed, Jan 02, 2013 at 12:25:44AM -0800, Jonathan Nieder wrote: Starting with v1.7.12-rc0~4^2 (build: reconfigure automatically if configure.ac changes, 2012-07-19), configure is automatically run every time the configure script changes. In particular, that means configure is automatically

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Jonathan Nieder
Jonathan Nieder wrote: Starting with v1.7.12-rc0~4^2 (build: reconfigure automatically if configure.ac changes, 2012-07-19), configure is automatically run every time the configure script changes. In particular, that means configure is automatically rerun whenever the version number changes

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Jonathan Nieder
Jeff King wrote: It seems I am late to the party. But FWIW, this looks the most sane to me of the patches posted in this thread. Thanks. config.status runs ./configure itself, though, so the rule should actually be config.status: configure.ac $(QUIET_GEN)$(MAKE)

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Stefano Lattarini
On 01/02/2013 09:48 AM, Jonathan Nieder wrote: Jeff King wrote: It seems I am late to the party. But FWIW, this looks the most sane to me of the patches posted in this thread. Thanks. config.status runs ./configure itself, though, so the rule should actually be config.status:

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Martin von Zweigbergk
diff --git a/Makefile b/Makefile index 26b697d..2f5e2ab 100644 --- a/Makefile +++ b/Makefile @@ -2167,8 +2167,14 @@ configure: configure.ac GIT-VERSION-FILE $(RM) $+ ifdef AUTOCONFIGURED -config.status: configure - $(QUIET_GEN)if test -f config.status; then \ +# We avoid

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Stefano Lattarini
On 01/02/2013 05:50 PM, Junio C Hamano wrote: Stefano Lattarini stefano.lattar...@gmail.com writes: On 01/02/2013 09:48 AM, Jonathan Nieder wrote: Jeff King wrote: It seems I am late to the party. But FWIW, this looks the most sane to me of the patches posted in this thread. ... FYI,

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Junio C Hamano
Stefano Lattarini stefano.lattar...@gmail.com writes: ifdef AUTOCONFIGURED -config.status: configure -$(QUIET_GEN)if test -f config.status; then \ +# We avoid depending on 'configure' here, because it gets rebuilt +# every time GIT-VERSION-FILE is modified, only to update the embedded

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

2013-01-02 Thread Stefano Lattarini
On 01/02/2013 09:25 PM, Junio C Hamano wrote: Stefano Lattarini stefano.lattar...@gmail.com writes: ifdef AUTOCONFIGURED -config.status: configure - $(QUIET_GEN)if test -f config.status; then \ +# We avoid depending on 'configure' here, because it gets rebuilt +# every time