Re: [PATCH v2 12/13] dir_iterator: new API for iterating over a directory tree

Michael Haggerty writes: > Given that ref-iterators is in next but also that you will soon be > rewinding next, would you like these tweaks as a re-roll of the branch, > as fixup patches to squash on top, or as a new patch series to be > administered separately? A re-roll

Re: [PATCH v2 12/13] dir_iterator: new API for iterating over a directory tree

On 06/09/2016 01:46 PM, Michael Haggerty wrote: > On 06/07/2016 07:13 AM, Eric Sunshine wrote: >> [...] > Thanks for all your great comments! Junio, Given that ref-iterators is in next but also that you will soon be rewinding next, would you like these tweaks as a re-roll of the branch, as fixup

Re: [PATCH v2 12/13] dir_iterator: new API for iterating over a directory tree

On 06/07/2016 07:13 AM, Eric Sunshine wrote: > On Fri, Jun 3, 2016 at 8:33 AM, Michael Haggerty wrote: >> The iterator interface is modeled on that for references, though no >> vtable is necessary because there is (so far?) only one type of >> dir_iterator. >> [...] > >

Re: [PATCH v2 12/13] dir_iterator: new API for iterating over a directory tree

On Fri, Jun 3, 2016 at 8:33 AM, Michael Haggerty wrote: > The iterator interface is modeled on that for references, though no > vtable is necessary because there is (so far?) only one type of > dir_iterator. > [...] Some minor comments below, though probably nothing

[PATCH v2 12/13] dir_iterator: new API for iterating over a directory tree

The iterator interface is modeled on that for references, though no vtable is necessary because there is (so far?) only one type of dir_iterator. There are obviously a lot of features that could easily be added to this class: * Skip/include directory paths in the iteration * Shallow/deep