On Wed, Aug 26, 2015 at 9:48 PM, Junio C Hamano gits...@pobox.com wrote:
Christian Couder christian.cou...@gmail.com writes:
We currently ignore the first line passed to `git interpret-trailers`,
when looking for the beginning of the trailers.
Unfortunately this does not work well when a
Christian Couder christian.cou...@gmail.com writes:
We currently ignore the first line passed to `git interpret-trailers`,
when looking for the beginning of the trailers.
Unfortunately this does not work well when a commit is created with a
line break in the title, using for example the
Christian Couder christian.cou...@gmail.com writes:
Unfortunately this does not work well when a commit is created with a
line break in the title, using for example the following command:
git commit -m 'place of
code: change we made'
I confirm that this patch fixes the behavior for me.
On Tue, Aug 25, 2015 at 11:07 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Christian Couder christian.cou...@gmail.com writes:
Unfortunately this does not work well when a commit is created with a
line break in the title, using for example the following command:
git commit -m 'place
Christian Couder christian.cou...@gmail.com writes:
There is already code to detect a patch in interpret-trailers, but it
relies on the patch starting with a line with only three dashes.
Hmm, then it can be taught to notice everything below... as
another marker, right?
Maybe. I don't know if
Junio C Hamano gits...@pobox.com writes:
While the reordering would certainly stop showing the comments and
patch, I am not sure if that is a move in the right direction. It
will rob from the hooks information that they have traditionally
been given---
The information given in the comments
Sorry I sent the part below privately by mistake:
On Tue, Aug 25, 2015 at 11:07 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Now, I found another issue: I still have this interpret-trailers in my
hooks/commit-msg, and it behaves badly when I use git commit -v. With
-v, I get a diff in
We currently ignore the first line passed to `git interpret-trailers`,
when looking for the beginning of the trailers.
Unfortunately this does not work well when a commit is created with a
line break in the title, using for example the following command:
git commit -m 'place of
code: change we
8 matches
Mail list logo
