Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 1:11 AM, Jonathan Nieder wrote: > (cc-ing the git list) > Felipe Contreras wrote: > >> When an object has already been exported (and thus is in the marks) it >> is flagged as SHOWN, so it will not be exported again, even if this time >> it's exported through a different ref

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Jonathan Nieder
(cc-ing the git list) Felipe Contreras wrote: > When an object has already been exported (and thus is in the marks) it > is flagged as SHOWN, so it will not be exported again, even if this time > it's exported through a different ref. > > We don't need the object to be exported again, but we want

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 11:35 PM, Sverre Rabbelier wrote: > On Tue, Oct 30, 2012 at 3:18 PM, Felipe Contreras > wrote: >> Which is expected and correct; the branch already points to the right >> commit, no need for an extra reset. > > I think you're correct. Thanks for confirming. Thanks for rev

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 3:18 PM, Felipe Contreras wrote: > Which is expected and correct; the branch already points to the right > commit, no need for an extra reset. I think you're correct. Thanks for confirming. -- Cheers, Sverre Rabbelier -- To unsubscribe from this list: send the line "uns

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 10:59 PM, Sverre Rabbelier wrote: > On Tue, Oct 30, 2012 at 2:35 PM, Felipe Contreras > wrote: >> On Tue, Oct 30, 2012 at 10:17 PM, Sverre Rabbelier >> wrote: >>> On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras >>> wrote: Why would it? We are not changing the wa

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 2:35 PM, Felipe Contreras wrote: > On Tue, Oct 30, 2012 at 10:17 PM, Sverre Rabbelier > wrote: >> On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras >> wrote: >>> Why would it? We are not changing the way objects are exported, the >>> only difference is what happens at t

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Jonathan Nieder
Felipe Contreras wrote: > % git fast-export $marks_args one > % git fast-export $marks_args one two > > Then yeah, 'one' will be updated once again in the second command, That's probably worth a mention in the commit message and tests (test_expect_failure), to save future readers from some confus

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras wrote: > Why would it? We are not changing the way objects are exported, the > only difference is what happens at the end > (handle_tags_and_duplicates()). Because the marking is per-commit, not per-ref, right? Perhaps you could add a simple test

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 7:12 PM, Sverre Rabbelier wrote: > On Tue, Oct 30, 2012 at 10:11 AM, Felipe Contreras > wrote: >> When an object has already been exported (and thus is in the marks) it >> is flagged as SHOWN, so it will not be exported again, even if this time >> it's exported through a d

Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly

2012-10-30 Thread Sverre Rabbelier
On Tue, Oct 30, 2012 at 10:11 AM, Felipe Contreras wrote: > When an object has already been exported (and thus is in the marks) it > is flagged as SHOWN, so it will not be exported again, even if this time > it's exported through a different ref. > > We don't need the object to be exported again,