Re: [PATCH v2 4/4] pack-refs: add fully-peeled trait

2013-03-18 Thread Junio C Hamano
Michael Haggerty writes: > Signed-off-by: Michael Haggerty > > and ACK for the whole series, once Junio's points are addressed. > > Regarding Junio's readability suggestion: I agree that his versions are > a bit more readable, albeit at the expense of having to evaluate a bit > more logic for ea

Re: [PATCH v2 4/4] pack-refs: add fully-peeled trait

2013-03-17 Thread Michael Haggerty
Signed-off-by: Michael Haggerty and ACK for the whole series, once Junio's points are addressed. Regarding Junio's readability suggestion: I agree that his versions are a bit more readable, albeit at the expense of having to evaluate a bit more logic for each reference rather than just once when

Re: [PATCH v2 4/4] pack-refs: add fully-peeled trait

2013-03-17 Thread Junio C Hamano
Jeff King writes: > From: Michael Haggerty > > Older versions of pack-refs did not write peel lines for > refs outside of refs/tags. This meant that on reading the > pack-refs file, we might set the REF_KNOWS_PEELED flag for > such a ref, even though we do not know anything about its > peeled va

[PATCH v2 4/4] pack-refs: add fully-peeled trait

2013-03-17 Thread Jeff King
From: Michael Haggerty Older versions of pack-refs did not write peel lines for refs outside of refs/tags. This meant that on reading the pack-refs file, we might set the REF_KNOWS_PEELED flag for such a ref, even though we do not know anything about its peeled value. The previous commit updated