On Mon, Feb 10, 2014 at 3:19 AM, Torsten Bögershausen wrote:
>
> On 2014-02-08 09.53, Duy Nguyen wrote:
file-watcher.c | 32
1 file changed, 32 insertions(+)
>>>
>>> I feel a little bit unsure about the 700.
>>> Most often Git does not care about permissio
On Mon, Feb 10, 2014 at 11:55 PM, Torsten Bögershausen wrote:
> On 2014-02-10 11.37, Duy Nguyen wrote:
>>>
>>> Could we use relative path names internally, relative to $GIT_DIR ?
>>
>> No because this is when the client tell the server about $GIT_DIR. I
>> guess we can use realpath(1) here.
> Good
On 2014-02-10 11.37, Duy Nguyen wrote:
>>
>> Could we use relative path names internally, relative to $GIT_DIR ?
>
> No because this is when the client tell the server about $GIT_DIR. I
> guess we can use realpath(1) here.
Good.
I realized that the watcher can watch several repos at the same time
On Mon, Feb 10, 2014 at 3:19 AM, Torsten Bögershausen wrote:
> Please see filewatcher.c:
> + if (daemon) {
> + int err;
> + strbuf_addf(&sb, "%s/log", socket_path);
> + err = open(sb.buf, O_CREAT | O_TRUNC | O_WRONLY, 0600);
> + adjust_
On 2014-02-08 09.53, Duy Nguyen wrote:
> Thanks for the comments. I can see I now have some work to do in the
> coming weeks :)
>
>>> file-watcher.c | 32
>>> 1 file changed, 32 insertions(+)
>>
>> I feel a little bit unsure about the 700.
>>
Thanks for the comments. I can see I now have some work to do in the
coming weeks :)
On Sat, Feb 8, 2014 at 3:04 PM, Torsten Bögershausen wrote:
> I would appreciate if we could have an outline of the protocol
> as a seperate "document" somewhere, to be able to have a look at the protocol
> first
On 03.02.14 05:28, Nguyễn Thái Ngọc Duy wrote:
I managed to review the code 0..12/26, so some parts are missing.
The list below became longer than what I intended,
my comments may be hard to read,
and there is a mixture of minor and major remarks.
I would appreciate if we could have an outline of
I'm happy with this now. The only things left are applying ewah on the
watch index extension and maybe improve lookup performance a bit. The
former needs jk/pack-bitmap graduated. The latter is not urgent. Oh
and maybe address "BUGS" section (more like known limitations) in
git-file-watcher.txt.
F
8 matches
Mail list logo
