Re: [PATCH v3 5/7] convert: auto_crlf=false and no attributes set: same as binary

On 02/08/2016 07:27 PM, Junio C Hamano wrote: > tbo...@web.de writes: > >> From: Torsten Bögershausen >> >> When core.autocrlf is set to false, and no attributes are set, the file >> is treated as binary. > This, and also on the title, I know by "binary" you mean "no > conversion

Re: [PATCH v3 5/7] convert: auto_crlf=false and no attributes set: same as binary

Torsten Bögershausen writes: >> * convert_attrs() has "If BINARY don't do anything and return". >>Will the patch change behaviour for the "not-autocrlf, >>CRLF_GUESS" case in this codepath? I think ca->crlf_action used >>to be left as CRLF_GUESS here before the

Re: [PATCH v3 5/7] convert: auto_crlf=false and no attributes set: same as binary

tbo...@web.de writes: > From: Torsten Bögershausen > > When core.autocrlf is set to false, and no attributes are set, the file > is treated as binary. This, and also on the title, I know by "binary" you mean "no conversion is attempted", and it is the word used in the code around

[PATCH v3 5/7] convert: auto_crlf=false and no attributes set: same as binary

From: Torsten Bögershausen When core.autocrlf is set to false, and no attributes are set, the file is treated as binary. Simplify the logic and remove duplicated code when dealing with (crlf_action == CRLF_GUESS && auto_crlf == AUTO_CRLF_FALSE) by setting crlf_action=CRLF_BINARY