Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread Philip Oakley
From: "Felipe Contreras" Sent: Sunday, June 09, 2013 6:23 PM On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor wrote: On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote: We should free objects before leaving. Signed-off-by: Felipe Contreras A shortlog-friendlier subject could be

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread SZEDER Gábor
On Sun, Jun 09, 2013 at 02:11:18PM -0500, Felipe Contreras wrote: > Perhaps "trivial memory leak fix" would be better. That's fine with me, thanks. If only we could have got there like 10 emails ago. Gábor -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a messa

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread Felipe Contreras
On Sun, Jun 9, 2013 at 2:01 PM, John Keeping wrote: > On Sun, Jun 09, 2013 at 12:53:38PM -0500, Felipe Contreras wrote: >> On Sun, Jun 9, 2013 at 12:37 PM, John Keeping wrote: >> > On Sun, Jun 09, 2013 at 07:33:42PM +0200, SZEDER Gábor wrote: >> >> On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread John Keeping
On Sun, Jun 09, 2013 at 12:53:38PM -0500, Felipe Contreras wrote: > On Sun, Jun 9, 2013 at 12:37 PM, John Keeping wrote: > > On Sun, Jun 09, 2013 at 07:33:42PM +0200, SZEDER Gábor wrote: > >> On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote: > >> > On Sun, Jun 9, 2013 at 12:18 PM,

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread Felipe Contreras
On Sun, Jun 9, 2013 at 12:53 PM, SZEDER Gábor wrote: > On Sun, Jun 09, 2013 at 12:47:16PM -0500, Felipe Contreras wrote: >> On Sun, Jun 9, 2013 at 12:33 PM, SZEDER Gábor wrote: >> > On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote: >> >> On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gáb

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread Felipe Contreras
On Sun, Jun 9, 2013 at 12:37 PM, John Keeping wrote: > On Sun, Jun 09, 2013 at 07:33:42PM +0200, SZEDER Gábor wrote: >> On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote: >> > On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor wrote: >> > > On Sun, Jun 09, 2013 at 11:40:22AM -0500, Feli

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread SZEDER Gábor
On Sun, Jun 09, 2013 at 12:47:16PM -0500, Felipe Contreras wrote: > On Sun, Jun 9, 2013 at 12:33 PM, SZEDER Gábor wrote: > > On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote: > >> On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor wrote: > >> > On Sun, Jun 09, 2013 at 11:40:22AM -0500,

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread Felipe Contreras
On Sun, Jun 9, 2013 at 12:33 PM, SZEDER Gábor wrote: > On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote: >> On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor wrote: >> > On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote: >> >> We should free objects before leaving. >> >

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread John Keeping
On Sun, Jun 09, 2013 at 07:33:42PM +0200, SZEDER Gábor wrote: > On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote: > > On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor wrote: > > > On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote: > > >> We should free objects before le

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread SZEDER Gábor
On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote: > On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor wrote: > > On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote: > >> We should free objects before leaving. > >> > >> Signed-off-by: Felipe Contreras > > > > A shortlog-f

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread Felipe Contreras
On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor wrote: > On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote: >> We should free objects before leaving. >> >> Signed-off-by: Felipe Contreras > > A shortlog-friendlier subject could be: "sequencer: free objects > before leaving". I alrea

Re: [PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread SZEDER Gábor
On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote: > We should free objects before leaving. > > Signed-off-by: Felipe Contreras A shortlog-friendlier subject could be: "sequencer: free objects before leaving". -- To unsubscribe from this list: send the line "unsubscribe git" in t

[PATCH v4 10/45] sequencer: trivial fix

2013-06-09 Thread Felipe Contreras
We should free objects before leaving. Signed-off-by: Felipe Contreras --- builtin/sequencer.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/builtin/sequencer.c b/builtin/sequencer.c index b2c8c94..23b01b7 100644 --- a/builtin/sequencer.c +++ b/builtin/sequencer.c @@