RE: [PATCH v4 3/4] Bring NonStop platform definitions up to date in git-compat-util.h

2018-01-24 Thread Randall S. Becker 
On January 24, 2018 4:18 PM, Junio C Hamano wrote:
> 
> "Randall S. Becker"  writes:
> 
> >> > +#ifdef __TANDEM
> >> > +#if !defined(_THREAD_SUPPORT_FUNCTIONS) &&
> >> !defined(_PUT_MODEL_)
> >> > +/* #include
> >> > +
> >> > +*/
> >> > +/* #include  */ #endif
> >>
> >> The above adds a conditional no-op?  That's confusing...
> >
> > We are trying to make PUT work with git on NonStop. I can't tell you
> > how much of a pain it is. This is a placeholder for others (outside
> > our group) to know where to muck. I can remove it if you don't want it
> there.
> 
> It is OK as long as it was done on purpose.  I was just making sure that
this
> was an unfinished WIP sent by mistake before proofreading.

Absolutely definitely positively on purpose and when it we get PUT working
in FLOSS, this is *so* going to happen. :-)

Re: [PATCH v4 3/4] Bring NonStop platform definitions up to date in git-compat-util.h

2018-01-24 Thread Junio C Hamano 
Junio C Hamano  writes:

> "Randall S. Becker"  writes:
>
>>> > +#ifdef __TANDEM
>>> > +#if !defined(_THREAD_SUPPORT_FUNCTIONS) &&
>>> !defined(_PUT_MODEL_)
>>> > +/* #include 
>>> > +*/
>>> > +/* #include  */
>>> > +#endif
>>> 
>>> The above adds a conditional no-op?  That's confusing...
>>
>> We are trying to make PUT work with git on NonStop. I can't tell you how
>> much of a pain it is. This is a placeholder for others (outside our group)
>> to know where to muck. I can remove it if you don't want it there.
>
> It is OK as long as it was done on purpose.  I was just making sure
> that this was an unfinished WIP sent by mistake before proofreading.

Obviously, I was trying to make sure it was *NOT* an incomplete
state you did not intend to send ;-)

Re: [PATCH v4 3/4] Bring NonStop platform definitions up to date in git-compat-util.h

2018-01-24 Thread Junio C Hamano 
"Randall S. Becker"  writes:

>> > +#ifdef __TANDEM
>> > +#if !defined(_THREAD_SUPPORT_FUNCTIONS) &&
>> !defined(_PUT_MODEL_)
>> > +/* #include 
>> > +*/
>> > +/* #include  */
>> > +#endif
>> 
>> The above adds a conditional no-op?  That's confusing...
>
> We are trying to make PUT work with git on NonStop. I can't tell you how
> much of a pain it is. This is a placeholder for others (outside our group)
> to know where to muck. I can remove it if you don't want it there.

It is OK as long as it was done on purpose.  I was just making sure
that this was an unfinished WIP sent by mistake before proofreading.

RE: [PATCH v4 3/4] Bring NonStop platform definitions up to date in git-compat-util.h

2018-01-24 Thread Randall S. Becker 
On January 24, 2018 3:36 PM, Junio C Hamano wrote:
> randall.s.bec...@rogers.com writes:
> 
> > From: "Randall S. Becker" 
> >
> > Add correct FLOSS (NonStop platform emulation) definitions into
> > git-compat-util.h to allow correct emulation of non-platform
> > behaviour. Also added NSIG definition that is not explicitly supplied
> > in signal.h on platform.
> >
> > Signed-off-by: Randall S. Becker 
> > ---
> >  git-compat-util.h | 15 +++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/git-compat-util.h b/git-compat-util.h index
> > 68b2ad531..fb3ef0dcf 100644
> > --- a/git-compat-util.h
> > +++ b/git-compat-util.h
> > @@ -378,6 +378,21 @@ static inline char *git_find_last_dir_sep(const
> > char *path)  #define find_last_dir_sep git_find_last_dir_sep  #endif
> >
> > +#ifdef __TANDEM
> > +#if !defined(_THREAD_SUPPORT_FUNCTIONS) &&
> !defined(_PUT_MODEL_)
> > +/* #include 
> > +*/
> > +/* #include  */
> > +#endif
> 
> The above adds a conditional no-op?  That's confusing...

We are trying to make PUT work with git on NonStop. I can't tell you how
much of a pain it is. This is a placeholder for others (outside our group)
to know where to muck. I can remove it if you don't want it there.
 
> > +#include 
> > +#include 
> > +#if ! defined NSIG
> > +/* NonStop NSE and NSX do not provide NSIG. SIGGUARDIAN(99) is the
> highest
> > +   known, by detective work using kill -l as a list is all signals
> > +   instead of signal.h where it should be. */ # define NSIG 100
> > +#endif #endif
> > +
> >  #if defined(__HP_cc) && (__HP_cc >= 61000)  #define NORETURN
> > __attribute__((noreturn))  #define NORETURN_PTR

Re: [PATCH v4 3/4] Bring NonStop platform definitions up to date in git-compat-util.h

2018-01-24 Thread Junio C Hamano 
randall.s.bec...@rogers.com writes:

> From: "Randall S. Becker" 
>
> Add correct FLOSS (NonStop platform emulation) definitions into
> git-compat-util.h to allow correct emulation of non-platform
> behaviour. Also added NSIG definition that is not explicitly
> supplied in signal.h on platform.
>
> Signed-off-by: Randall S. Becker 
> ---
>  git-compat-util.h | 15 +++
>  1 file changed, 15 insertions(+)
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 68b2ad531..fb3ef0dcf 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -378,6 +378,21 @@ static inline char *git_find_last_dir_sep(const char 
> *path)
>  #define find_last_dir_sep git_find_last_dir_sep
>  #endif
>  
> +#ifdef __TANDEM
> +#if !defined(_THREAD_SUPPORT_FUNCTIONS) && !defined(_PUT_MODEL_)
> +/* #include  */
> +/* #include  */
> +#endif

The above adds a conditional no-op?  That's confusing...

> +#include 
> +#include 
> +#if ! defined NSIG
> +/* NonStop NSE and NSX do not provide NSIG. SIGGUARDIAN(99) is the highest
> +   known, by detective work using kill -l as a list is all signals
> +   instead of signal.h where it should be. */
> +# define NSIG 100
> +#endif
> +#endif
> +
>  #if defined(__HP_cc) && (__HP_cc >= 61000)
>  #define NORETURN __attribute__((noreturn))
>  #define NORETURN_PTR

[PATCH v4 3/4] Bring NonStop platform definitions up to date in git-compat-util.h

2018-01-21 Thread randall . s . becker 
From: "Randall S. Becker" 

Add correct FLOSS (NonStop platform emulation) definitions into
git-compat-util.h to allow correct emulation of non-platform
behaviour. Also added NSIG definition that is not explicitly
supplied in signal.h on platform.

Signed-off-by: Randall S. Becker 
---
 git-compat-util.h | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/git-compat-util.h b/git-compat-util.h
index 68b2ad531..fb3ef0dcf 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -378,6 +378,21 @@ static inline char *git_find_last_dir_sep(const char *path)
 #define find_last_dir_sep git_find_last_dir_sep
 #endif
 
+#ifdef __TANDEM
+#if !defined(_THREAD_SUPPORT_FUNCTIONS) && !defined(_PUT_MODEL_)
+/* #include  */
+/* #include  */
+#endif
+#include 
+#include 
+#if ! defined NSIG
+/* NonStop NSE and NSX do not provide NSIG. SIGGUARDIAN(99) is the highest
+   known, by detective work using kill -l as a list is all signals
+   instead of signal.h where it should be. */
+# define NSIG 100
+#endif
+#endif
+
 #if defined(__HP_cc) && (__HP_cc >= 61000)
 #define NORETURN __attribute__((noreturn))
 #define NORETURN_PTR
-- 
2.16.0.31.gf1a482c