Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-11 Thread Eric Sunshine
On Wed, Apr 11, 2018 at 4:50 PM, Thomas Gummerer wrote: > And just as I'm re-reading my commit messages, I guess there was one > more motivation for printing the "HEAD is now at ..." line ourselves: > > If the '--no-checkout' flag is given, the output of 'git worktree add' > is just: > >

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-11 Thread Thomas Gummerer
On 04/11, Thomas Gummerer wrote: > On 04/09, Eric Sunshine wrote: > > On Mon, Apr 9, 2018 at 3:30 PM, Thomas Gummerer > > wrote: > > > On 04/08, Eric Sunshine wrote: > > >> As with Junio, I'm fine with this hidden option (for now), however, I > > >> think you can take this a step further. Rather

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-11 Thread Eric Sunshine
On Wed, Apr 11, 2018 at 4:09 PM, Thomas Gummerer wrote: > On 04/09, Eric Sunshine wrote: >> Another solution would be not to augment the "HEAD is now at..." >> message at all. I realize that that augmentation was one of the >> original motivations for this patch series, but with the upcoming >> re

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-11 Thread Thomas Gummerer
On 04/09, Eric Sunshine wrote: > On Mon, Apr 9, 2018 at 3:30 PM, Thomas Gummerer wrote: > > On 04/08, Eric Sunshine wrote: > >> As with Junio, I'm fine with this hidden option (for now), however, I > >> think you can take this a step further. Rather than having a (hidden) > >> git-reset option whi

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-09 Thread Eric Sunshine
On Mon, Apr 9, 2018 at 3:30 PM, Thomas Gummerer wrote: > On 04/08, Eric Sunshine wrote: >> As with Junio, I'm fine with this hidden option (for now), however, I >> think you can take this a step further. Rather than having a (hidden) >> git-reset option which suppresses "HEAD is now at...", instea

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-09 Thread Thomas Gummerer
On 04/08, Eric Sunshine wrote: > On Sun, Apr 8, 2018 at 10:24 AM, Thomas Gummerer wrote: > > On 04/08, Eric Sunshine wrote: > >> On Sat, Mar 31, 2018 at 11:17 AM, Thomas Gummerer > >> wrote: > > Let me think through some of the cases here, of 'git worktre add > > ' with various flags and what t

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-09 Thread Thomas Gummerer
On 04/08, Eric Sunshine wrote: > On Sat, Mar 31, 2018 at 11:17 AM, Thomas Gummerer > wrote: > > This round should fix all the UI issues Eric found in the last round. > > The changes I made in a bit more detail: > > > > - added a new commit introducing a new hidden --show-new-head-line > > flag

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-08 Thread Eric Sunshine
On Sun, Apr 8, 2018 at 10:24 AM, Thomas Gummerer wrote: > On 04/08, Eric Sunshine wrote: >> On Sat, Mar 31, 2018 at 11:17 AM, Thomas Gummerer >> wrote: > Let me think through some of the cases here, of 'git worktre add > ' with various flags and what the UI would be with > that added: > > - n

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-08 Thread Thomas Gummerer
On 04/08, Eric Sunshine wrote: > On Sat, Mar 31, 2018 at 11:17 AM, Thomas Gummerer > wrote: > > This round should fix all the UI issues Eric found in the last round. > > The changes I made in a bit more detail: > > > > - added a new commit introducing a new hidden --show-new-head-line > > flag

Re: [PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-04-08 Thread Eric Sunshine
On Sat, Mar 31, 2018 at 11:17 AM, Thomas Gummerer wrote: > This round should fix all the UI issues Eric found in the last round. > The changes I made in a bit more detail: > > - added a new commit introducing a new hidden --show-new-head-line > flag in 'git reset'. This is used to suppress the

[PATCH v6 0/6] worktree: teach "add" to check out existing branches

2018-03-31 Thread Thomas Gummerer
Thanks Eric for the review of the last round. Previous rounds are at <20180121120208.12760-1-t.gumme...@gmail.com>, <20180204221305.28300-1-t.gumme...@gmail.com>, <20180317220830.30963-1-t.gumme...@gmail.com>, <2018031719.4940-1-t.gumme...@gmail.com> and 20180325134947.25828-1-t.gumme...@gmail