Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-27 Thread Mehul Jain
On Thu, May 26, 2016 at 10:29 PM, Jeff King wrote: > On Thu, May 26, 2016 at 06:36:46PM +0530, Mehul Jain wrote: > The documentation here mentions "log" and "show". But I think this will > affect other programs, too, including "whatchanged" and "reflog". Those > ones are probably

Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Pranit Bauva
Hey Mehul, On Thu, May 26, 2016 at 8:34 PM, Mehul Jain wrote: > Hi Remi, > > Thanks for your input. > > On Thu, May 26, 2016 at 7:12 PM, Remi Galan Alfonso > wrote: >> Hi Mehul, >> >> Mehul Jain

Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Jeff King
On Thu, May 26, 2016 at 06:36:46PM +0530, Mehul Jain wrote: > diff --git a/Documentation/git-log.txt b/Documentation/git-log.txt > index 03f9580..f39f800 100644 > --- a/Documentation/git-log.txt > +++ b/Documentation/git-log.txt > @@ -196,6 +196,10 @@ log.showRoot:: > `git log -p` output

Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Mehul Jain
On Thu, May 26, 2016 at 9:13 PM, Remi Galan Alfonso wrote: > Sorry, I should have made explicit what went through my mind. > "When log.showsignature set true" doesn't sound right to me, while > "When log.showsignature is set to true" sounds better,

Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Remi Galan Alfonso
Mehul Jain writes: > Hi Remi, > > Thanks for your input. > > On Thu, May 26, 2016 at 7:12 PM, Remi Galan Alfonso > wrote: > > Hi Mehul, > > > > Mehul Jain writes: > >> When log.showsignature set

Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Mehul Jain
Hi Remi, Thanks for your input. On Thu, May 26, 2016 at 7:12 PM, Remi Galan Alfonso wrote: > Hi Mehul, > > Mehul Jain writes: >> When log.showsignature set true, "git log" and "git show" will behave > > 'When

Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Remi Galan Alfonso
Hi Mehul, Mehul Jain writes: > People may want to always use "--show-signature" while using "git log" > or "git show". > > When log.showsignature set true, "git log" and "git show" will behave 'When log.showsignature is set to true' ? > as "--show-signature" was

[RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Mehul Jain
People may want to always use "--show-signature" while using "git log" or "git show". When log.showsignature set true, "git log" and "git show" will behave as "--show-signature" was given to them. Signed-off-by: Mehul Jain --- Documentation/git-log.txt | 4