Re: [RFC PATCH 00/12] Base SHA-256 algorithm implementation

2018-08-29 Thread brian m. carlson
On Thu, Aug 30, 2018 at 02:21:51AM +, brian m. carlson wrote: > On Wed, Aug 29, 2018 at 11:37:25AM +0200, Ævar Arnfjörð Bjarmason wrote: > > > It seems to me that aside from t/helper/test-hash-speed.c and > > t/t0014-hash.sh everything being added here modifies existing files with > > many

Re: [RFC PATCH 00/12] Base SHA-256 algorithm implementation

2018-08-29 Thread brian m. carlson
On Wed, Aug 29, 2018 at 11:37:25AM +0200, Ævar Arnfjörð Bjarmason wrote: > It seems to me that aside from t/helper/test-hash-speed.c and > t/t0014-hash.sh everything being added here modifies existing files with > many authors, and would thus also need their permission to re-license as > anything

Re: [RFC PATCH 00/12] Base SHA-256 algorithm implementation

2018-08-29 Thread Ævar Arnfjörð Bjarmason
On Wed, Aug 29 2018, brian m. carlson wrote: > If libgit2 would like to import this SHA-256 implementation, they're > welcome to do so under their normal license terms. If not, that's fine, > too. For them and anyone else interested in such re-use, can you elaborate on which parts? It seems

[RFC PATCH 00/12] Base SHA-256 algorithm implementation

2018-08-28 Thread brian m. carlson
This RFC series provides an actual SHA-256 implementation and wires it up, along with a few housekeeping patches to make it usable for testing. As discussed in some threads, this changes the algorithm name from "sha-1" to "sha1" (and also adds "sha256") because it's far easier to type. I